> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. > > Iamluc wrote: > Thanks you for the review. > > I don't have an SVN account yet (and I think it's too early to ask one). > So could you please commit the patch for me ? > > Simon Stiphanos wrote: > Hello IamLuc and Beat Wolf, > > I reported the original bug and would like to point out how to better fix > it than this patch currently does. The "Plasma::Label" is extremely large for > what is being reported. It should be much smaller to encase just enough for > the text because there is no reason to waste such a large amount of real > estate. > > Do you agree? > > Beat Wolf wrote: > i wait for now with commiting > > Iamluc wrote: > Hi Simon, > > Maybe the popup is too big for an empty folder, but we need "empty space" > in case we want to create a new file (ie, right-click > new) or paste > files/folders. > > For the moment, all the popups have the same size. More generally than > for an empty folder, I think what you want is to automatically resize the > popup according to its content (If there is only 1 file, the popup must be > smaller than if there are 10 files). > Am I correct ? If yes, I think we need advices/comments about this > behaviour with more "experimented" plasma developpers (It's only my first > patch !) > > (Sorry for my poor english, I hope you will understand :-/) >
Thanks for the reply IamLuc, but that's not exactly what I mean. Is it at all possible to resize just this element? (And your English is still very readable :) - Simon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6422 ----------------------------------------------------------- On 2010-07-03 17:11:02, Iamluc wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4519/ > ----------------------------------------------------------- > > (Updated 2010-07-03 17:11:02) > > > Review request for Plasma. > > > Summary > ------- > > Hello, > > This patch add a Plasma::Label with text "This folder is empty." in > Folderview's Popup when the folder is empty. > > The related bug number in kde bugzilla is 201542. > > Luc > > > This addresses bug 201542. > https://bugs.kde.org/show_bug.cgi?id=201542 > > > Diffs > ----- > > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1145373 > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1145373 > /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h 1145373 > /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp 1145373 > > Diff: http://reviewboard.kde.org/r/4519/diff > > > Testing > ------- > > Delete/add files several times. The label disappears/appears correctly. > > > Screenshots > ----------- > > folderview empty folder > http://reviewboard.kde.org/r/4519/s/444/ > > > Thanks, > > Iamluc > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
