----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4548/#review6432 -----------------------------------------------------------
Ship it! i did looked at it quite a bit while in branch, i think it's ready to go in, so we can fix any potemtial problem left and star the akonadi migration - Marco On 2010-07-08 16:47:24, Brian Pritchett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4548/ > ----------------------------------------------------------- > > (Updated 2010-07-08 16:47:24) > > > Review request for Plasma. > > > Summary > ------- > > DataEngines can mark or unmark their sources to be cached with void > DataEngine::setEnableCache(const QString &source, bool cache). If the > DataEngine has implemented their own source by inheriting DataContainer, then > DataContainer::setEnableCache(bool cache) will work. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1147556 > /trunk/KDE/kdelibs/plasma/data/operations/storage.operations PRE-CREATION > /trunk/KDE/kdelibs/plasma/datacontainer.h 1147556 > /trunk/KDE/kdelibs/plasma/datacontainer.cpp 1147556 > /trunk/KDE/kdelibs/plasma/dataengine.h 1147556 > /trunk/KDE/kdelibs/plasma/dataengine.cpp 1147556 > /trunk/KDE/kdelibs/plasma/private/dataengine_p.h 1147556 > /trunk/KDE/kdelibs/plasma/private/storage.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/storage.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/4548/diff > > > Testing > ------- > > I have tested it with the microblogging dataengine/plasmoid. > > > Thanks, > > Brian > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
