Re: Review Request: Fix empty-line-glow-effect in Notifications widget

2010-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3042/#review4264 --- Ship it! - Aaron On 2010-02-24 01:05:16, Jonathan Thomas wrote: >

Review Request: Fix empty-line-glow-effect in Notifications widget

2010-02-23 Thread Jonathan Thomas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3042/ --- Review request for Plasma. Summary --- Instead of blindly inserting a into

libplasma and scripting

2010-02-23 Thread Aaron J. Seigo
hi all.. this is just a reminder that _whenever_ you add any setters/getters to classes in plasma/widgets/*h you must add a corresponding Q_PROPERTY to the class otherwise it will not appear in the script bindings. signals and slots don't need this, unless the slot is a setter or a getter, in

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/#review4261 --- Ship it! - Aaron On 2010-02-23 12:46:46, Vincenzo Di Massa wrote: >

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
> On 2010-02-23 15:12:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, lines 150-153 > > > > > > Applet::init() should definitely be called in the if (!isContainment()) > > block, but Applet::init()

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Richard Dale
> On 2010-02-23 15:12:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, lines 150-153 > > > > > > Applet::init() should definitely be called in the if (!isContainment()) > > block, but Applet::init()

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/#review4252 --- /trunk/KDE/kdelibs/plasma/containment.cpp

Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Vincenzo Di Massa
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/ --- Review request for Plasma. Summary --- Can this be harmful? I think this co

Re: Rowspan & Colspan in Javascript GridLayout

2010-02-23 Thread Aaron J. Seigo
On February 22, 2010, Mathieu Ducharme wrote: > Hi Wayne, > > On Mon, Feb 22, 2010 at 5:48 PM, wayne speir wrote: > > Mathieu, > > > > What is it doing or not doing? > > > > -- Wayne > > Thanks for the prompt reply. > > Sorry I was not clear. Rowspan and colspan do not seem to be taken > into