----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/#review4252 -----------------------------------------------------------
/trunk/KDE/kdelibs/plasma/containment.cpp <http://reviewboard.kde.org/r/3041/#comment3774> Applet::init() should definitely be called in the if (!isContainment()) block, but Applet::init() does various things that aren't appropriate for Containment. the only useful part in Applet::init() would be the package object creation. i'd suggest taking that part out of Applet::init(), moving it to a method in AppletPrivate and then calling it from both Applet::init() as well as Containment::init(). - Aaron On 2010-02-23 12:46:46, Vincenzo Di Massa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3041/ > ----------------------------------------------------------- > > (Updated 2010-02-23 12:46:46) > > > Review request for Plasma. > > > Summary > ------- > > Can this be harmful? I think this could be useful in order to allow scripted > containments. But I must confess I don't understand how the whole thing > works, so maybe there is a reason why this one liner is not already in plasma > :-) > > > This addresses bug 227767. > https://bugs.kde.org/show_bug.cgi?id=227767 > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/containment.cpp 1092102 > > Diff: http://reviewboard.kde.org/r/3041/diff > > > Testing > ------- > > I'm using this patch on my work machine... I can not spot any problem and I > was able to make scripted containments sort of work. > > > Thanks, > > Vincenzo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
