----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3042/#review4264 -----------------------------------------------------------
Ship it! - Aaron On 2010-02-24 01:05:16, Jonathan Thomas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3042/ > ----------------------------------------------------------- > > (Updated 2010-02-24 01:05:16) > > > Review request for Plasma. > > > Summary > ------- > > Instead of blindly inserting a <br> into the string, only do so if we have > more stuff to add later that would justify inserting the <br> > > > This addresses bug 227929. > https://bugs.kde.org/show_bug.cgi?id=227929 > > > Diffs > ----- > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/core/extendertask.cpp > 1095289 > > Diff: http://reviewboard.kde.org/r/3042/diff > > > Testing > ------- > > Backported my patch to 4.4 for personal use. I tested having no > notifications, having a job running, and having a paused job plus a job > running. Linebreaks are inserted properly, if there is more text to show > afterwards. > > > Thanks, > > Jonathan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
