---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/#review551
---
Ship it!
probably still some room for minor improvements, but can go in
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/
---
(Updated 2009-03-21 21:58:52.032707)
Review request for Plasma.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/#review550
---
cool feature; small issue with the use of dbus (blocking vs non-blocking
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/
---
(Updated 2009-03-21 16:39:35.569903)
Review request for Plasma.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/
---
Review request for Plasma.
Summary
---
This patch adds a new page to the con
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/373/
---
(Updated 2009-03-21 14:06:55.122599)
Review request for Plasma.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/377/#review549
---
Ship it!
- Aaron
On 2009-03-21 11:51:38, Christian Loose wrote:
>
>
On Saturday 21 March 2009, Dario Freddi wrote:
> Another thing: we shouldn't let :q: always translate to "search term": for
> example, the powerdevil runner lets you enter screen brightness
> , and having the user read "screen brightness "
> can be confusing.
>
> Apart from PowerDevil, each runner
On Saturday 21 March 2009, Dario Freddi wrote:
> A syntax can have unlimited examples but one single description. This is
> the only weird point to me. I don't really get when I should add another
> example to the syntax or a completely different syntax, since I can
> document only a syntax, and no
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/377/
---
(Updated 2009-03-21 11:51:38.095921)
Review request for Plasma.
Changes
---
> On 2009-03-21 10:09:28, Aaron Seigo wrote:
> > the concept is good, however the two showContextMenu methods in
> > ContextMenuFactory should be harmonized. both produce a QModelIndex and
> > then from that point forward it looks like the code is pretty much
> > duplicated between the two.
>
Another thing: we shouldn't let :q: always translate to "search term": for
example, the powerdevil runner lets you enter screen brightness ,
and having the user read "screen brightness " can be confusing.
Apart from PowerDevil, each runner that triggers an action with a parameter
would actually
Hello,
This patch is really some great stuff, since it is the really needed first
step to build docs for KRunners. Though, I have one main concern about the
example syntaxes and description.
A syntax can have unlimited examples but one single description. This is the
only weird point to me. I
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/373/
---
(Updated 2009-03-21 10:10:49.543387)
Review request for Plasma.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/377/#review547
---
the concept is good, however the two showContextMenu methods in
Context
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/377/
---
Review request for Plasma.
Summary
---
This patch adds the kickoff context m
On Saturday 21 March 2009, Marco Martin wrote:
> On Friday 20 March 2009, Aaron J. Seigo wrote:
> > On Wednesday 18 March 2009, Marco Martin wrote:
> > > -setMovie() we are on dbus now, sending the binary data is already
> > > expensive enough
> >
> > well, for animations it probably makes sense to
On Saturday 21 March 2009, Aaron J. Seigo wrote:
> On Friday 20 March 2009, Marco Martin wrote:
> > On Friday 20 March 2009, Aaron J. Seigo wrote:
> > > On Wednesday 18 March 2009, Marco Martin wrote:
> > > > -setMovie() we are on dbus now, sending the binary data is already
> > > > expensive enoug
On Friday 20 March 2009, Aaron J. Seigo wrote:
> On Wednesday 18 March 2009, Marco Martin wrote:
> > -setMovie() we are on dbus now, sending the binary data is already
> > expensive enough
>
> well, for animations it probably makes sense to send all the frames across
> at once and then animate them
19 matches
Mail list logo
