Another thing: we shouldn't let :q: always translate to "search term": for example, the powerdevil runner lets you enter screen brightness <brightness>, and having the user read "screen brightness <search term>" can be confusing.
Apart from PowerDevil, each runner that triggers an action with a parameter would actually be affected. We should give developers the possibility to set their own replacement for "search term", in case it is needed. And, purely for the api, maybe syntax()->syntaxes(), since it returns a QList. We could eventually provide an addSyntaxes(QList syntaxes); I don't know if it could be of any use. On Saturday 21 March 2009 18:10:49 Aaron Seigo wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/373/ > ----------------------------------------------------------- > > (Updated 2009-03-21 10:10:49.543387) > > > Review request for Plasma. > > > Changes > ------- > > added apidox. a review of the API, thoughts on it being a nested class, etc > would be appreciated. :) > > > Summary > ------- > > Patch provides syntax registration for runners in kdebase. > > > Diffs (updated) > ----- > > trunk/KDE/kdelibs/plasma/abstractrunner.h 942401 > trunk/KDE/kdelibs/plasma/abstractrunner.cpp 942401 > trunk/KDE/kdelibs/plasma/runnermanager.cpp 942401 > > Diff: http://reviewboard.kde.org/r/373/diff > > > Testing > ------- > > > Thanks, > > Aaron > > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel -- ------------------- Dario Freddi KDE Developer GPG Key Signature: 511A9A3B
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
