----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/380/#review551 -----------------------------------------------------------
Ship it! probably still some room for minor improvements, but can go in as the patch is getting pretty big and is functional Screenshot: General Page <http://reviewboard.kde.org//r/380/#scomment19> misalignment. there should be one grid layout on this whole page so that everything lines up there. trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp <http://reviewboard.kde.org/r/380/#comment334> not that it matters, but could be one if with an && between the two tests - Aaron On 2009-03-21 21:58:52, Trever Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/380/ > ----------------------------------------------------------- > > (Updated 2009-03-21 21:58:52) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds a new page to the configuration that lets the applet speak > the time every nth minute of the hour. It defaults to never. The only major > problem I see right now is the awkward wording of the spinbox. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/libs/plasmaclock/CMakeLists.txt 942542 > trunk/KDE/kdebase/workspace/libs/plasmaclock/calendarConfig.ui 942542 > trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 942542 > trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 942542 > trunk/KDE/kdebase/workspace/libs/plasmaclock/generalConfig.ui PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.cpp 942542 > trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp 942542 > > Diff: http://reviewboard.kde.org/r/380/diff > > > Testing > ------- > > I've got it running in my everyday plasma session without problems. > > > Screenshots > ----------- > > General Page > http://reviewboard.kde.org/r/380/s/62/ > > > Thanks, > > Trever > > _______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
