Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-03-20 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-03-20 22:14:51.976726) Review request for Plasma. Changes ---

Re: another update on the systray and tiny api review

2009-03-20 Thread Aaron J. Seigo
On Friday 20 March 2009, Marco Martin wrote: > On Friday 20 March 2009, Aaron J. Seigo wrote: > > On Wednesday 18 March 2009, Marco Martin wrote: > > > -setMovie() we are on dbus now, sending the binary data is already > > > expensive enough > > > > well, for animations it probably makes sense to s

Re: another update on the systray and tiny api review

2009-03-20 Thread Marco Martin
On Friday 20 March 2009, Aaron J. Seigo wrote: > On Wednesday 18 March 2009, Marco Martin wrote: > > -setMovie() we are on dbus now, sending the binary data is already > > expensive enough > > well, for animations it probably makes sense to send all the frames across > at once and then animate them

Re: Review Request: better popupposition

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/374/#review543 --- Ship it! - Aaron On 2009-03-20 14:15:04, Marco Martin wrote: > > ---

Re: Review Request: Fix 'list-dictionaries' output of dictionary data engine

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/375/#review542 --- Ship it! - Aaron On 2009-03-20 14:32:12, Christian Loose wrote: > >

Re: another update on the systray and tiny api review

2009-03-20 Thread Aaron J. Seigo
On Wednesday 18 March 2009, Marco Martin wrote: > -setMovie() we are on dbus now, sending the binary data is already > expensive enough well, for animations it probably makes sense to send all the frames across at once and then animate them on the host side. sending images constantly over dbus m

Review Request: Fix 'list-dictionaries' output of dictionary data engine

2009-03-20 Thread Christian Loose
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/375/ --- Review request for Plasma. Summary --- This patch fixes the parsing of the "

Review Request: better popupposition

2009-03-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/374/ --- Review request for Plasma. Summary --- some special cases when the item is i

Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-03-20 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review541 --- I have some comments in addition to the coding style issues mentioned by

Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review540 --- logic looks alright, just a couple of code style issues to fix and then

Re: Review Request: Plasma::AbstractRunner::Syntax

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/372/ --- (Updated 2009-03-20 13:13:37.227582) Review request for Plasma. Summary (update

Review Request: kdebase runner syntax

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/373/ --- Review request for Plasma. Summary --- Patch provides syntax registration fo

Review Request: Plasma::AbstractRunner::Syntax

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/372/ --- Review request for Plasma. Summary --- Allows runners to register their synt

Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-03-20 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-03-20 10:21:32.420468) Review request for Plasma. Changes ---

Re: Review Request: Add keyboard navigation to plasma applet Folder View

2009-03-20 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review537 --- this is a very important feature to add, so thanks for working on it. th

Review Request: Add keyboard navigation to plasma applet Folder View

2009-03-20 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- Review request for Plasma. Summary --- This partly addresses the above bug,

Re: Review Request: New option for plasma Notes

2009-03-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/366/#review527 --- The patch looks good overall, but there are some issues with it that ne

Review Request: New option for plasma Notes

2009-03-20 Thread Zareth
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/366/ --- Review request for Plasma. Summary --- This patch add to the plasmoid notes

Re: How does the plasma change wallpaper?

2009-03-20 Thread Neil
Aaron J. Seigo 写道: > >> Or a interface accept a absolute path and wallpaper mode, then call this >> interface also can change change wallpaper immediately. >> > > see this link: > > > http://techbase.kde.org/index.php?title=Projects/Summer_of_Code/2009/Ideas#Project:_D- > Bus_Interface