----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/375/#review542 -----------------------------------------------------------
Ship it! - Aaron On 2009-03-20 14:32:12, Christian Loose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/375/ > ----------------------------------------------------------- > > (Updated 2009-03-20 14:32:12) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes the parsing of the "SHOW DB" output in the dictionary data > engine. > > Otherwise the "list-dictionaries" output included: > - Status codes 250 and 110 > - Empty lines > - Lines starting with a dot > > Also the key value of "list-dictionaries" was wrong. It always contained the > first word of the description. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/dataengines/dict/dictengine.cpp 941485 > > Diff: http://reviewboard.kde.org/r/375/diff > > > Testing > ------- > > Tested with svn trunk using plasmaengineexplorer. > > > Thanks, > > Christian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
