[patch] PlasmaApp::adjustSize with multiple monitors

2008-08-23 Thread Guillaume Pothier
Hi, This is related to http://bugs.kde.org/show_bug.cgi?id=163676 It seems there is indeed a problem with QDesktopWidget. When I resize my external monitor, the resize signal is fired with screen=0, although the screen whose size changed is screen 1. Thus adjustSize doesn't adjust the size of the p

Re: Review Request: Plasma themed monitor of background dialog

2008-08-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/140/ --- (Updated 2008-08-23 14:17:31.646022) Review request for Plasma. Summary -

Re: Review Request: Plasma themed monitor of background dialog

2008-08-23 Thread Marco Martin
> On 2008-08-23 13:36:32, Aaron Seigo wrote: > > i wonder if this couldn't be done with the actual monitor.svg scalable > > icon? might have even nicer results? > > > > if not, i like how this looks better than what we currently have. i'm a > > little concerned about adding an svg to the them

Re: Review Request: Plasma themed monitor of background dialog

2008-08-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/140/#review131 --- i wonder if this couldn't be done with the actual monitor.svg scal

Re: Review Request: contentsRect() for PanelSvg

2008-08-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/139/#review130 --- Ship it! small comment, but i like the idea. /trunk/KDE/kdebase

Re: Vertical text in taskbar

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Marco Martin wrote: > On Saturday 23 August 2008, Javier Goday wrote: > > Hi, i made a small patch to show vertical text in the taskbar when the > > panel is vertical. > > Hi, > posting the patch in http://reviewboard.vidsolbach.de it's easier to > comment on the single

Re: Vertical text in taskbar

2008-08-23 Thread Marco Martin
On Saturday 23 August 2008, Javier Goday wrote: > Hi, i made a small patch to show vertical text in the taskbar when the > panel is vertical. Hi, posting the patch in http://reviewboard.vidsolbach.de it's easier to comment on the single patch lines.. btw, i like the idea, but only when the size is

Review Request: Plasma themed monitor of background dialog

2008-08-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/140/ --- Review request for Plasma. Summary --- The monitor of the background d

Vertical text in taskbar

2008-08-23 Thread Javier Goday
Hi, i made a small patch to show vertical text in the taskbar when the panel is vertical. Don't know if it is the right way or if is the awaited behavior, but anyway here's the patch : http://pastebin.com/f49987b73 http://img156.imageshack.us/my.php?image=snapshot1jo1.png http://img292.imageshack

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 18:51:12 Aaron J. Seigo wrote: > so ... a new approach is called for as we're going to run into this same > issue (nested config groups) in a number of places. i think we should > probably just do something like this in swapContainment (completely > untested =): > > KConf

Review Request: contentsRect() for PanelSvg

2008-08-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/139/ --- Review request for Plasma. Summary --- a contentsRect() function to b

Re: Wallpaper plugins

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Petri Damstén wrote: > Containment calls restore for wallpaper like this d->wallpaper- > > >restore(KConfigGroup(&cfg, "Wallpaper"), mode); and wallpaper plugin tries > > to > > read it's config values from that but there is none (I think) since this is > the config grou

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 17:57:53 Aaron J. Seigo wrote: > On Saturday 23 August 2008, Petri Damstén wrote: > > If I have understood correctly restore calls setWallpaper which gives > > containments own config (not the old containments config used in restore) > > to wallpaper plugins. So should I

Re: Wallpaper plugins

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Petri Damstén wrote: > If I have understood correctly restore calls setWallpaper which gives > containments own config (not the old containments config used in restore) > to wallpaper plugins. So should I fix setWallpaper so it can take the > KConfigGroup from restore?

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 17:25:25 Aaron J. Seigo wrote: > what happens in the code is: > > * old containment save settings: old->save(containmentConfig); > * new containment reads those settings: c->restore(containmentConfig) If I have understood correctly restore calls setWallpaper which gives

Re: Wallpaper plugins

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Petri Damstén wrote: > On Saturday 23 August 2008 01:05:38 Aaron J. Seigo wrote: > > > 2. Was wallpaper config save remove intentional? > > > > yes; i moved it to Containment::save > > But, doesn't that just save the wallpaper config to old containment. This > code was t

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 01:05:38 Aaron J. Seigo wrote: > > 2. Was wallpaper config save remove intentional? > > yes; i moved it to Containment::save But, doesn't that just save the wallpaper config to old containment. This code was there to copy wallpaper config to new containment. Petri s

Re: KDE/kdebase/workspace/plasma/plasma

2008-08-23 Thread Richard Moore
On 8/23/08, Aaron J. Seigo <[EMAIL PROTECTED]> wrote: > SVN commit 851124 by aseigo: I wonder if it might be possible to make a reusable class for mouse over activation areas like this? Obviously the number of spots where it could be used is small, but it might be a nice-to-have. Rich. __