On Saturday 23 August 2008 17:57:53 Aaron J. Seigo wrote:
> On Saturday 23 August 2008, Petri Damstén wrote:
> > If I have understood correctly restore calls setWallpaper which gives
> > containments own config (not the old containments config used in restore)
> > to wallpaper plugins. So should I fix setWallpaper so it can take the
> > KConfigGroup from restore?
>
> it compares the plugin and mode against what is in the containment's own
> config, but that's ok in this case because:
>
> * in restore, the values are read from the old containment's config
>
> * these values are then passed to setWallpaper
>
> * setWallpaper compares those values to the current wallpaper plugin (if
> any), and changes the wallpaper plugin if the values aren't the same

Containment calls restore for wallpaper like this d->wallpaper-
>restore(KConfigGroup(&cfg, "Wallpaper"), mode); and wallpaper plugin tries to 
read it's config values from that but there is none (I think) since this is 
the config group from the new containment?

> * setWallpaper then saves the configuration to the current containment's
> config
>
> so from what i'm reading in the code, it should work ...

Petri

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to