alan0428a opened a new pull request, #175:
URL: https://github.com/apache/logging-log4j-tools/pull/175
[A clear and concise description of what the pull request is for along with
a reference to the associated issue IDs, if they exist.]
## Checklist
* `./mvnw verify` succeeds (i
github-actions[bot] merged PR #3523:
URL: https://github.com/apache/logging-log4j2/pull/3523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
Pluto-syd commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2725356812
> This PR need to be merged with `2.x` for the CI builds to work properly.
I looked at why CI didn't pass, and made some changes to the way the
log4j-spring-boot module rel
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1996372079
##
_vulnerabilities.adoc:
##
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai
Technologies, Guy Lederfein
|Summary |Thread Context Lookup is
github-actions[bot] merged PR #176:
URL: https://github.com/apache/logging-log4j-transform/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
jvz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1996228917
##
_vulnerabilities.adoc:
##
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai
Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulner
ppkarwasz commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995775232
##
src/site/antora/modules/ROOT/partials/manual/systemproperties/properties-context-selector.adoc:
##
@@ -55,4 +55,17 @@
link:../javadoc/log4j-core/org/apache
ppkarwasz commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995774531
##
src/site/antora/modules/ROOT/pages/manual/thread-context.adoc:
##
@@ -159,7 +159,20 @@ You can provide a custom `ContextDataProvider`
implementation as fol
ppkarwasz commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995774531
##
src/site/antora/modules/ROOT/pages/manual/thread-context.adoc:
##
@@ -159,7 +159,20 @@ You can provide a custom `ContextDataProvider`
implementation as fol
ppkarwasz commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995769252
##
src/site/antora/modules/ROOT/pages/manual/lookups.adoc:
##
@@ -966,7 +966,10 @@ include::partial$features/servlet-support.adoc[]
[#third-party]
== Third-p
ppkarwasz commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2724628326
This PR need to be merged with `2.x` for the CI builds to work properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ppkarwasz merged PR #343:
URL: https://github.com/apache/logging-parent/pull/343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
Niko-O commented on issue #3433:
URL:
https://github.com/apache/logging-log4j2/issues/3433#issuecomment-2724504351
> 1. Why isn't your first thought to recommend changing this to
Short answer: Because it's not the same thing.
Longer answer: I have a few situations where I need to l
vy commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995444600
##
src/site/antora/modules/ROOT/partials/manual/systemproperties/properties-context-selector.adoc:
##
@@ -55,4 +55,17 @@
link:../javadoc/log4j-core/org/apache/loggin
vy commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995441923
##
src/site/antora/modules/ROOT/pages/manual/thread-context.adoc:
##
@@ -159,7 +159,20 @@ You can provide a custom `ContextDataProvider`
implementation as follows:
vy commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995439597
##
src/site/antora/modules/ROOT/pages/manual/lookups.adoc:
##
@@ -966,7 +966,10 @@ include::partial$features/servlet-support.adoc[]
[#third-party]
== Third-party lo
vy commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995439597
##
src/site/antora/modules/ROOT/pages/manual/lookups.adoc:
##
@@ -966,7 +966,10 @@ include::partial$features/servlet-support.adoc[]
[#third-party]
== Third-party lo
vy commented on code in PR #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534#discussion_r1995437055
##
src/site/antora/modules/ROOT/pages/manual/lookups.adoc:
##
@@ -999,6 +1002,29 @@ The Spring Boot 3 Lookup conflicts with the
<<#SpringBootLookup>>.
If you are up
vy commented on issue #3423:
URL:
https://github.com/apache/logging-log4j2/issues/3423#issuecomment-2723880090
@jbb01 What if we exclude those particular classes in the `excludePattern`:
```
^java\.(?!lang\.Class|net\.InetAddress|net\.URL|util\.regex\.Pattern).+
```
(Abov
ppkarwasz opened a new pull request, #3534:
URL: https://github.com/apache/logging-log4j2/pull/3534
This change adds references to the Log4j plugins from my personal
["Extensions for Log4j and Tomcat"](https://oss.copernik.eu/tomcat/3.x/)
project to the Log4j documentation.
To preven
ppkarwasz commented on PR #3482:
URL: https://github.com/apache/logging-log4j2/pull/3482#issuecomment-2724249175
> Once you have done a release, let us know, so we can advertise it on our
website.
See #3534 for an example PR on how to add a reference to your appender to
our documenta
github-actions[bot] commented on PR #3532:
URL: https://github.com/apache/logging-log4j2/pull/3532#issuecomment-2724203596
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995110621
##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
Review Comment:
@rgoers @ppkarwasz These changes look legit to me, but would you
FreeAndNil commented on issue #233:
URL:
https://github.com/apache/logging-log4net/issues/233#issuecomment-2724142831
@vpenades, @gkna I'm sorry, but I think we need to wait for
https://github.com/dotnet/csharplang/issues/4984
This will deliver an AOT-compatible equivalent (CallerIdentit
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995155623
##
log4j-core-test/src/test/resources/log4j-test3.xml:
##
@@ -15,7 +15,7 @@
~ See the License for the specific language governing permissions and
~ limitations
ppkarwasz commented on code in PR #3532:
URL: https://github.com/apache/logging-log4j2/pull/3532#discussion_r1995167509
##
log4j-core/src/main/java/org/apache/logging/log4j/core/util/UuidUtil.java:
##
@@ -140,4 +142,47 @@ public static UUID getTimeBasedUuid() {
final lo
github-actions[bot] merged PR #3521:
URL: https://github.com/apache/logging-log4j2/pull/3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995159610
##
log4j-core-test/src/test/resources/log4j-test3.xml:
##
@@ -15,7 +15,7 @@
~ See the License for the specific language governing permissions and
~ limitations
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995158481
##
log4j-core-test/src/test/resources/log4j-test3.xml:
##
@@ -15,7 +15,7 @@
~ See the License for the specific language governing permissions and
~ limitations
vy commented on code in PR #3450:
URL: https://github.com/apache/logging-log4j2/pull/3450#discussion_r1995126019
##
src/changelog/.2.x.x/3437_transtive_compile_only_dependencies.xml:
##
@@ -0,0 +1,11 @@
+
+http://www.w3.org/2001/XMLSchema-instance";
+ xmlns="https://loggin
vy commented on code in PR #344:
URL: https://github.com/apache/logging-parent/pull/344#discussion_r1986926284
##
.github/workflows/deploy-release-reusable.yaml:
##
@@ -55,6 +55,8 @@ on:
jobs:
deploy:
runs-on: ubuntu-latest
+env:
+ PROJECT_ID: ${{ inputs.projec
vy closed issue #3442: make SocketAppender support server list
URL: https://github.com/apache/logging-log4j2/issues/3442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
vy commented on issue #3442:
URL:
https://github.com/apache/logging-log4j2/issues/3442#issuecomment-2724028069
Since multiple solutions (i.e., using a `Routing` appender or creating a
custom one) are provided to the user, closing this one as `Not Planned`.
--
This is an automated message
vy commented on PR #3523:
URL: https://github.com/apache/logging-log4j2/pull/3523#issuecomment-2724013171
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ppkarwasz commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995118826
##
log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java:
##
@@ -17,16 +17,24 @@
package org.apache.logging.log4j.core;
imp
vy commented on code in PR #279:
URL:
https://github.com/apache/logging-log4j-samples/pull/279#discussion_r1995119155
##
log4j-samples-gradle-metadata/gradlew:
##
@@ -0,0 +1,251 @@
+#!/bin/sh
Review Comment:
> What I would propose is to remove it completely (scrips and Jars
rgoers commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995121389
##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
Review Comment:
Seems correct to me as well.
--
This is an automated mes
vy commented on issue #3433:
URL:
https://github.com/apache/logging-log4j2/issues/3433#issuecomment-2723889226
@rgoers @ppkarwasz WDYT about this proposal? Instead of adding one more
method to the `Logger`, can't we achieve this by branching on `message
instanceof Throwable` in `MessageFac
rgoers commented on issue #3433:
URL:
https://github.com/apache/logging-log4j2/issues/3433#issuecomment-2723912447
First, I have to ask some obvious questions.
1. Why isn't your first thought to recommend changing this to
```
logger.error("Doing this thing failed. Context Id: {}
rgoers commented on PR #6:
URL: https://github.com/apache/logging-site/pull/6#issuecomment-2723881567
First, I think you should link to
https://musigma.blog/2023/11/10/log4shell-history.html. While Matt's page says
Log4Shell was fixed in 2.16.0 my recollection was that 2.17.0 was the only
vy commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1995006760
##
_vulnerabilities.adoc:
##
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai
Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnera
41 matches
Mail list logo
