ppkarwasz commented on code in PR #3508: URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995118826
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java: ########## @@ -17,16 +17,24 @@ package org.apache.logging.log4j.core; import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNull; +import java.lang.reflect.Field; import org.apache.logging.log4j.core.config.Configuration; import org.apache.logging.log4j.core.test.junit.LoggerContextSource; +import org.apache.logging.log4j.core.util.ReflectionUtil; +import org.apache.logging.log4j.test.junit.SetTestProperty; import org.junit.jupiter.api.Test; +@SetTestProperty(key = "log4j2.is.webapp", value = "false") Review Comment: ```suggestion @SetTestProperty(key = "log4j2.isWebapp", value = "false") ``` _Nit_: both work, but [`log4j2.isWebapp`](https://logging.apache.org/log4j/2.x/manual/systemproperties.html#log4j2.isWebapp) is the one we document on our website. ########## log4j-core-test/src/test/resources/log4j-test3.xml: ########## @@ -15,7 +15,7 @@ ~ See the License for the specific language governing permissions and ~ limitations under the License. --> -<Configuration status="OFF" name="XMLConfigTest" monitorInterval="5" shutdownHook="disable"> +<Configuration status="DEBUG" name="XMLConfigTest" monitorInterval="5" shutdownHook="disable"> Review Comment: I would prefer to revert this or remove `status` altogether, so we don't pollute the build logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
