vy commented on code in PR #344:
URL: https://github.com/apache/logging-parent/pull/344#discussion_r1986926284
##########
.github/workflows/deploy-release-reusable.yaml:
##########
@@ -55,6 +55,8 @@ on:
jobs:
deploy:
runs-on: ubuntu-latest
+ env:
+ PROJECT_ID: ${{ inputs.project-id }}
Review Comment:
I find the old style more secure: a global `input` injected wherever it is
needed, instead of being exposed using a global environment variable to every
script. My 2 cents...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
