Re: [PR] Migrate `log4j-osgi-test` to JUnit 5 (logging-log4j2)

2024-11-19 Thread via GitHub
ppkarwasz commented on PR #3219: URL: https://github.com/apache/logging-log4j2/pull/3219#issuecomment-2487809795 @vy, should we move `log4j-osgi-test` to the Samples repository (which is our integration test repo). -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Migrate `log4j-osgi-test` to JUnit 5 (logging-log4j2)

2024-11-19 Thread via GitHub
ppkarwasz commented on PR #3219: URL: https://github.com/apache/logging-log4j2/pull/3219#issuecomment-2487803625 > Before attempting an upgrade, we were wondering, does this feature need to be updated? We are missing some context, what is being checked by using this runner? Any help in this

Re: [PR] Bump commons-io:commons-io from 2.17.0 to 2.18.0 [logging-log4j-tools]

2024-11-19 Thread via GitHub
github-actions[bot] merged PR #157: URL: https://github.com/apache/logging-log4j-tools/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Migrate `log4j-osgi-test` to JUnit 5 (logging-log4j2)

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #3219: URL: https://github.com/apache/logging-log4j2/pull/3219#issuecomment-2487623650 Job Requested goals Build Tool Version Build Outcome Build ScanĀ® build-

Re: [PR] Remove unused code from cmake scripts [logging-log4cxx]

2024-11-19 Thread via GitHub
swebb2066 merged PR #430: URL: https://github.com/apache/logging-log4cxx/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[PR] Migrate tests to JUnit5 (logging-log4j2)

2024-11-19 Thread via GitHub
strangelookingnerd opened a new pull request, #3221: URL: https://github.com/apache/logging-log4j2/pull/3221 There are already some tests that already use JUnit5 as well as some pending PRs (#3219, #3218, ...) to migrate more. This PR will migrate all (*) tests to JUnit5. Migration i

Re: [PR] Log4j api test refactor junit5 (logging-log4j2)

2024-11-19 Thread via GitHub
Realtin commented on PR #3218: URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-2485579789 Hi @vy I ran into a problem after refactoring the SecurityManagerRule to an Extension. It seems to end up in a loop at: `LoaderUtilSecurityManagerTest$TestSecurityManager.checkPerm

Re: [PR] Log4j api test refactor junit5 (logging-log4j2)

2024-11-19 Thread via GitHub
ppkarwasz commented on PR #3218: URL: https://github.com/apache/logging-log4j2/pull/3218#issuecomment-2485981098 @Realtin, I'll look into it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Migrate `log4j-osgi-test` to JUnit 5 (logging-log4j2)

2024-11-19 Thread via GitHub
AlbaHerrerias commented on PR #3219: URL: https://github.com/apache/logging-log4j2/pull/3219#issuecomment-2485890818 We have some questions we would like to ask. We've found that the test suites `CoreOsgiTest`, `JULProviderTest` and `SLF4JProviderTest` are using `PaxExam`, and the current v

[PR] Migrate `log4j-osgi-test` to JUnit 5 (logging-log4j2)

2024-11-19 Thread via GitHub
AlbaHerrerias opened a new pull request, #3219: URL: https://github.com/apache/logging-log4j2/pull/3219 [A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.] ## Checklist * Base your changes on `2.x`

Re: [I] log4j-api 2.24.1 causes getLogger() to return null when using log4j-core 2.24.0 (logging-log4j2)

2024-11-19 Thread via GitHub
centic9 commented on issue #3196: URL: https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2485812247 I used poi-reproduce to test combinations of 2.23.1, 2.24.0, 2.24.1 and upcoming 2.24.2. Summary: **2.24.2 seems to solve this issue**. Combining 2.23.x and 2.24.2 wil

[PR] Log4j api test refactor junit5 (logging-log4j2)

2024-11-19 Thread via GitHub
Realtin opened a new pull request, #3218: URL: https://github.com/apache/logging-log4j2/pull/3218 We are from Neighbourhoodie, the implementation partner of the [STF](https://www.sovereigntechfund.de/programs/bug-resilience) Bug Resilience Program. This work is part of our agreed Milestone

Re: [PR] Bump com.google.errorprone:error_prone_core from 2.35.1 to 2.36.0 [logging-parent]

2024-11-19 Thread via GitHub
github-actions[bot] merged PR #287: URL: https://github.com/apache/logging-parent/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [PR] Fix(#2769): Modify the annotation processor in 2.x to give a warning if a plugin builder attribute does not have a public setter. (logging-log4j2)

2024-11-19 Thread via GitHub
jaykataria commented on PR #3195: URL: https://github.com/apache/logging-log4j2/pull/3195#issuecomment-2485009007 Hi @ppkarwasz , let me know if I need to rebase/revise the PR, since I know you merged one commit, which was the setters -- This is an automated message from the Apache Gi

Re: [I] Add `PreciseClock` implementation for JRE 8 systems (logging-log4j2)

2024-11-19 Thread via GitHub
jaykataria commented on issue #3198: URL: https://github.com/apache/logging-log4j2/issues/3198#issuecomment-2485003314 Hi @ppkarwasz , opened a PR, for the purpose :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] Feat(SystemClock): Added PreciseClock implementation to the system clock class, for the benefit of Java 8 users. (logging-log4j2)

2024-11-19 Thread via GitHub
jaykataria opened a new pull request, #3217: URL: https://github.com/apache/logging-log4j2/pull/3217 Straight forward change to override the behavior of System Clock, to implement the Precise Clock interface, for the benefit of Java 8 users. [A clear and concise description of wha