strangelookingnerd opened a new pull request, #3221: URL: https://github.com/apache/logging-log4j2/pull/3221
There are already some tests that already use JUnit5 as well as some pending PRs (#3219, #3218, ...) to migrate more. This PR will migrate all (*) tests to JUnit5. Migration includes: * Using JUnit5 annotations * Using `Assertions` * Remove `public` modifiers from test classes and methods * Clean up assertions (switching `expected` and `actual`, simplyifing assertions...) * Trivial code cleanup I validated my changes using `./mvnw verify` and (*) Some tests use `org.junit.Rule` implementations that do not have a JUnit5 replacement and implementing these is non-trivial from what I can tell. Further there are some instances of other testing frameworks that do not yet support JUnit5. I plan on looking into these cases as well but deliberately did not include them in this PR. ## Checklist * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise * `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `./mvnw spotless:apply` and retry) * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` directory * Tests for the changes are provided * [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
