eric-milles commented on code in PR #2018:
URL: https://github.com/apache/groovy/pull/2018#discussion_r1434337876
##
src/main/java/org/codehaus/groovy/reflection/CachedClass.java:
##
@@ -282,14 +274,36 @@ public CachedMethod searchMethods(String name,
CachedClass[] parameterTyp
eric-milles commented on code in PR #2018:
URL: https://github.com/apache/groovy/pull/2018#discussion_r1434339158
##
src/main/java/org/codehaus/groovy/reflection/CachedClass.java:
##
@@ -339,7 +353,7 @@ public String getTypeDescription() {
return BytecodeHelper.getTypeD
blackdrag commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1866780233
> Can you just quickly explain the different return values between
`VMPlugin.getJavaVersion()` and `Runtime.version().feature()`?
`Runtime.version().feature()` is available since J
blackdrag commented on code in PR #2018:
URL: https://github.com/apache/groovy/pull/2018#discussion_r1434399183
##
src/main/java/org/codehaus/groovy/reflection/CachedClass.java:
##
@@ -339,7 +353,7 @@ public String getTypeDescription() {
return BytecodeHelper.getTypeDes
blackdrag commented on code in PR #2018:
URL: https://github.com/apache/groovy/pull/2018#discussion_r1434409694
##
src/main/java/org/codehaus/groovy/reflection/CachedClass.java:
##
@@ -282,14 +274,36 @@ public CachedMethod searchMethods(String name,
CachedClass[] parameterTypes
paulk-asert merged PR #2017:
URL: https://github.com/apache/groovy/pull/2017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
orubel commented on PR #2017:
URL: https://github.com/apache/groovy/pull/2017#issuecomment-1866921653
THANK YOU!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
blackdrag opened a new pull request, #2020:
URL: https://github.com/apache/groovy/pull/2020
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
daniellansun commented on PR #2020:
URL: https://github.com/apache/groovy/pull/2020#issuecomment-1867319164
LGTM 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
paulk-asert commented on code in PR #2018:
URL: https://github.com/apache/groovy/pull/2018#discussion_r1434931626
##
src/main/java/org/codehaus/groovy/reflection/CachedClass.java:
##
@@ -282,14 +274,36 @@ public CachedMethod searchMethods(String name,
CachedClass[] parameterTyp
paulk-asert commented on code in PR #2018:
URL: https://github.com/apache/groovy/pull/2018#discussion_r1434938651
##
src/main/java/org/codehaus/groovy/reflection/CachedClass.java:
##
@@ -339,7 +353,7 @@ public String getTypeDescription() {
return BytecodeHelper.getTypeD
paulk-asert commented on PR #2018:
URL: https://github.com/apache/groovy/pull/2018#issuecomment-1867578311
Merged - Thanks! I took everything except the import re-ordering for
CachedSAMClass. We have until now always just used the default ordering which
Intellij uses (original Sun coding st
paulk-asert closed pull request #2018: Partial cleanup of ReflectionCache
URL: https://github.com/apache/groovy/pull/2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
paulk-asert commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1868173648
@blackdrag Did you want to update the PR with the error case when class
loader resolving is turned off?
--
This is an automated message from the Apache Git Service.
To respond to the
blackdrag commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1868271383
> @blackdrag Did you want to update the PR with the error case when class
loader resolving is turned off? If so, then +1 from me.
Yes, I will update it, but it may take a week
--
dependabot[bot] opened a new pull request, #2021:
URL: https://github.com/apache/groovy/pull/2021
Bumps
[org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin)
from 5.1.12 to 5.1.13.
Commits
https://github.com/jfrog/artifactory-gra
daniellansun merged PR #2021:
URL: https://github.com/apache/groovy/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert commented on PR #2022:
URL: https://github.com/apache/groovy/pull/2022#issuecomment-1872397053
It currently doesn't check whether the placeholder names and
varargPlaceholder names are distinct. It may not matter but code with such name
clashes might become harder to understand,
blackdrag commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1438940188
##
src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
daniellansun commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1438949628
##
src/main/java/org/codehaus/groovy/classgen/DeadCodeAnalyzer.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
daniellansun commented on PR #2024:
URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873127529
Let's check if the latest jarjar still leaves empty META-INF/services files.
https://github.com/apache/groovy/blob/80e92ec31a6afe2d8b1260a1452b698fbec9c963/versions.properties#L
daniellansun commented on PR #2024:
URL: https://github.com/apache/groovy/pull/2024#issuecomment-1873133471
`com.eed3si9n.jarjar.JarJarTask` is missing in jarjar 1.13.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
daniellansun closed pull request #2024: GROOVY-11264: Bump jarjar to 1.13.1
URL: https://github.com/apache/groovy/pull/2024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
eric-milles commented on PR #2023:
URL: https://github.com/apache/groovy/pull/2023#issuecomment-1873409213
Besides the extra class bytecode, is there a strong reason for this? The
issue ticket pops up out of the blue without much explanation.
There are so many possible paths that I t
eric-milles commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1439064503
##
src/main/java/org/codehaus/groovy/classgen/Verifier.java:
##
@@ -302,6 +310,12 @@ private void checkFinalVariables(final ClassNode node) {
visitor.visitC
paulk-asert merged PR #2022:
URL: https://github.com/apache/groovy/pull/2022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #2023:
URL: https://github.com/apache/groovy/pull/2023#issuecomment-1873540757
@eric-milles
As we all know, source code is meant for developers to read, and the less
redundant code there is, the more developer-friendly it becomes.
Admittedly, it's cha
blackdrag commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1875685712
> > @blackdrag Did you want to update the PR with the error case when class
loader resolving is turned off? If so, then +1 from me.
>
> Yes, I will update it, but it may take a wee
eric-milles commented on PR #2023:
URL: https://github.com/apache/groovy/pull/2023#issuecomment-1875712756
> source code is meant for developers to read, and the less redundant code
there is, the more developer-friendly it becomes.
So now you have a benefit statement that you can put
eric-milles commented on PR #2020:
URL: https://github.com/apache/groovy/pull/2020#issuecomment-1875754759
The changes in `MetaClassImpl` look fine. `MetaMethodIndex` does not even
load it is so different.
Why are the methods deprecated in `MetaMethod` and `ParameterTypes`? Are
the
eric-milles commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1875761956
The changes all look fine except the `IllegalArgumentException` bit. Can
you change the name of the parameter to indicate fail on asm parsing or
whatever you'd call the purpose of the
daniellansun commented on PR #2023:
URL: https://github.com/apache/groovy/pull/2023#issuecomment-1875821378
We can add a option to prevent or warn dead code or disable check totally.
Here is the table to show how mainstream programming language to handle dead
code. Most of them preven
eric-milles commented on PR #1913:
URL: https://github.com/apache/groovy/pull/1913#issuecomment-1876006042
The `SecureASTCustomizer` is run as part of the _canonicalization_
compilation phase (5). Static type checking is run as part of the _instruction
selection_ phase (6).
But to y
blackdrag commented on PR #2020:
URL: https://github.com/apache/groovy/pull/2020#issuecomment-1876951120
> Why are the methods deprecated in `MetaMethod` and `ParameterTypes`? Are
they not useful for other purposes?
There are two cases, both of them are unused.
First there is the
blackdrag commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1876956061
> The changes all look fine except the `IllegalArgumentException` bit. Can
you change the name of the parameter to indicate fail on asm parsing or
whatever you'd call the purpose of the
dependabot[bot] opened a new pull request, #2026:
URL: https://github.com/apache/groovy/pull/2026
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 6.0.4 to 6.0.5.
Release notes
Sourced from https://github.com/spotbugs
Goooler merged PR #2026:
URL: https://github.com/apache/groovy/pull/2026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
daniellansun commented on PR #2027:
URL: https://github.com/apache/groovy/pull/2027#issuecomment-1878909215
Could you add some related tests for the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
moste00 commented on PR #2027:
URL: https://github.com/apache/groovy/pull/2027#issuecomment-1878916072
> Could you add some related tests for the PR?
Sorry but under which directory ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
daniellansun commented on PR #2027:
URL: https://github.com/apache/groovy/pull/2027#issuecomment-1878927469
You could put tests under the following package:
https://github.com/apache/groovy/tree/822b8b413ba1014ec432a3ba0e6a3584fd1b8afb/subprojects/groovy-groovydoc/src/test/groovy/org/
paulk-asert merged PR #2025:
URL: https://github.com/apache/groovy/pull/2025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2028:
URL: https://github.com/apache/groovy/pull/2028
Bumps org.asciidoctor:asciidoctor-gradle-jvm-pdf from 3.3.2 to 4.0.0.
[ {
handleOptimizationOption(GR
eric-milles commented on code in PR #2023:
URL: https://github.com/apache/groovy/pull/2023#discussion_r1445353482
##
src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java:
##
@@ -469,6 +472,8 @@ public CompilerConfiguration() {
handleOptimizationOption(GR
eric-milles commented on PR #2023:
URL: https://github.com/apache/groovy/pull/2023#issuecomment-1881861904
> dead code analysis, as its name shown, it just traverses AST and does not
change the AST, so no tranforming [sic] changes involved.
This was understood. The point is that if y
dependabot[bot] opened a new pull request, #2031:
URL: https://github.com/apache/groovy/pull/2031
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 6.0.5 to 6.0.6.
Release notes
Sourced from https://github.com/spotbugs
Goooler merged PR #2031:
URL: https://github.com/apache/groovy/pull/2031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
daniellansun merged PR #2019:
URL: https://github.com/apache/groovy/pull/2019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1883409009
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] opened a new pull request, #2033:
URL: https://github.com/apache/groovy/pull/2033
Bumps org.asciidoctor:asciidoctor-gradle-jvm-pdf from 4.0.0 to 4.0.1.
[
Re
daniellansun merged PR #2034:
URL: https://github.com/apache/groovy/pull/2034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #2030:
URL: https://github.com/apache/groovy/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #2032:
URL: https://github.com/apache/groovy/pull/2032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #2035:
URL: https://github.com/apache/groovy/pull/2035
Bumps
[org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/artifactory-gradle-plugin)
from 5.1.13 to 5.1.14.
Release notes
Sourced from https://github.com/jfrog/
codecov-commenter commented on PR #2035:
URL: https://github.com/apache/groovy/pull/2035#issuecomment-1888249457
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2035?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
paulk-asert merged PR #2035:
URL: https://github.com/apache/groovy/pull/2035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2027:
URL: https://github.com/apache/groovy/pull/2027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #2027:
URL: https://github.com/apache/groovy/pull/2027#issuecomment-1890429640
Merged, thanks! I have just been working on another Groovydoc change, so it
won't be too hard for me to add a test.
--
This is an automated message from the Apache Git Service.
To re
eric-milles closed pull request #502: GROOVY-8096 setScriptBaseClass with Java
class breaks @Field Binding init due to call to super() instead of
super(Binding)
URL: https://github.com/apache/groovy/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the messa
moste00 commented on PR #2027:
URL: https://github.com/apache/groovy/pull/2027#issuecomment-1892793869
> Merged, thanks! I have just been working on another Groovydoc change, so
it won't be too hard for me to add a test.
Hello again, thanks very much!
Very sorry for not adding
PaintNinja opened a new pull request, #2036:
URL: https://github.com/apache/groovy/pull/2036
This PR changes the map used in the generated no-arg constructor to use the
`Collections.EMPTY_MAP` instance rather than creating a new `LinkedHashMap`
each call.
```diff
@Generated
pri
PaintNinja closed pull request #2036: Use `Collections.EMPTY_MAP` in generated
no-arg constructor from `@TupleConstructor`
URL: https://github.com/apache/groovy/pull/2036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
codecov-commenter commented on PR #2037:
URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902171856
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
eric-milles commented on PR #2037:
URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902721131
Could you add the Java 19+ build stuff separately?
Is it possible to incorporate the non-sealed checking into `isSealed()` and
then you would be checking `!isSealed()` instead of
daniellansun commented on PR #2037:
URL: https://github.com/apache/groovy/pull/2037#issuecomment-1902735259
> Could you add the Java 19+ build stuff separately?
Sure. I just want to see if the fix works for Java 19+.
> Is it possible to incorporate the non-sealed checking into isSea
dependabot[bot] opened a new pull request, #2038:
URL: https://github.com/apache/groovy/pull/2038
Bumps com.github.ben-manes.versions from 0.50.0 to 0.51.0.
[
Re
Goooler merged PR #2038:
URL: https://github.com/apache/groovy/pull/2038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
Goooler commented on PR #2039:
URL: https://github.com/apache/groovy/pull/2039#issuecomment-1905266340
JDK 23 EA fails, any idea?
https://github.com/Goooler/groovy/actions/runs/7620906327/job/20756416157
--
This is an automated message from the Apache Git Service.
To respond to the
daniellansun commented on PR #2039:
URL: https://github.com/apache/groovy/pull/2039#issuecomment-1905268034
> JDK 23 EA fails, any idea?
>
> https://github.com/Goooler/groovy/actions/runs/7620906327/job/20756416157
Don't add JDK 23 build for now.
--
This is an automated mess
Goooler commented on PR #2039:
URL: https://github.com/apache/groovy/pull/2039#issuecomment-1905312409
All checks passed in my fork
https://github.com/Goooler/groovy/commit/7c3074a0c7c036a3b8cbad0188ac38de3cc6f6e7.
--
This is an automated message from the Apache Git Service.
To respond to
Goooler commented on code in PR #2039:
URL: https://github.com/apache/groovy/pull/2039#discussion_r1462923239
##
src/test/org/codehaus/groovy/util/ReferenceManagerTest.groovy:
##
@@ -144,7 +144,7 @@ class ReferenceManagerTest extends GroovyTestCase {
}
}
-pri
daniellansun commented on code in PR #2039:
URL: https://github.com/apache/groovy/pull/2039#discussion_r1463399735
##
src/test/org/codehaus/groovy/util/ReferenceManagerTest.groovy:
##
@@ -144,7 +144,7 @@ class ReferenceManagerTest extends GroovyTestCase {
}
}
-
dependabot[bot] opened a new pull request, #2040:
URL: https://github.com/apache/groovy/pull/2040
Bumps
[com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin)
from 6.0.6 to 6.0.7.
Release notes
Sourced from https://github.com/spotbugs
codecov-commenter commented on PR #2040:
URL: https://github.com/apache/groovy/pull/2040#issuecomment-1907210371
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2040?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
Goooler merged PR #2040:
URL: https://github.com/apache/groovy/pull/2040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
paulk-asert merged PR #2041:
URL: https://github.com/apache/groovy/pull/2041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2037:
URL: https://github.com/apache/groovy/pull/2037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
Goooler commented on PR #2039:
URL: https://github.com/apache/groovy/pull/2039#issuecomment-1909400568
I'll squash these commits when we are ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov-commenter commented on PR #2039:
URL: https://github.com/apache/groovy/pull/2039#issuecomment-1909415272
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2039?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
Goooler commented on PR #2039:
URL: https://github.com/apache/groovy/pull/2039#issuecomment-1909424942
I just merged test jobs into one file in
7f53ec4f4623188b3d5f49a782e0e8df8aabef18, is this makes sense to you?
--
This is an automated message from the Apache Git Service.
To respond to
codecov-commenter commented on PR #2042:
URL: https://github.com/apache/groovy/pull/2042#issuecomment-1909479909
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2042?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Re
daniellansun commented on PR #2042:
URL: https://github.com/apache/groovy/pull/2042#issuecomment-1909781248
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Goooler merged PR #2039:
URL: https://github.com/apache/groovy/pull/2039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groov
paulk-asert merged PR #2042:
URL: https://github.com/apache/groovy/pull/2042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467357057
##
build-logic/src/main/groovy/org.apache.groovy-asciidoctor.gradle:
##
@@ -53,14 +53,14 @@ asciidoctor {
sources {
include '*.adoc'
}
-output
Goooler commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467358053
##
build-logic/src/main/groovy/org.apache.groovy-asciidoctor.gradle:
##
@@ -53,14 +53,14 @@ asciidoctor {
sources {
include '*.adoc'
}
-outputDir
Goooler commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467364144
##
build-logic/src/main/groovy/org.apache.groovy-asciidoctor.gradle:
##
@@ -126,7 +126,7 @@ asciidoctor.onlyIf { project.file('src/spec/doc').exists() }
def asciidoct
paulk-asert commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467375986
##
build-logic/src/main/groovy/org.apache.groovy-distribution.gradle:
##
@@ -181,7 +181,7 @@ tasks.register('dist') {
tasks.register("installGroovy", Sync) {
paulk-asert commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467377244
##
build-logic/src/main/groovy/org.apache.groovy-performance.gradle:
##
@@ -70,7 +70,7 @@ tasks.named('compileJmhGroovy') {
tasks.register('displayJmhResults') {
Goooler commented on code in PR #2043:
URL: https://github.com/apache/groovy/pull/2043#discussion_r1467378730
##
build-logic/src/main/groovy/org.apache.groovy-performance.gradle:
##
@@ -70,7 +70,7 @@ tasks.named('compileJmhGroovy') {
tasks.register('displayJmhResults') {
101 - 200 of 1478 matches
Mail list logo
