eric-milles commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-1875761956
The changes all look fine except the `IllegalArgumentException` bit. Can you change the name of the parameter to indicate fail on asm parsing or whatever you'd call the purpose of the `try` block? Are you saying that if ASM and our ASM-plugins can't work out what the class file says, it throws `IllegalArgumentException`? Is there a test or two that cause this to happen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
