blackdrag commented on PR #2019:
URL: https://github.com/apache/groovy/pull/2019#issuecomment-1866780233

   > Can you just quickly explain the different return values between 
`VMPlugin.getJavaVersion()` and `Runtime.version().feature()`?
   
   `Runtime.version().feature()` is available since Java10 and returns the 
major version of the used JVM. For Oracle 17.36 it would thus return 17. I have 
no idea why they called that feature.
   
   > Do we want to make capture of non-`IOException` dependent on 
"classLoaderResolving" optimization option in `CompilerConfiguration`? See 
`ClassNodeResolver#tryAsLoaderClassOrScript`.
   
   You mean if class loader resolving is turned off? Well... in that case 
Groovy won't be able to load the class. My current version would mean Groovy 
will in that case fail to resolve the class and eventually fail resolving 
completely. I guess you are right. It would e better to give a proper error 
message instead for this case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to