On 1/13/2021 11:39 PM, Jiri Pirko wrote:
> Thu, Jan 14, 2021 at 03:07:18AM CET, and...@lunn.ch wrote:
>>
>> I assume if i prevision for card4ports but actually install a
>> card2ports, all the interfaces stay down?
>
> Yes, the card won't get activated in case or provision mismatch.
>
If you'
On 1/13/2021 6:27 PM, Jakub Kicinski wrote:
> On Wed, 13 Jan 2021 13:12:12 +0100 Jiri Pirko wrote:
>> This patchset introduces support for modular switch systems.
>> NVIDIA Mellanox SN4800 is an example of such. It contains 8 slots
>> to accomodate line cards. Available line cards include:
>> 16
On 1/21/2021 7:31 PM, Parav Pandit wrote:
>
>
>> From: Samudrala, Sridhar
>> Sent: Friday, January 22, 2021 2:21 AM
>>
>>> $ devlink port show
>>> pci/:06:00.0/65535: type eth netdev ens2f0np0 flavour physical
>>> port 0 splittable false
>>>
>>> $ devlink port add pci/:06:00.0 flavour
; 6 files changed, 6 insertions(+), 7 deletions(-)
>
Nice to see these cleanups. I noticed a few of these recently while
working on devlink.
Reviewed-by: Jacob Keller
On 11/30/2020 8:41 AM, Parav Pandit wrote:
> Added documentation for devlink port and port function related commands.
>
> Signed-off-by: Parav Pandit
> Reviewed-by: Jiri Pirko
Good to see this! I saw a couple of minor nits.
- Jake
> ---
> .../networking/devlink/devlink-port.rst | 10
gt; @@ -4068,6 +4064,7 @@ int i40e_ndo_set_vf_mac(struct net_device *netdev, int
> vf_id, u8 *mac)
> ret = -EAGAIN;
> goto error_param;
> }
> + vsi = pf->vsi[vf->lan_vsi_idx];
>
Yea, this makes more sense to me.
Reviewed-by: Jacob Keller
> if (is_multicast_ether_addr(mac)) {
> dev_err(&pf->pdev->dev,
>
On 11/13/2020 3:48 PM, Shannon Nelson wrote:
> On 11/13/20 2:45 PM, Jacob Keller wrote:
>> -int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name,
>> +int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw,
>>s
2af-721e-3a54-ef99a666b...@intel.com/
[4]
https://lore.kernel.org/netdev/20201117200820.854115-1-jacob.e.kel...@intel.com/
Jacob Keller (2):
devlink: move request_firmware out of driver
devlink: move flash end and begin to core devlink
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 +--
...
ow no longer possible
to do the wrong thing in this regard. We also save a couple of lines of
code in each driver.
Signed-off-by: Jacob Keller
Acked-by: Vasundhara Volam
Reviewed-by: Jiri Pirko
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
Ch
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Acked-by: Shannon Nelson
Acked-by: Vasundhara Volam
Reviewed-by: Jiri Pirko
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
On 11/18/2020 8:22 AM, Christian Eggers wrote:
> Remove driver internal defines for this.
>
> Signed-off-by: Christian Eggers
> Cc: Richard Cochran
> Cc: Kurt Kanzenbach
> ---
> drivers/ptp/ptp_ines.c | 19 +++
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --g
hink at least one driver has abused the PPS in the past as a
way to request that we enable the PPS hardware, resulting in effectively
using it as a limited form of the EXTTS interface. Hopefully this helps
reduce the confusion here!
Reviewed-by: Jacob Keller
>
> Signed-off-by: Ahmad Fato
On 11/18/2020 11:22 AM, Parav Pandit wrote:
>
>
>> From: David Ahern
>> Sent: Wednesday, November 18, 2020 11:33 PM
>>
>>
>> With Connectx-4 Lx for example the netdev can have at most 63 queues
>> leaving 96 cpu servers a bit short - as an example of the limited number of
>> queues that a nic
On 11/18/2020 9:02 AM, Parav Pandit wrote:
>
>> From: David Ahern
>> Sent: Wednesday, November 18, 2020 9:51 PM
>>
>> On 11/12/20 12:24 PM, Parav Pandit wrote:
>>> Extended devlink interface for the user to add and delete port.
>>> Extend devlink to connect user requests to driver to add/delet
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
This is a follow to the
On 11/13/2020 1:12 PM, Jakub Kicinski wrote:
> On Thu, 12 Nov 2020 16:01:42 -0800 Jacob Keller wrote:
>> All drivers which implement the devlink flash update support, with the
>> exception of netdevsim, use either request_firmware or
>> request_firmware_direct to loc
On 11/13/2020 1:34 PM, Jacob Keller wrote:
> Well, at least with ice, the experience is pretty bad. I tried out with
> a garbage file name on one of my test systems. This was on a slightly
> older kernel without this patch applied, and the device had a pending
> update that had
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
This is a follow to the
On 11/13/2020 2:32 PM, Jacob Keller wrote:
>
>
> On 11/13/2020 1:34 PM, Jacob Keller wrote:
>> Well, at least with ice, the experience is pretty bad. I tried out with
>> a garbage file name on one of my test systems. This was on a slightly
>> older kernel without
On 11/14/2020 8:10 PM, Jakub Kicinski wrote:
> On Fri, 13 Nov 2020 14:51:36 -0800 Jacob Keller wrote:
>> On 11/13/2020 2:32 PM, Jacob Keller wrote:
>>>
>>>
>>> On 11/13/2020 1:34 PM, Jacob Keller wrote:
>>>> Well, at least with ice, the e
...@intel.com/
[2]
https://lore.kernel.org/netdev/20201113224559.3910864-1-jacob.e.kel...@intel.com/
[3]
https://lore.kernel.org/netdev/6352e9d3-02af-721e-3a54-ef99a666b...@intel.com/
Jacob Keller (2):
devlink: move request_firmware out of driver
devlink: move flash end and begin to
ow no longer possible
to do the wrong thing in this regard. We also save a couple of lines of
code in each driver.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
drivers/net/ethernet/bro
userspace mechanism,
there should be essentially no difference between request_firmware and
request_firmware_direct.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Michael Chan
Cc: Shannon Nelson
Cc: Saeed Mahameed
Cc: Boris Pismenny
Cc: Bin Luo
Cc: Jakub Kicinksi
---
.../net/ethernet/broadcom
On 11/17/2020 12:08 PM, Jacob Keller wrote:
> All drivers which implement the devlink flash update support, with the
> exception of netdevsim, use either request_firmware or
> request_firmware_direct to locate the firmware file. Rather than having
> each driver do this separately as
other utility to complain about
using BIT() macros in UAPI..?
Unfortunately this is easy to overlook because the kernel side code
almost always has BIT defined, so you won't get a compilation failure
until you try to use the uapi header in a userspace program.
Reviewed-by: Jacob Keller
>
>
Nice to see this step! Everything seems straight forward to me.
Reviewed-by: Jacob Keller
> Jakub Kicinski (4):
> udp_tunnel: hard-wire NDOs to udp_tunnel_nic_*_port() helpers
> udp_tunnel: remove REGISTER/UNREGISTER handling from tunnel drivers
> net: remove
On 1/6/2021 5:45 AM, Vladimir Oltean wrote:
> On Tue, Jan 05, 2021 at 08:58:50PM +0200, Vladimir Oltean wrote:
>> This is marked as Request For Comments for a reason.
>
> If nobody has any objections, I will remove the memory leaks I
> introduced to check if anybody is paying attention, and I w
On 10/21/2020 5:02 PM, Jakub Kicinski wrote:
> On Wed, 21 Oct 2020 22:25:48 +0200 Thomas Gleixner wrote:
>> On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote:
>>> On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote:
However, IMHO we would still need a logic to prevent the devices fro
On 10/26/2020 12:00 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 14:30, Marcelo Tosatti wrote:
>> On Fri, Oct 23, 2020 at 11:00:52PM +0200, Thomas Gleixner wrote:
>>> So without information from the driver which tells what the best number
>>> of interrupts is with a reduced number of CPUs
On 10/26/2020 1:11 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 12:21, Jacob Keller wrote:
>> On 10/26/2020 12:00 PM, Thomas Gleixner wrote:
>>> How does userspace know about the driver internals? Number of management
>>> interrupts, optimal number of interrup
On 10/26/2020 3:13 PM, Jakub Kicinski wrote:
> On Mon, 26 Oct 2020 22:50:45 +0100 Thomas Gleixner wrote:
>> On Mon, Oct 26 2020 at 14:11, Jacob Keller wrote:
>>> On 10/26/2020 1:11 PM, Thomas Gleixner wrote:
>>>> On Mon, Oct 26 2020 at 12:21, Jacob Keller wr
On 10/26/2020 3:49 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 18:22, Nitesh Narayan Lal wrote:
>> On 10/26/20 5:50 PM, Thomas Gleixner wrote:
>>> But I still think that for curing that isolation stuff we want at least
>>> some information from the driver. Alternative solution would be t
Hi Jakub,
It looks like net-next just pulled in a change to checkpatch.pl which
causes it to break:
$ ./scripts/checkpatch.pl
Global symbol "$gitroot" requires explicit package name (did you forget
to declare "my $gitroot"?) at ./scripts/checkpatch.pl line 980.
Execution of ./scripts/checkpatch.p
On 10/27/2020 4:03 PM, Jakub Kicinski wrote:
> On Tue, 27 Oct 2020 15:56:35 -0700 Jacob Keller wrote:
>> Hi Jakub,
>>
>> It looks like net-next just pulled in a change to checkpatch.pl which
>> causes it to break:
>>
>> $ ./scripts/checkpatch.pl
>&g
On 11/2/2020 3:07 PM, Saeed Mahameed wrote:
> On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
>> From: Jacob Keller
>>
>> When printing messages with ice_debug, align the printed string to
>> the
>> origin line of the message in order to ease debugging
On 1/25/2021 4:39 PM, Saleem, Shiraz wrote:
>> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
>> implement private channel OPs
>>
>> On Sun, Jan 24, 2021 at 03:45:51PM +0200, Leon Romanovsky wrote:
>>> On Fri, Jan 22, 2021 at 05:48:12PM -0600, Shiraz Saleem wrote:
F
On 1/25/2021 9:29 PM, Leon Romanovsky wrote:
> On Mon, Jan 25, 2021 at 05:01:40PM -0800, Jacob Keller wrote:
>>
>>
>> On 1/25/2021 4:39 PM, Saleem, Shiraz wrote:
>>>> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and
>>>> implem
On 1/29/2021 1:04 PM, Willem de Bruijn wrote:
> On Fri, Jan 29, 2021 at 4:01 PM Willem de Bruijn
> wrote:
>>
>> On Thu, Jan 28, 2021 at 7:46 PM Tony Nguyen
>> wrote:
>>>
>>> From: Jacob Keller
>>>
>>> The ice flash contains two co
On 1/29/2021 12:23 PM, Willem de Bruijn wrote:
> On Thu, Jan 28, 2021 at 4:45 PM Tony Nguyen
> wrote:
>>
>> From: Aleksandr Loktionov
>>
>> This reverts commit 2ad1274fa35ace5c6360762ba48d33b63da2396c
>>
>> VF queues were not brought up when PF was brought up after being
>> downed if the VF d
On 1/29/2021 10:37 PM, Jakub Kicinski wrote:
> On Thu, 28 Jan 2021 16:43:27 -0800 Tony Nguyen wrote:
>> When reporting the versions via devlink info, first read the device
>> capabilities. If there is a pending flash update, use this new function
>> to extract the inactive flash versions. Add th
On 2/1/2021 2:34 PM, Jakub Kicinski wrote:
> On Mon, 1 Feb 2021 13:40:27 -0800 Jacob Keller wrote:
>> On 1/29/2021 10:37 PM, Jakub Kicinski wrote:
>>> On Thu, 28 Jan 2021 16:43:27 -0800 Tony Nguyen wrote:
>>>> When reporting the versions via devli
On 3/9/2021 2:52 PM, Jakub Kicinski wrote:
> On Tue, 9 Mar 2021 16:18:58 +0200 Eran Ben Elisha wrote:
DLH_REMEDY_LOCAL_FIX: associated component will undergo a local
un-harmful fix attempt.
(e.g look for lost interrupt in mlx5e_tx_reporter_timeout_recover())
>>>
>>> Should we make
On 2/3/2021 12:41 PM, Jakub Kicinski wrote:
> On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote:
>> From: Jacob Keller
>>
>> The ice NVM flash has a security revision field for the main NVM bank
>> and the Option ROM bank. In addition to the revision within the
On 2/3/2021 6:08 PM, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 17:34:24 -0800 Jacob Keller wrote:
>> On 2/3/2021 12:41 PM, Jakub Kicinski wrote:
>>> On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote:
>>>> From: Jacob Keller
>>>>
>>>&g
On 2/3/2021 6:08 PM, Jakub Kicinski wrote:
> On Wed, 3 Feb 2021 17:34:24 -0800 Jacob Keller wrote:
>> On 2/3/2021 12:41 PM, Jakub Kicinski wrote:
>>> On Thu, 28 Jan 2021 16:43:21 -0800 Tony Nguyen wrote:
>>>> From: Jacob Keller
>>>>
>>>&g
On 2/4/2021 11:10 AM, Jacob Keller wrote:
> I'd rather see the right solution designed here, so if this isn't the
> right direction I want to work with the list to figure out what makes
> the most sense. (Even if that's "minimum security should update
> automatic
On 8/10/2020 9:53 AM, Jakub Kicinski wrote:
> On Sun, 9 Aug 2020 16:21:29 +0300 Moshe Shemesh wrote:
>> Okay, so devlink reload default for mlx5 will include also fw-activate
>> to align with mlxsw default.
>>
>> Meaning drivers that supports fw-activate will add it to the default.
>
> No per-
attribute works. A new debugfs hook is used to
control what set of overwrite mask values the netdevsim driver will
accept.
Signed-off-by: Jacob Keller
---
Changes since v2:
* re-wrote commit message, including additional clarification on the concept
and reasoning.
* removed use of GENMASK in the
unsupported
attribute in the message.
Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc
ries
* provided some examples in the cover letter
* use nla_bitfield32 instead of a straight u32
Jacob Keller (4):
devlink: check flash_update parameter support in net core
devlink: convert flash_update to use params structure
devlink: introduce flash update overwrite mask
ice: add support for fl
Add support for specifying the overwrite sections to allow in the flash
update command. This is done by adding a new "overwrite" option which
can take either "settings" or "identifiers" passing the overwrite mode
multiple times will combine the fields using bitwise-OR
identifiers, this combination is rejected by the driver as not supported
with an appropriate extended ACK message.
Signed-off-by: Jacob Keller
---
Changes since v2:
* Rewrote the commit message slightly
Documentation/networking/devlink/ice.rst | 31 +++
drivers/net/ethernet
be specified as the
DEVLINK_SUPPORTED_FLASH_OVERWRITE_SECTIONS provided in our copy of the uapi
header.
Changes since v2:
* remove the use of GENMASK from the userspace API header.
* separate iproute2 and net-next patches to avoid confusion.
* convert to using an nla_bitfield32 using the mnl_attr_push().
Jacob Keller (2):
U
Signed-off-by: Jacob Keller
---
include/uapi/linux/devlink.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index b7f23faae901..bc63bd0b60c1 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi
ate_params bitfield.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
---
Changes since v2:
* split this conversion to a params struct into a separate
On 8/19/2020 4:36 PM, David Miller wrote:
> From: Jacob Keller
> Date: Tue, 18 Aug 2020 17:28:15 -0700
>
>> @@ -991,6 +993,12 @@ enum devlink_trap_group_generic_id {
>> }
>>
>> struct devlink_ops {
>> +/**
>> + * @supported_flash
uot;i40e/i40evf: fix interrupt affinity bug", 2016-09-14)
Signed-off-by: Jacob Keller
Cc: sta...@vger.kernel.org # 4.10+
---
This updates the commit message for the original fix, and indicates that
it fixes a potential crash, as well as tagged the commit for stable and
added a Fixes to indicate whic
mum number of xmit_more skbs to send in a sequence. This ensures
that all drivers benefit, and allows system administrators the option to
tune the value to their environment.
Signed-off-by: Jacob Keller
---
Stray thoughts and further questions
Is this the right approach? Did I miss any ot
pointer dereference, since both the for-loop and
memset in fq_codel_reset will be no-ops when flow_cnt is zero.
Signed-off-by: Jacob Keller
---
net/sched/sch_fq_codel.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/net/sched/sch_fq_codel.c b/net/sched/
pointer dereference, since both the for-loop and
memset in fq_codel_reset will be no-ops when flow_cnt is zero.
Signed-off-by: Jacob Keller
---
net/sched/sch_fq_codel.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/net/sched/sch_fq_codel.c b/net/sched/
On Mon, Apr 2, 2018 at 7:05 AM, Bjorn Helgaas wrote:
> +/* PCIe speed to Mb/s reduced by encoding overhead */
> +#define PCIE_SPEED2MBS_ENC(speed) \
> + ((speed) == PCIE_SPEED_16_0GT ? (16000*(128/130)) : \
> +(speed) == PCIE_SPEED_8_0GT ? (8000*(128/130)) : \
> +(speed) ==
hat it can be shared across drivers as part of ethtool
kernel work.
Signed-off-by: Jacob Keller
---
Sorry aboutthe delay, our iwl queue maintainer Jeff is on vacation, and
discussion about how best to resolve this issue was/is ongoing in the
IWL list.
I opted to just move the contents of t
the current code.
Signed-off-by: Jacob Keller
---
Documentation/networking/net_dim.txt | 32 ++--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/Documentation/networking/net_dim.txt
b/Documentation/networking/net_dim.txt
index 9cb31c5e2dcd..729d01c1619b 1
the current code.
Fixes: 8960b38932be ("linux/dim: Rename externally used net_dim members",
2019-06-25)
Fixes: c002bd529d71 ("linux/dim: Rename externally exposed macros", 2019-06-25)
Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
Cc: Tal Gilboa
S
Add support to request that a new snapshot be taken immediately for
a devlink region. To avoid confusion, the desired snapshot id must be
provided.
Note that if a region does not support snapshots on demand, the kernel
will reject the request with -EOPNOTSUP.
Signed-off-by: Jacob Keller
Add support to request that a new snapshot be taken immediately for
a devlink region. To avoid confusion, the desired snapshot id must be
provided.
Note that if a region does not support snapshots on demand, the kernel
will reject the request with -EOPNOTSUP.
Signed-off-by: Jacob Keller
ichael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
Changes since v3:
* split netdevsim changes to a new patch
* fixed a minor typo in the documentation
* sent iproute2 patches completely separately
Jacob Keller (5):
devlink: check flash_update
unsupported
attribute in the message.
Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc
ask values controllable via
a debugfs parameter. This enables testing a flow where the driver
rejects an unsupportable overwrite mask.
Signed-off-by: Jacob Keller
---
This patch is new in v4
drivers/net/netdevsim/dev.c| 10 +-
drivers/net/netdevsim/netdevsim.h
overwrite mask must set the
DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK in the
supported_flash_update_params field of their devlink_ops.
Signed-off-by: Jacob Keller
---
Changes since v3
* split netdevsim driver changes to a new patch
* fixed a double-the typo in the documentation
.../networking
ate_params bitfield.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
---
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 ---
.../net/ethernet/hu
identifiers, this combination is rejected by the driver as not supported
with an appropriate extended ACK message.
Signed-off-by: Jacob Keller
---
Documentation/networking/devlink/ice.rst | 31 +++
drivers/net/ethernet/intel/ice/ice_devlink.c | 19 +++-
.../net/ethernet
Add support for specifying the overwrite sections to allow in the flash
update command. This is done by adding a new "overwrite" option which
can take either "settings" or "identifiers" passing the overwrite mode
multiple times will combine the fields using bitwise-OR
subsections will be sent
in the overwrite mask, resulting in a request to overwrite all settings and
identifiers stored in the updated flash components.
$devlink dev flash pci/:af:00.0 file flash_image.bin overwrite settings
overwrite identifiers
Cc: Jiri Pirko
Cc: Jakub Kicinski
Jacob
Signed-off-by: Jacob Keller
---
include/uapi/linux/devlink.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index b7f23faae901..dc267058600d 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi
On 9/9/2020 5:55 PM, Jakub Kicinski wrote:
> On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote:
>> The devlink core recently gained support for checking whether the driver
>> supports a flash_update parameter, via `supported_flash_update_params`.
>> However, parame
On 9/9/2020 6:03 PM, Jakub Kicinski wrote:
> On Wed, 9 Sep 2020 15:26:51 -0700 Jacob Keller wrote:
>> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
>> index 40d35145c879..19a573566359 100644
>> --- a/include/uapi/linux/devlink.h
>> +++ b/i
On 9/9/2020 6:05 PM, Jakub Kicinski wrote:
> On Wed, 9 Sep 2020 15:26:52 -0700 Jacob Keller wrote:
>> The devlink interface recently gained support for a new "overwrite mask"
>> parameter that allows specifying how various sub-sections of a flash
>> compo
On 9/10/2020 1:13 PM, David Miller wrote:
> From: Jacob Keller
> Date: Wed, 9 Sep 2020 15:26:48 -0700
>
>> This series introduces support for a new attribute to the flash update
>> command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK.
>
> I think you really need t
mbined to indicate that a combination
>> of the set of fields that should be overwritten.
>>
>> Drivers which support the new overwrite mask must set the
>> DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK in the
>> supported_flash_update_params field of t
overwrite mask must set the
DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK in the
supported_flash_update_params field of their devlink_ops.
Signed-off-by: Jacob Keller
---
Changes since v4
* Renamed nla_overwrite to nla_overwrite_mask to match convention of other
similar variable names
* added
ved use of BIT() in the uapi header
* Fixed the commit message for the netdevsim patch
* Picked up Jakub's reviewed tag.
Jacob Keller (5):
devlink: check flash_update parameter support in net core
devlink: convert flash_update to use params structure
devlink: introduce flash update ove
unsupported
attribute in the message.
Going forward, any new additional parameter to flash update will require
a bit in the supported_flash_update_params bitfield.
Signed-off-by: Jacob Keller
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc
ask values controllable via
a debugfs parameter. This enables testing a flow where the driver
rejects an unsupportable overwrite mask.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
Changes since v4
* Fixed subject line
* Picked up Jakub's reviewed-by tag
drivers/net/
ate_params bitfield.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Cc: Jiri Pirko
Cc: Jakub Kicinski
Cc: Jonathan Corbet
Cc: Michael Chan
Cc: Bin Luo
Cc: Saeed Mahameed
Cc: Leon Romanovsky
Cc: Ido Schimmel
Cc: Danielle Ratson
---
Changes since v4
* Picked up Jakub's reviewed-b
identifiers, this combination is rejected by the driver as not supported
with an appropriate extended ACK message.
Signed-off-by: Jacob Keller
Reviewed-by: Jakub Kicinski
---
Changes since v4
* Picked up Jakub's reviewed-by tag
Documentation/networking/devlink/ice.rst
On 9/10/2020 2:23 PM, Jakub Kicinski wrote:
> On Thu, 10 Sep 2020 13:59:07 -0700 Jacob Keller wrote:
>> On 9/9/2020 5:55 PM, Jakub Kicinski wrote:
>>> On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote:
>>>> The devlink core recently gained support f
On 9/10/2020 6:23 PM, Jesse Brandeburg wrote:
> While fixing the W=1 builds, this warning came up because the
> developers used a very tricky way to get structures initialized
> to a non-zero value, but this causes GCC to warn about an
> override. In this case the override was intentional, so ju
On 9/10/2020 10:56 AM, Jakub Kicinski wrote:
> IOW drop the component parameter from the normal helper, cause almost
> nobody uses that. The add a more full featured __ version, which would
> take the arg struct, the struct would include the timeout value.
>
I would point out that the ice drive
On 9/10/2020 10:56 AM, Jakub Kicinski wrote:
> On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote:
>> On 9/9/20 12:22 PM, Jakub Kicinski wrote:
>>> On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote:
I'm suggesting that this implementation using the existing devlink
logg
On 9/15/2020 10:39 AM, Jakub Kicinski wrote:
> On Tue, 15 Sep 2020 10:20:11 -0700 Shannon Nelson wrote:
> What should the userland program do when the timeout expires? Start
> counting backwards? Stop waiting? Do we care to define this at the
> moment?
[component] bla bla
On 10/5/2020 12:31 PM, Jakub Kicinski wrote:
> On Mon, 05 Oct 2020 21:21:36 +0200 Johannes Berg wrote:
But with the difference it seems to me that it'd be possible to get this
mixed up?
>>>
>>> Right, I prefer not to have the unnecessary NLA_REJECTS, so my thinking
>>> was - use the
On 10/5/2020 12:33 PM, Johannes Berg wrote:
> On Mon, 2020-10-05 at 12:31 -0700, Jakub Kicinski wrote:
>
>> Yea, I think we're both confused. Agreed with the above.
>>
>> Are you suggesting:
>>
>> const struct nla_policy policy[/* no size */] = {
>> [HEADER]= NLA_POLICY(...)
>>
On 10/5/2020 7:48 AM, Vladimir Oltean wrote:
> Currently skb_dump has a restriction to only dump full packet for the
> first 5 socket buffers, then only headers will be printed. Remove this
> arbitrary and confusing restriction, which is only documented vaguely
> ("up to") in the comments above
gt; the specific DDP package.
>
> Add the type field to the ``fw.app.bundle_id`` row.
>
> Fixes: 410d06879c01 ("ice: add the DDP Track ID to devlink info")
> Signed-off-by: Mauro Carvalho Chehab
Yep, looks correct. Thanks for the fix!
Reviewed-by: Jacob Keller
> ---
Signed-off-by: Jacob Keller
---
Changes since v2
* use clock_gettime on CLOCK_MONOTONIC instead of gettimeofday
* remove use of timersub since we're now using struct timespec
devlink/devlink.c | 105 +-
1 file changed, 104 insertions(+), 1 delet
On 7/27/2020 8:47 AM, Jamie Gloudon wrote:
> Hey,
>
> While having a discussion with Sasha from Intel. I noticed link partner
> advertised support is broken in ethtool 5.7. Sasha hinted to me, the
> new API that ethtool is using.
>
> I see the actual cause in dump_peer_modes() in netlink/setti
On 7/27/2020 2:01 PM, Andrew Lunn wrote:
> Here are the netlink messages.
>
> sending genetlink packet (32 bytes):
> msg length 32 genl-ctrl
> CTRL_CMD_GETFAMILY
> CTRL_ATTR_FAMILY_NAME = "ethtool"
> ...
> ...
> sending genetlink packet (36 bytes):
> msg length 36 ethool ETH
On 7/27/2020 2:08 PM, Michal Kubecek wrote:
> On Mon, Jul 27, 2020 at 11:01:41PM +0200, Andrew Lunn wrote:
>>> - the exact command you ran (including arguments)
>>> - expected output (or at least the relevant part)
>>> - actual output (or at least the relevant part)
>>> - output with dum
On 7/27/2020 2:25 PM, Andrew Lunn wrote:
> On Mon, Jul 27, 2020 at 11:08:43PM +0200, Michal Kubecek wrote:
>> On Mon, Jul 27, 2020 at 11:01:41PM +0200, Andrew Lunn wrote:
- the exact command you ran (including arguments)
- expected output (or at least the relevant part)
- ac
1 - 100 of 313 matches
Mail list logo
