On 7/27/2020 2:25 PM, Andrew Lunn wrote:
> On Mon, Jul 27, 2020 at 11:08:43PM +0200, Michal Kubecek wrote:
>> On Mon, Jul 27, 2020 at 11:01:41PM +0200, Andrew Lunn wrote:
>>>> - the exact command you ran (including arguments)
>>>> - expected output (or at least the relevant part)
>>>> - actual output (or at least the relevant part)
>>>> - output with dump of netlink messages, you can get it by enabling
>>>> debugging flags, e.g. "ethtool --debug 0x12 eth0"
>>>
>>> Hi Michal
>>>
>>> See if this helps.
>>>
>>> This is a Marvel Ethernet switch port using an Marvell PHY.
>>
>> Thank you. I think I can see the problem. Can you try the patch below?
>
> Hi Michal
>
> This is better.
>
I got similar results testing with a modified netdevsim driver.
I think the correct solution requires checking for the NOMASK flag and
then behaving differently in all three of dump_link_modes, dump_pause,
and bitset_get_bit.
> Link partner advertised link modes: 10baseT/Half 10baseT/Full
> 100baseT/Half 100baseT/Full
> 1000baseT/Full
> Link partner advertised pause frame use: No
> Link partner advertised auto-negotiation: No
> Link partner advertised FEC modes: No
>
> However, the Debian version gives:
>
> Link partner advertised link modes: 10baseT/Half 10baseT/Full
> 100baseT/Half 100baseT/Full
> 1000baseT/Full
> Link partner advertised pause frame use: No
> Link partner advertised auto-negotiation: Yes
> Link partner advertised FEC modes: Not reported
>
> For the USB-Ethernet dongle:
>
> netlink:
> Link partner advertised link modes: 10baseT/Half 10baseT/Full
> 100baseT/Half 100baseT/Full
> Link partner advertised pause frame use: No
> Link partner advertised auto-negotiation: No
> Link partner advertised FEC modes: No
> IOCTL
> Link partner advertised link modes: 10baseT/Half 10baseT/Full
> 100baseT/Half 100baseT/Full
> Link partner advertised pause frame use: Symmetric
> Link partner advertised auto-negotiation: Yes
> Link partner advertised FEC modes: Not reported
>
> Andrew
>
