Recent cls_flower offload rewrite added a double new line.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/flower/offload.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c
b/drivers/net/ethe
Currently bpf_offload_dev does not have any priv pointer, forcing
the drivers to work backwards from the netdev in program metadata.
This is not great given programs are conceptually associated with
the offload device, and it means one or two unnecessary deferences.
Add a priv pointer to bpf_offloa
On Mon, 11 Feb 2019 11:31:13 -0800
Alexander Duyck wrote:
> On Mon, Feb 11, 2019 at 8:07 AM Jesper Dangaard Brouer
> wrote:
> >
> > From: Ilias Apalodimas
> >
> > As pointed out by David Miller the current page_pool implementation
> > stores dma_addr_t in page->private.
> > This won't work on 3
On Mon, 11 Feb 2019 12:16:24 -0800
Andrew Morton wrote:
> On Mon, 11 Feb 2019 17:06:46 +0100 Jesper Dangaard Brouer
> wrote:
>
> > The page_pool API is using page->private to store DMA addresses.
> > As pointed out by David Miller we can't use that on 32-bit architectures
> > with 64-bit DMA
>
Gustavo A. R. Silva schreef op ma 11-02-2019 om 16:34 [-0600]:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’:
> dr
From: Björn Töpel
In commit f3fef2b6e1cc ("i40e: Remove umem from VSI") a regression was
introduced; When the VSI was reset, the setup code would try to enable
AF_XDP ZC unconditionally (as long as there was a umem placed in the
netdev._rx struct). Here, we add a bitmap to the VSI that tracks if
From: Björn Töpel
The i40e_xsk_umem function was explicitly inlined in i40e.h. There is
no reason for that, so move it to i40e_main.c instead.
Signed-off-by: Björn Töpel
---
drivers/net/ethernet/intel/i40e/i40e.h | 14 --
drivers/net/ethernet/intel/i40e/i40e_main.c | 20 ++
This series addresses a recent AF_XDP zero-copy regression.
In commit f3fef2b6e1cc ("i40e: Remove umem from VSI") a regression was
introduced; When the VSI was reset, the setup code would try to enable
AF_XDP ZC unconditionally (as long as there was a umem placed in the
netdev._rx struct). Here, w
On Fri, Feb 8, 2019 at 12:26 PM Mahesh Bandewar (महेश बंडेवार)
wrote:
>
> On Wed, Feb 6, 2019 at 8:51 PM Mahesh Bandewar (महेश बंडेवार)
> wrote:
> >
> > On Tue, Feb 5, 2019 at 11:36 AM Michael Chan
> > wrote:
> > > I've looked at this a little more. The blackhole_dev is not IFF_UP |
> > > IFF_
Hello!
On 12.02.2019 10:09, Parav Pandit wrote:
While finding the devlink device during region reading,
devlink device list is accessed and devlink device is
returned without holding a lock. This could lead to user-after-free
Use-after-free, perhaps?
accesses.
While at it, add lockdep a
Mon, Feb 11, 2019 at 10:17:46PM CET, f.faine...@gmail.com wrote:
>Hi all,
>
>AFAICT there is no code that attempts to get the value of the attribute
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
>switchdev_port_attr_set().
>
>This is effectively no doing anything and it can slow down f
Mon, Feb 11, 2019 at 10:17:47PM CET, f.faine...@gmail.com wrote:
>There is no code that will query the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
>attribute remove support for that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
Mon, Feb 11, 2019 at 10:17:49PM CET, f.faine...@gmail.com wrote:
>There is no code that tries to get the attribute
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS, remove support for doing that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
Mon, Feb 11, 2019 at 10:17:48PM CET, f.faine...@gmail.com wrote:
>There is no code that attempts to get the
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute, remove support for that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
Tue, Feb 12, 2019 at 06:59:51AM CET, xiyou.wangc...@gmail.com wrote:
>The current opt_inst_list operations inside team_nl_cmd_options_set()
>is too complex to track:
>
>LIST_HEAD(opt_inst_list);
>nla_for_each_nested(...) {
>list_for_each_entry(opt_inst, &team->option_inst_list, list
On Mon, 11 Feb 2019 08:55:51 -0800
Matthew Wilcox wrote:
> On Mon, Feb 11, 2019 at 05:06:46PM +0100, Jesper Dangaard Brouer wrote:
> > The page_pool API is using page->private to store DMA addresses.
> > As pointed out by David Miller we can't use that on 32-bit architectures
> > with 64-bit DMA
2019-02-12 10:25 UTC+0900 ~ Prashant Bhole
This patch adds missing information about feature-subcommand in
bpftool.rst
Signed-off-by: Prashant Bhole
---
v2: used tabs instead of spaces
Thanks a lot!
Reviewed-by: Quentin Monnet
On Mon, 2019-02-11 at 21:59 -0800, Cong Wang wrote:
> The current opt_inst_list operations inside team_nl_cmd_options_set()
> is too complex to track:
Indeed !
> LIST_HEAD(opt_inst_list);
> nla_for_each_nested(...) {
> list_for_each_entry(opt_inst, &team->option_inst_list, list) {
Jianlin reported a panic when running sctp gso over gre over vlan device:
[ 84.772930] RIP: 0010:do_csum+0x6d/0x170
[ 84.790605] Call Trace:
[ 84.791054] csum_partial+0xd/0x20
[ 84.791657] gre_gso_segment+0x2c3/0x390
[ 84.792364] inet_gso_segment+0x161/0x3e0
[ 84.793071]
In sctp_stream_init(), after sctp_stream_outq_migrate() freed the
surplus streams' ext, but sctp_stream_alloc_out() returns -ENOMEM,
stream->outcnt will not be set to 'outcnt'.
With the bigger value on stream->outcnt, when closing the assoc and
freeing its streams, the ext of those surplus streams
Vinod,
On 21/01/2019 11.13, Vinod Koul wrote:
> For RGMII mode, phy delay should be disabled. Add this case along
> with disable delay routines.
In next-20190211 I need to revert this patch to get cpsw networking to work on
am335x-evmsk. The board uses AR8031_AL1A PHY, which is handled by the
p
Hi Arthur,
On Mon, Feb 11, 2019 at 9:19 AM wrote:
>
> From: Arthur Kiyanovski
>
> Update driver version due to bug fix.
Wouldn't you want to do this atomically with the actual fix in one commit?
Thanks,
Moritz
Hi Peter,
On 12-02-19, 12:55, Peter Ujfalusi wrote:
> Vinod,
>
> On 21/01/2019 11.13, Vinod Koul wrote:
> > For RGMII mode, phy delay should be disabled. Add this case along
> > with disable delay routines.
>
> In next-20190211 I need to revert this patch to get cpsw networking to
> work on am33
SOCK_DEBUG is a very ancient debugging interface, and it's not very useful
for debugging.
This pacthset cleanups SOCK_DEBUG() and replace it with a new methord
based on BPF.
I cleanup SOCK_DEBUG() only for TCP, and other protocols are kept as is.
After this patchset, the SO_DEBUG interface will n
Introuce this new op BPF_SOCK_OPS_STATS_CB for tcp_stats() such that it
can be traced via BPF on a per socket basis.
There's one argument in BPF_SOCK_OPS_STATS_CB, which is Linux MIB index
LINUX_MIB_* to indicate the TCP event.
All these Linux MIBs are defined in include/uapi/linux/snmp.h.
Signed-
SOCK_DEBUG is a very ancient debugging interface, and it's not very useful
for debugging.
So this patch removes the SOCK_DEBUG() and introduce a new function
tcp_stats() to trace this kind of events.
Some MIBs are added for these events.
Regarding the SO_DEBUG in sock_{s,g}etsockopt, I think it is
Hi Moritz,
> -Original Message-
> From: Moritz Fischer
> Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to
> 2.0.3
>
> Hi Arthur,
>
> On Mon, Feb 11, 2019 at 9:19 AM wrote:
> >
> > From: Arthur Kiyanovski
> >
> > Update driver version due to bug fix.
>
> W
Hi Dave,
We have few more fixes, mostly one-liners; two are bigger:
* the speculation one, only because the function had multiple
return points and that had to change, and
* the peer measurement locking one, because I had to refactor
a function to be able to call it with or without locking
Hi Vinod,
On 12/02/2019 13.31, Vinod Koul wrote:
> Hi Peter,
>
> On 12-02-19, 12:55, Peter Ujfalusi wrote:
>> Vinod,
>>
>> On 21/01/2019 11.13, Vinod Koul wrote:
>>> For RGMII mode, phy delay should be disabled. Add this case along
>>> with disable delay routines.
>>
>> In next-20190211 I need to
On Mon, Feb 11, 2019 at 12:45:54PM -0800, David Miller wrote:
> From: Sean Tranchetti
> Date: Thu, 7 Feb 2019 13:33:21 -0700
>
> > Attempting to avoid cloning the skb when broadcasting by inflating
> > the refcount with sock_hold/sock_put while under RCU lock is dangerous
> > and violates RCU pr
Hi again,
On 12-02-19, 17:01, Vinod Koul wrote:
> Hi Peter,
>
> On 12-02-19, 12:55, Peter Ujfalusi wrote:
> > Vinod,
> >
> > On 21/01/2019 11.13, Vinod Koul wrote:
> > > For RGMII mode, phy delay should be disabled. Add this case along
> > > with disable delay routines.
> >
> > In next-20190211
On Mon, Feb 11, 2019 at 01:17:47PM -0800, Florian Fainelli wrote:
> There is no code that will query the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
> attribute remove support for that.
>
> Signed-off-by: Florian Fainelli
Reviewed-by: Ido Schimmel
On Mon, Feb 11, 2019 at 11:09:53AM -0800, Florian Fainelli wrote:
> Update the section about switchdev drivers having to implement a
> switchdev_port_attr_get() function to return
> SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after
> commit bccb30254a4a ("net: Get rid of
> SWITCH
On Sat, Feb 9, 2019 at 11:06 PM Rahul Verma wrote:
>
> From: Rahul Verma
>
> This patch adds new FW for bnx2x, which adds the following:
> - TX VLAN filtering support.
> - Enable TPA only for packets without VLAN.
>
> It also addresses few critical issues,
> - Fairness algorithm misbehaviour w
On 2/11/2019 7:14 PM, Eric Dumazet wrote:
>
>
> On 02/11/2019 12:53 AM, Tariq Toukan wrote:
>>
>
>> Hi,
>>
>> It's great to use the struct page to store its dma mapping, but I am
>> worried about extensibility.
>> page_pool is evolving, and it would need several more per-page fields.
>> One of
On Tue, Feb 12, 2019 at 07:51:05AM +0100, Heiner Kallweit wrote:
> On 12.02.2019 04:58, Andrew Lunn wrote:
> >>> Hi David
> >>>
> >>> I just tested this on one of my boards. It loops endlessly:
> >>>
> >>> [ 47.173396] mv88e6xxx_g1_irq_thread_work: c881 a8 80
> >>>
> >>>
The bitmap of found partitions in efx_ef10_mtd_probe was not
initialised, causing partitions to be suppressed based off whatever
value was in the bitmap at the start.
Fixes: 3366463513f5 ("sfc: suppress duplicate nvmem partition types in
efx_ef10_mtd_probe")
Signed-off-by: Bert Kenward
---
driv
On Tue, Feb 12, 2019 at 11:42:31AM +, Kiyanovski, Arthur wrote:
> Hi Moritz,
>
> > -Original Message-
> > From: Moritz Fischer
> > Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2
> > to
> > 2.0.3
> >
> > Hi Arthur,
> >
> > On Mon, Feb 11, 2019 at 9:19 AM
On Mon, Feb 11, 2019 at 11:09:52AM -0800, Florian Fainelli wrote:
> Hi all,
>
> This patch series finishes by the removal of switchdev_ops. To get there
> we convert the existing switchdev_port_attr_{set,get} switchdev_ops to
> use a blocking notifier, thus making it consistent with how the object
On 12/02/2019 11:55, Peter Ujfalusi wrote:
> On 21/01/2019 11.13, Vinod Koul wrote:
>
>> For RGMII mode, phy delay should be disabled. Add this case along
>> with disable delay routines.
>
> In next-20190211 I need to revert this patch to get cpsw networking
> to work on am335x-evmsk. The board
On Tue, 12 Feb 2019 12:39:59 +
Tariq Toukan wrote:
> On 2/11/2019 7:14 PM, Eric Dumazet wrote:
> >
> > On 02/11/2019 12:53 AM, Tariq Toukan wrote:
> >>
> >
> >> Hi,
> >>
> >> It's great to use the struct page to store its dma mapping, but I am
> >> worried about extensibility.
> >> pa
On Mon, Feb 11, 2019 at 11:09:54AM -0800, Florian Fainelli wrote:
> In preparation for allowing switchdev enabled drivers to veto specific
> attribute settings from within the context of the caller, introduce a
> new switchdev notifier type for port attributes.
>
> Suggested-by: Ido Schimmel
> Ac
Hi,
Booting 4.20 on SolidRun Clearfog reliably provokes the following
warning - this is with mvneta built in, but DSA as modules:
WARNING: CPU: 0 PID: 555 at kernel/dma/debug.c:1230 check_sync+0x514/0x5bc
mvneta f107.ethernet: DMA-API: device driver tries to sync DMA memory it
has not alloca
Tue, Feb 12, 2019 at 02:14:47PM CET, ido...@mellanox.com wrote:
>On Mon, Feb 11, 2019 at 11:09:52AM -0800, Florian Fainelli wrote:
>> Hi all,
>>
>> This patch series finishes by the removal of switchdev_ops. To get there
>> we convert the existing switchdev_port_attr_{set,get} switchdev_ops to
>>
On Mon, Feb 11, 2019 at 11:09:56AM -0800, Florian Fainelli wrote:
> Following patches will change the way we communicate getting or setting
> a port's attribute and use a blocking notifier to perform those tasks.
>
> Prepare mlxsw to support receiving notifier events targeting
> SWITCHDEV_PORT_ATT
On Mon, Feb 11, 2019 at 11:10:01AM -0800, Florian Fainelli wrote:
> Now that we have converted all possible callers to using a switchdev
> notifier for attributes we do not have a need for implementing
> switchdev_ops anymore, and this can be removed from all drivers the
> net_device structure.
>
On Mon, Feb 11, 2019 at 9:38 PM David Miller wrote:
>
> From: Alin Nastac
> Date: Thu, 7 Feb 2019 16:05:31 +0100
>
> > Original packet destination address must be used as saddr for the
> > route lookup performed by icmp6_send() even when this address is
> > not local. This fixes the IPv6 router
Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode
should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID
can have delay in phy.
So disable the delay only for RGMII mode and disable for other modes
Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RG
On Sun, Feb 10, 2019 at 11:34:14AM -0800, Florian Fainelli wrote:
> Le 2/10/19 à 11:05 AM, Ido Schimmel a écrit :
> > On Sun, Feb 10, 2019 at 09:50:55AM -0800, Florian Fainelli wrote:
> >> Now that all switchdev drivers have been converted to checking the
> >> bridge port flags during the prepare p
As pointed out by David Miller in [1] the current page_pool implementation
stores dma_addr_t in page->private. This won't work on 32-bit platforms with
64-bit DMA addresses since the page->private is an unsigned long and the
dma_addr_t a u64.
Since no driver is yet using the DMA mapping capabiliti
The page_pool API is using page->private to store DMA addresses.
As pointed out by David Miller we can't use that on 32-bit architectures
with 64-bit DMA
This patch adds a new dma_addr_t struct to allow storing DMA addresses
Signed-off-by: Jesper Dangaard Brouer
Signed-off-by: Ilias Apalodimas
As pointed out by Alexander Duyck, the DMA mapping done in page_pool needs
to use the DMA attribute DMA_ATTR_SKIP_CPU_SYNC.
As the principle behind page_pool keeping the pages mapped is that the
driver takes over the DMA-sync steps.
Signed-off-by: Jesper Dangaard Brouer
Signed-off-by: Ilias Apal
From: Ilias Apalodimas
As pointed out by David Miller the current page_pool implementation
stores dma_addr_t in page->private.
This won't work on 32-bit platforms with 64-bit DMA addresses since the
page->private is an unsigned long and the dma_addr_t a u64.
A previous patch is adding dma_addr_t
On 2/12/19 2:45 AM, Paul Bolle wrote:
> Gustavo A. R. Silva schreef op ma 11-02-2019 om 16:34 [-0600]:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/isdn/gigaset/ser-g
On 2/12/2019 3:49 PM, Jesper Dangaard Brouer wrote:
> On Tue, 12 Feb 2019 12:39:59 +
> Tariq Toukan wrote:
>
>> On 2/11/2019 7:14 PM, Eric Dumazet wrote:
>>>
>>> On 02/11/2019 12:53 AM, Tariq Toukan wrote:
>>>
Hi,
It's great to use the struct page to store its dma
On 02/12/2019 03:31 AM, Yafang Shao wrote:
> SOCK_DEBUG is a very ancient debugging interface, and it's not very useful
> for debugging.
> So this patch removes the SOCK_DEBUG() and introduce a new function
> tcp_stats() to trace this kind of events.
> Some MIBs are added for these events.
>
>
Since cipso_v4_error might be called from different network stack layers, we
can't safely use icmp_send there.
icmp_send copies IP options with ip_option_echo, which uses IPCB to take access
to IP header compiled data.
But after commit 971f10ec ("tcp: better TCP_SKB_CB layout to reduce cache line
On 02/12/2019 03:31 AM, Yafang Shao wrote:
> Introuce this new op BPF_SOCK_OPS_STATS_CB for tcp_stats() such that it
> can be traced via BPF on a per socket basis.
> There's one argument in BPF_SOCK_OPS_STATS_CB, which is Linux MIB index
> LINUX_MIB_* to indicate the TCP event.
> All these Linux
On 02/12/2019 04:39 AM, Tariq Toukan wrote:
>
>
> On 2/11/2019 7:14 PM, Eric Dumazet wrote:
>>
>>
>> On 02/11/2019 12:53 AM, Tariq Toukan wrote:
>>>
>>
>>> Hi,
>>>
>>> It's great to use the struct page to store its dma mapping, but I am
>>> worried about extensibility.
>>> page_pool is evolvin
From: Karsten Graul
When no free transfer buffers are available then a work to call
smc_tx_work() is scheduled. Set the schedule delay to zero, because for
the out-of-buffers condition the work can start immediately and will
block in the called function smc_wr_tx_get_free_slot(), waiting for free
From: Karsten Graul
Remove the shortcut that smc_lgr_free() would skip the check for
existing connections when the link group is not in the link group list.
Signed-off-by: Karsten Graul
Signed-off-by: Ursula Braun
---
net/smc/smc_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
From: Karsten Graul
For robustness protect of higher port numbers than expected to avoid
setting bits behind our port_event_mask. In case of an DEVICE_FATAL
event all ports must be checked. The IB_EVENT_GID_CHANGE event is
provided in the global event handler, so handle it there. And handle a
QP_
Add Karsten as additional maintainer for Shared Memory Communications
(SMC) Sockets.
Acked-by: Karsten Graul
Signed-off-by: Ursula Braun
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 604bca2fc05d..f3af5cde6456 100644
--- a/MAINTAINERS
+++ b/
From: Karsten Graul
In smc_cdc_msg_recv_action() the received cdc message is evaluated.
To reduce the number of messaged triggered by this evaluation the logic
is streamlined. For the write_blocked condition we do not need to send
a response immediately. The remaining conditions can be put togeth
From: Karsten Graul
When an updated rx_cursor_confirmed field was sent to the peer then
reset the cons_curs_upd_req flag. And remove the duplicate reset and
cursor update in smc_tx_consumer_update().
Signed-off-by: Karsten Graul
Signed-off-by: Ursula Braun
---
net/smc/smc_cdc.c | 5 -
net
From: Karsten Graul
Move the call to smc_close_wake_tx_prepared() (which wakes up a possibly
waiting close processing that might wait for 'all data sent') to
smc_tx_sndbuf_nonempty() (which is the main function to send data).
Signed-off-by: Karsten Graul
Signed-off-by: Ursula Braun
---
net/sm
Dave,
here are patches for SMC:
* patches 1 and 3 optimize SMC-R tx logic
* patch 2 is a cleanup without functional change
* patch 4 optimizes rx logic
* patches 5 and 6 improve robustness in link group and IB event handling
* patch 7 establishes Karsten Graul as another SMC maintainer
Thanks, Ur
Hi,
On Mon, Feb 11, 2019 at 11:36:10AM -0800, Stephen Hemminger wrote:
> On Mon, 11 Feb 2019 10:17:06 +0100
> Phil Sutter wrote:
[...]
> > diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> > index 73d37c190fffa..5c327f01b6b45 100644
> > --- a/man/man8/ip-link.8.in
> > +++ b/man/man8/ip
On Tue, Feb 12, 2019 at 06:47:30PM +0800, Xin Long wrote:
> Jianlin reported a panic when running sctp gso over gre over vlan device:
>
> [ 84.772930] RIP: 0010:do_csum+0x6d/0x170
> [ 84.790605] Call Trace:
> [ 84.791054] csum_partial+0xd/0x20
> [ 84.791657] gre_gso_segment+0x2c3
From: Yang Wei
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/neterion/s2io.c | 2 +-
drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +-
2 files changed, 2 insertio
On Tue, Feb 12, 2019 at 06:51:01PM +0800, Xin Long wrote:
> In sctp_stream_init(), after sctp_stream_outq_migrate() freed the
> surplus streams' ext, but sctp_stream_alloc_out() returns -ENOMEM,
> stream->outcnt will not be set to 'outcnt'.
>
> With the bigger value on stream->outcnt, when closing
From: Yang Wei
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 +-
drivers/net/ethernet/atheros/atlx/atl1.c| 2 +-
2 files changed, 2 insert
From: Yang Wei
dev_consume_skb_irq() should be called in mace_interrupt() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/apple/mace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/eth
From: Yang Wei
dev_consume_skb_irq() should be called in emac_mac_tx_process() when
skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/qualcomm/emac/emac-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Yang Wei
dev_consume_skb_irq() should be called in moxart_tx_finished() when
skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/moxa/moxart_ether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
From: Yang Wei
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/sis/sis190.c | 2 +-
drivers/net/ethernet/sis/sis900.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
dif
From: Yang Wei
dev_consume_skb_irq() should be called in at91ether_interrupt() when
skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
From: Yang Wei
dev_consume_skb_irq() should be called in eth_txdone_irq() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
From: Colin Ian King
There are some statements in an if-block that are not correctly
indented. Fix these.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/qlogic/qed/qed_cxt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed
> -Original Message-
> From: Sergei Shtylyov
> Sent: Tuesday, February 12, 2019 3:01 AM
> To: Parav Pandit ; Jiri Pirko ;
> da...@davemloft.net; netdev@vger.kernel.org
> Subject: Re: [PATCH net-next 2/2] devlink: Fix list access without lock while
> reading region
>
> Hello!
>
> On 12.
On Tue, Feb 12, 2019 at 06:51:01PM +0800, Xin Long wrote:
> In sctp_stream_init(), after sctp_stream_outq_migrate() freed the
> surplus streams' ext, but sctp_stream_alloc_out() returns -ENOMEM,
> stream->outcnt will not be set to 'outcnt'.
>
> With the bigger value on stream->outcnt, when closing
From: Colin Ian King
There are some statements that are indented incorrectly. Fix these.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c | 4 ++--
drivers/net/ethernet/qlogic/qlge/qlge_main.c| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff
On 02/12/2019 08:51 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> Commit c9b47cc1fabc ("xsk: fix bug when trying to use both copy and
> zero-copy on one queue id") stores the umem into the netdev._rx
> struct. However, the patch incorrectly removed the umem from the
> netdev._rx struct when user
On 02/12/2019 11:12 AM, Quentin Monnet wrote:
> 2019-02-12 10:25 UTC+0900 ~ Prashant Bhole
>> This patch adds missing information about feature-subcommand in
>> bpftool.rst
>>
>> Signed-off-by: Prashant Bhole
>> ---
>>
>> v2: used tabs instead of spaces
>
> Thanks a lot!
>
> Reviewed-by: Quenti
On 02/12/2019 09:20 AM, Jakub Kicinski wrote:
> Currently bpf_offload_dev does not have any priv pointer, forcing
> the drivers to work backwards from the netdev in program metadata.
> This is not great given programs are conceptually associated with
> the offload device, and it means one or two un
On Tue, Feb 12, 2019 at 06:47:30PM +0800, Xin Long wrote:
> Jianlin reported a panic when running sctp gso over gre over vlan device:
>
> [ 84.772930] RIP: 0010:do_csum+0x6d/0x170
> [ 84.790605] Call Trace:
> [ 84.791054] csum_partial+0xd/0x20
> [ 84.791657] gre_gso_segment+0x2c3
From: Yang Wei
dev_consume_skb_irq() should be called in intr_handler() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei
---
drivers/net/ethernet/fealnx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/
As there is restriction to access to EMAC System Manager registers in
the kernel for Intel Stratix10, the use of SMC calls are required and
added in dwmac-socfpga driver.
Signed-off-by: Ooi, Joyce
---
.../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 101
1 files changed
From: Nir Dotan
The LAG port collecting (receive) function was mistakenly set when the
port was registered as a LAG member, while it should be set only when
the port collection state is set to true. Set LAG port to collecting
when it is set to distributing, as described in the IEEE link
aggregati
From: Jiri Pirko
Don't source lib.sh 2 times and make the script work with ifnames
passed on the command line.
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
.../selftests/drivers/net/mlxsw/spectrum/resource_scale.sh | 1 -
1 file changed, 1 deletion(-)
diff --git
a/tools/t
In case the register access failed an error would be logged anyway, so
we can drop the warning.
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mel
Patches #1-#3 contain misc updates for the mlxsw driver, one of which is
a fix following recent introduction of flow_rule infrastructure.
Patch #4 avoids double sourcing of lib.sh in forwarding selftests.
Ido Schimmel (2):
mlxsw: spectrum_router: Drop unnecessary WARN_ON_ONCE()
mlxsw: spectru
On Tue, Feb 12, 2019 at 07:51:05AM +0100, Heiner Kallweit wrote:
> On 12.02.2019 04:58, Andrew Lunn wrote:
> > That change means we don't check the PHY device if it caused an
> > interrupt when its state is less than UP.
> >
> > What i'm seeing is that the PHY is interrupting pretty early on after
The driver does not support VLAN push and pop, but only VLAN modify.
Fixes: 738678817573 ("drivers: net: use flow action infrastructure")
Signed-off-by: Ido Schimmel
Acked-by: Jiri Pirko
Cc: Pablo Neira Ayuso
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 3 +--
1 file changed, 1
From: Jakub Kicinski
Date: Tue, 12 Feb 2019 00:18:02 -0800
> Recent cls_flower offload rewrite added a double new line.
>
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Quentin Monnet
Applied.
From: Johannes Berg
Date: Tue, 12 Feb 2019 12:51:20 +0100
> We have few more fixes, mostly one-liners; two are bigger:
> * the speculation one, only because the function had multiple
>return points and that had to change, and
> * the peer measurement locking one, because I had to refactor
>
From: Bert Kenward
Date: Tue, 12 Feb 2019 13:10:00 +
> The bitmap of found partitions in efx_ef10_mtd_probe was not
> initialised, causing partitions to be suppressed based off whatever
> value was in the bitmap at the start.
>
> Fixes: 3366463513f5 ("sfc: suppress duplicate nvmem partition
This 2 patches consist of fixes for devlink region read handling.
Signed-off-by: Parav Pandit
---
Parav Pandit (2):
devlink: Return right error code in case of errors for region read
devlink: Fix list access without lock while reading region
net/core/devlink.c | 29 +---
devlink_nl_cmd_region_read_dumpit() misses to return right error code on
most error conditions.
Return the right error code on such errors.
Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read command")
Signed-off-by: Parav Pandit
Acked-by: Jiri Pirko
---
net/core/devlink.c | 22
While finding the devlink device during region reading,
devlink device list is accessed and devlink device is
returned without holding a lock. This could lead to use-after-free
accesses.
While at it, add lockdep assert to ensure that all future callers hold
the lock when calling devlink_get_from_a
1 - 100 of 404 matches
Mail list logo
