On Mon, Feb 11, 2019 at 12:45:54PM -0800, David Miller wrote:
> From: Sean Tranchetti <stran...@codeaurora.org>
> Date: Thu,  7 Feb 2019 13:33:21 -0700
> 
> > Attempting to avoid cloning the skb when broadcasting by inflating
> > the refcount with sock_hold/sock_put while under RCU lock is dangerous
> > and violates RCU principles. It leads to subtle race conditions when
> > attempting to free the SKB, as we may reference sockets that have
> > already been freed by the stack.
>  ...
> > Suggested-by: Eric Dumazet <eric.duma...@gmail.com>
> > Signed-off-by: Sean Tranchetti <stran...@codeaurora.org>
> > ---
> > Realized I never actually sent this patch out after testing the changes
> > Eric recommended. Whoops. Better late then never, I suppose...
> 
> Steffen, I assume you will review and pick this up.

I was not on Cc and overlooked it at the list.
Thanks for the pointer!

Now applied to the ipsec tree, thanks Sean!

Reply via email to