> -----Original Message-----
> From: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
> Sent: Tuesday, February 12, 2019 3:01 AM
> To: Parav Pandit <pa...@mellanox.com>; Jiri Pirko <j...@mellanox.com>;
> da...@davemloft.net; netdev@vger.kernel.org
> Subject: Re: [PATCH net-next 2/2] devlink: Fix list access without lock while
> reading region
>
> Hello!
>
> On 12.02.2019 10:09, Parav Pandit wrote:
>
> > While finding the devlink device during region reading, devlink device
> > list is accessed and devlink device is returned without holding a
> > lock. This could lead to user-after-free
>
> Use-after-free, perhaps?
>
Yep. Sending v1 to fix typo.
> > accesses.
> >
> > While at it, add lockdep assert to ensure that all future callers hold
> > the lock when calling devlink_get_from_attrs().
> >
> > Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read
> > command")
> > Signed-off-by: Parav Pandit <pa...@mellanox.com>
> > Acked-by: Jiri Pirko <j...@mellanox.com>
> [...]
>
> MBR, Sergei
