[net-next,v2] openvswitch: add macro MODULE_ALIAS_VPORT_TYPE for vport type alias

2017-06-13 Thread Zhang Shengju
Add a new macro MODULE_ALIAS_VPORT_TYPE to unify and simplify the declaration of vport type alias. Signed-off-by: Zhang Shengju --- net/openvswitch/vport-geneve.c | 2 +- net/openvswitch/vport-gre.c| 2 +- net/openvswitch/vport-vxlan.c | 2 +- net/openvswitch/vport.h| 3 +++ 4 files

Re: [wireless-next] qtnfmac: check band before allocating cmd_skb to avoid resource leak

2017-06-13 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The current code allocates cmd_skb and then will leak this if band->band > is an illegal value. It is simpler to sanity check the band first before > allocating cmd_skb so that we don't have to free cmd_skb if an invalid > band occurs. > > Detec

Re: [-next] mwifiex: make function mwifiex_ret_pkt_aggr_ctrl static

2017-06-13 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > function mwifiex_ret_pkt_aggr_ctrl can be made static as it does not > need to be in global scope. > > Cleans up sparse warning: "symbol 'mwifiex_ret_pkt_aggr_ctrl' was not > declared. Should it be static?" > > Signed-off-by: Colin Ian King P

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-13 Thread Kalle Valo
Caesar Wang writes: > Kalle, > > 在 2017年06月13日 14:28, Kalle Valo 写道: >> Caesar Wang writes: >> >>> We have always met the unused log be printed as following. >>> >>> ... >>> [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: >>> cannot find cfp by band 2& channel=13 freq=0 >>> [23378

Re: mwifiex: Replace semaphore async_sem with mutex

2017-06-13 Thread Kalle Valo
Binoy Jayan wrote: > The semaphore 'async_sem' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan > Reviewed-by: Arnd Bergmann Patch applied to wireless-drivers-next.git, thanks. 1abf9ae719f6 mwifiex: Replace s

Re: [PATCHv5] wlcore: add wl1285 compatible

2017-06-13 Thread Kalle Valo
Sebastian Reichel wrote: > Motorola Droid 4 uses a WL 1285C. With differences between > chips not being public let's add explicit binding for wl1285 > instead of relying on wl1283 being very similar. > > Reviewed-by: Rob Herring > Acked-by: Kalle Valo > Acked-by: Tony Lindgren > Signed-off-by

Re: wlcore: spi: remove unnecessary variable

2017-06-13 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Remove unnecessary variable and refactor the code. > > Addresses-Coverity-ID: 1365000 > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. c48c281e7236 wlcore: spi: remove unnecessary variable -- https://patchwork.kernel.org

[PATCH v3] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-13 Thread Yuval Shaia
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia Acked-by: Sergei Shtylyov --- v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/renesas/ravb_main.c * drivers/net/ethernet/renesas/sh_eth.c

[PATCH net-next v2 2/2] r8152: move calling delay_autosuspend function

2017-06-13 Thread Hayes Wang
Move calling delay_autosuspend() in rtl8152_runtime_suspend(). Calling delay_autosuspend() as late as possible. The original flows are 1. check if the driver/device is busy now. 2. set wake events. 3. enter runtime suspend. If the wake event occurs between (1) and (2), the device may mis

[PATCH net-next v2 1/2] r8152: split rtl8152_resume function

2017-06-13 Thread Hayes Wang
Split rtl8152_resume() into rtl8152_runtime_resume() and rtl8152_system_resume(). Besides, replace GFP_KERNEL with GFP_NOIO for usb_submit_urb(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 99 ++--- 1 file changed, 61 insertions(+), 38 de

[PATCH net-next v2 0/2] r8152: adjust runtime suspend/resume

2017-06-13 Thread Hayes Wang
v2: For #1, replace GFP_KERNEL with GFP_NOIO for usb_submit_urb(). v1: Improve the flow about runtime suspend/resume and make the code easy to read. Hayes Wang (2): r8152: split rtl8152_resume function r8152: move calling delay_autosuspend function drivers/net/usb/r8152.c | 107

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-13 Thread Caesar Wang
在 2017年06月13日 15:04, Kalle Valo 写道: Caesar Wang writes: Kalle, 在 2017年06月13日 14:28, Kalle Valo 写道: Caesar Wang writes: We have always met the unused log be printed as following. ... [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: cannot find cfp by band 2& channel=13 freq=

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-13 Thread Kalle Valo
Caesar Wang writes: > 在 2017年06月13日 15:04, Kalle Valo 写道: >> Caesar Wang writes: >> >>> Kalle, >>> >>> 在 2017年06月13日 14:28, Kalle Valo 写道: Caesar Wang writes: > We have always met the unused log be printed as following. > > ... > [23193.523182] mwifiex_pcie :01:00.

[PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Haishuang Yan
Same as ip_gre, geneve and vxlan, use key->tos as tos value. Signed-off-by: Haishuang Yan --- net/ipv6/ip6_tunnel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index ef99d59..5f4aff5 100644 --- a/net/ipv6/ip6_tunnel.c +++

Re: [Patch net] igmp: acquire pmc lock for ip_mc_clear_src()

2017-06-13 Thread Xin Long
On Tue, Jun 13, 2017 at 2:35 AM, Cong Wang wrote: > On Mon, Jun 12, 2017 at 11:30 AM, Xin Long wrote: >> Hi, Cong. >> >> how about in ip_check_mc_rcu(): >> for (psf = im->sources; psf; psf = psf->sf_next) { >>if (psf->sf_inaddr == src_addr) >>br

Re: [net-next] net: phy: marvell: Show complete link partner advertising

2017-06-13 Thread Tom Bogendoerfer
On Mon, Jun 12, 2017 at 09:05:04AM -0700, Florian Fainelli wrote: > On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > > From: Thomas Bogendoerfer > > > > Give back all modes advertised by the link partner. This change brings > > the marvell phy driver in line with all other phy drivers. > > >

Re: stmmac tx timeout

2017-06-13 Thread Pavel Machek
Hi! > > @@ -2043,7 +2063,11 @@ static netdev_tx_t stmmac_xmit(struct sk_buff > > *skb, stru\ > > ct net_device *dev) > > } else > > priv->tx_count_frames = 0; > > > > + dma_rmb(); > > + dma_wmb(); > > /* To avoid raise condition */ > > + BUG_O

Re: [PATCH v1] net: rfkill: gpio: Switch to devm_acpi_dev_add_driver_gpios()

2017-06-13 Thread Johannes Berg
On Sat, 2017-06-10 at 22:10 +0300, Andy Shevchenko wrote: > Switch to use managed variant of acpi_dev_add_driver_gpios() to > simplify > error path and fix potentially wrong assingment if ->probe() fails. > Looks fine, applied. johannes

[PATCH net] qed: fix dump of context data

2017-06-13 Thread Tomer Tayar
Currently when dumping a context data only word number '1' is read for the entire context. Fixes: c965db444629 ("qed: Add support for debug data collection") Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH 1/2] mdio_bus: handle only single PHY reset GPIO

2017-06-13 Thread Sergei Shtylyov
Hello! On 6/13/2017 2:43 AM, Florian Fainelli wrote: Subject should be: net: phy: Handle only single PHY reset GPIO to be consistent with prior submissions, With what exactly previous submissions? I'm seeing all kinds of prefixes for drivers/net/phy/mdio_bus.c, mine matched Roger's one (a

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Matthias May
On 12/06/17 15:22, Mason wrote: > Hello, > > I am using the following drivers for Ethernet connectivity. > drivers/net/ethernet/aurora/nb8800.c > drivers/net/phy/at803x.c > > Pulling the cable and plugging it back works as expected. > (I can ping both before and after.) > > However, if I toggle

pull-request: mac80211 2017-06-13

2017-06-13 Thread Johannes Berg
Hi Dave, Here are some more fixes for the current cycle. Nothing really big, though my own patches look bigger than they are due to some code moving. The commit logs are far longer than the changes :-) Please pull and let me know if there's any problem. Thanks, johannes The following changes

Re: [PATCH] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-13 Thread 严海双
> On 13 Jun 2017, at 4:56 PM, Haishuang Yan > wrote: > > When __ip6_tnl_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > CC: Alexei Starovoitov > Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") > Signed-off-by: Haishuang Y

Re: Re: [PATCH] mwifiex: fixes the trivial print

2017-06-13 Thread Xinming Hu
Hi Caesar, The original log in google issue tracker show there exist AP in channel 13 after periodically scan. Per my understand, if reg domain is set to US, channel 12/13/14 will not get chance to scan. (test using iw/wpa_supplicant). I am curious about whether there are any diff from upper l

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Daniel Borkmann
On 06/13/2017 09:55 AM, Haishuang Yan wrote: Same as ip_gre, geneve and vxlan, use key->tos as tos value. Please also add Fixes tag and Cc original authors. Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets") Signed-off-by: Haishuang Yan --- net/ipv6

Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

2017-06-13 Thread Enric Balletbo Serra
Hello Kalle, 2017-06-13 7:54 GMT+02:00 Kalle Valo : > Enric Balletbo i Serra wrote: > >> When request firmware fails, brcmf_ops_sdio_remove is being called and >> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle >> the kernel hangs on resume due a NULL pointer dereference

Re: [PATCH 0/2] MDIO bus reset GPIO cleanups

2017-06-13 Thread Sergei Shtylyov
On 6/12/2017 11:55 PM, Sergei Shtylyov wrote: Commit 4c5e7a2c0501 ("dt-bindings: mdio: Clarify binding document") declared that a MDIO reset GPIO property should have only a single GPIO reference/specifier, however the supporting code was left intact... Here's a couple of the obvious cleanups to

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-13 Thread Jamal Hadi Salim
On 17-06-13 01:32 AM, Jiri Pirko wrote: Mon, Jun 12, 2017 at 09:58:33PM CEST, dsah...@gmail.com wrote: On 6/12/17 1:22 PM, Jiri Pirko wrote: 3. IMO since these are nla prefixes and new NLA type they should be in uapi/linux/netlink.h Including NLA_* type enum? I think it is reasonable. well

Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

2017-06-13 Thread Arend van Spriel
On 13-06-17 12:23, Enric Balletbo Serra wrote: > Hello Kalle, > > 2017-06-13 7:54 GMT+02:00 Kalle Valo : >> Enric Balletbo i Serra wrote: >> >>> When request firmware fails, brcmf_ops_sdio_remove is being called and >>> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle >>>

linux-next: build warning after merge of the net tree

2017-06-13 Thread Stephen Rothwell
Hi all, After merging the net tree, today's linux-next build (powerpc ppc44x_defconfig) produced this warning: net/core/dev.c: In function 'dev_cpu_dead': net/core/dev.c:8330:2: warning: 'remsd' is used uninitialized in this function [-Wuninitialized] net_rps_send_ipi(remsd); ^ Introduced b

[PATCH 2/2] batman-adv: fix memory leak when dropping packet from other gateway

2017-06-13 Thread Simon Wunderlich
From: Andreas Pape The skb must be released in the receive handler since b91a2543b4c1 ("batman-adv: Consume skb in receive handlers"). Just returning NET_RX_DROP will no longer automatically free the memory. This results in memory leaks when unicast packets from other backbones must be dropped be

[PATCH 0/2] pull request for net: batman-adv 2017-06-13

2017-06-13 Thread Simon Wunderlich
://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20170613 for you to fetch changes up to a1a745ef980a1b48299ead4ea7990e62c0516f6e: batman-adv: fix memory leak when dropping packet from other gateway (2017-05-19 12:20:28 +0200

[PATCH 1/2] batman-adv: Fix rx packet/bytes stats on local ARP reply

2017-06-13 Thread Simon Wunderlich
From: Sven Eckelmann The stats are generated by batadv_interface_stats and must not be stored directly in the net_device stats member variable. The batadv_priv bat_counters information is assembled when ndo_get_stats is called. The stats previously stored in net_device::stats is then overwritten.

[PATCH] net: rps: fix uninitialized symbol warning

2017-06-13 Thread Ashwanth Goli
This patch fixes uninitialized symbol warning that got introduced by the following commit 773fc8f6e8d6 ("net: rps: send out pending IPI's on CPU hotplug") Signed-off-by: Ashwanth Goli --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-13 Thread Jiri Pirko
Tue, Jun 13, 2017 at 12:53:00PM CEST, j...@mojatatu.com wrote: >On 17-06-13 01:32 AM, Jiri Pirko wrote: >> Mon, Jun 12, 2017 at 09:58:33PM CEST, dsah...@gmail.com wrote: >> > On 6/12/17 1:22 PM, Jiri Pirko wrote: >> > > >> > > > 3. IMO since these are nla prefixes and new NLA type they should be i

kernel BUG at net/ipv4/tcp_output.c:2748!

2017-06-13 Thread Dison River
Hi I've got the following error report while fuzzing the kernel on linux-4.11.0-rc3.

Re: linux-next: build warning after merge of the net tree

2017-06-13 Thread Ashwanth Goli
Hi Stephen, On 2017-06-13 16:38, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (powerpc ppc44x_defconfig) produced this warning: net/core/dev.c: In function 'dev_cpu_dead': net/core/dev.c:8330:2: warning: 'remsd' is used uninitialized in this function [-W

Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

2017-06-13 Thread Jamal Hadi Salim
On 17-06-12 08:34 PM, Lorenzo Colitti wrote: On Sun, Jun 11, 2017 at 8:58 PM, Jamal Hadi Salim wrote: Maybe this should both be "inet_request_mark()"? As David says, the tcp_fwmark_accept sysctl is not really appropriate for synack packets - what it does is ensure that when a connection is a

[PATCH 04/10] batman-adv: Combine two seq_puts() calls into one call in batadv_nc_nodes_seq_print_text()

2017-06-13 Thread Simon Wunderlich
From: Markus Elfring A bit of text was put into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderli

[PATCH 02/10] batman-adv: decrease maximum fragment size

2017-06-13 Thread Simon Wunderlich
From: Matthias Schiffer With this patch the maximum fragment size is reduced from 1400 to 1280 bytes. Fragmentation v2 correctly uses the smaller of 1400 and the interface MTU, thus generally supporting interfaces with an MTU < 1400 bytes, too. However, currently "Fragmentation v2" does not sup

[PATCH 00/10] pull request for net-next: batman-adv 2017-06-13

2017-06-13 Thread Simon Wunderlich
the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20170613 for you to fetch changes up to d62890885efbc48acea46964ea3af69b61c8c5eb: batman-adv: Accept only filled wifi station info (2017-06-13 12:25:43 +0200

[PATCH 08/10] batman-adv: simplify return handling in some TT functions

2017-06-13 Thread Simon Wunderlich
Signed-off-by: Simon Wunderlich Signed-off-by: Sven Eckelmann --- net/batman-adv/translation-table.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 4b64a9a633d9..e1133bc634b5 10

[PATCH 07/10] batman-adv: do not add loop detection mac addresses to global tt

2017-06-13 Thread Simon Wunderlich
This change has been made for local TT already, add another one for global TT - but only for temporary entries (aka speedy join), to prevent inconsistencies between local and global tables in case an older batman-adv version is still announcing those entries from its local table. Signed-off-by: Si

[PATCH 09/10] batman-adv: Use default throughput value on cfg80211 error

2017-06-13 Thread Simon Wunderlich
From: Sven Eckelmann A wifi interface should never be handled like an ethernet devices. The parser of the cfg80211 output must therefore skip the ethtool code when cfg80211_get_station returned an error. Fixes: f44a3ae9a281 ("batman-adv: refactor wifi interface detection") Signed-off-by: Sven Ec

[PATCH 10/10] batman-adv: Accept only filled wifi station info

2017-06-13 Thread Simon Wunderlich
From: Sven Eckelmann The wifi driver can decide to not provide parts of the station info. For example, the expected throughput of the station can be omitted when the used rate control doesn't provide this kind of information. The B.A.T.M.A.N. V implementation must therefore check the filled bitf

[PATCH 05/10] batman-adv: Print correct function names in dbg messages

2017-06-13 Thread Simon Wunderlich
From: Sven Eckelmann The function names in batman-adv changed slightly in the past. But some of the debug messages were not updated correctly and therefore some messages were incorrect. To avoid this in the future, these kind of messages should use __func__ to automatically print the correct func

[PATCH 03/10] batman-adv: Replace a seq_puts() call by seq_putc() in two functions

2017-06-13 Thread Simon Wunderlich
From: Markus Elfring Two single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- n

[PATCH 06/10] batman-adv: tp_meter: mark init function with __init

2017-06-13 Thread Simon Wunderlich
From: Antonio Quartulli batadv_tp_meter_init() is invoked in batadv_init() only which is marked with __init. For this reason batadv_tp_meter_init() can be marked with __init as well and dropped after module load. Signed-off-by: Antonio Quartulli Signed-off-by: Sven Eckelmann Signed-off-by: Si

[PATCH 01/10] batman-adv: Start new development cycle

2017-06-13 Thread Simon Wunderlich
Signed-off-by: Simon Wunderlich --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 810f7d026f54..feaf60e4cbc3 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -24,7 +24,7 @@ #define BA

pull-request: mac80211-next 2017-06-13

2017-06-13 Thread Johannes Berg
Hi Dave, Looks like I haven't sent you anything for a long time, so here we go. There isn't a ton of things, but in particular the 4-way- handshake offload has been a long time in the making. I'll send you the conversion for more skb_put_zero() users in a separate patch after this. Please pull a

[PATCH net-next] networking: use skb_put_zero()

2017-06-13 Thread Johannes Berg
From: Johannes Berg Use the recently introduced helper to replace the pattern of skb_put() && memset(), this transformation was done with the following spatch: @@ identifier p; expression len; expression skb; @@ -p = skb_put(skb, len); -memset(p, 0, len); +p = skb_put_zero(skb, len); Signed-off

Re: [PATCH 01/44] firmware/ivc: use dma_mapping_error

2017-06-13 Thread Thierry Reding
On Thu, Jun 08, 2017 at 03:25:26PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is not supposed to be used by drivers. > > Signed-off-by: Christoph Hellwig > --- > drivers/firmware/tegra/ivc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Thierry Reding signature.

[net-next] fjes: remove duplicate set of flag IFF_BROADCAST

2017-06-13 Thread Zhang Shengju
Remove unnecessary set of flag IFF_BROADCAST, since ether_setup already does this. Signed-off-by: Zhang Shengju --- drivers/net/fjes/fjes_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index ae48c80..b56e07f 100644 --- a/driv

Re: kernel BUG at net/ipv4/tcp_output.c:2748!

2017-06-13 Thread Greg KH
On Tue, Jun 13, 2017 at 07:39:00PM +0800, Dison River wrote: > Hi >I've got the following error report while fuzzing the kernel with > syzkaller on > linux-4.11.0-rc3. 4.11-rc3 is pretty old now, can you try 4.12-rc4 for this? thanks, greg k-h

[PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread Colin King
From: Colin Ian King The guid hns_dsaf_acpi_dsm_guid does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be static?" Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c

[PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

2017-06-13 Thread Jesper Dangaard Brouer
The selftests depend on using the shell exit code as a mean of detecting the success or failure of test-binary executed. The appropiate output "[PASS]" or "[FAIL]" in generated by tools/testing/selftests/lib.mk. Notice that the exit code is masked with 255. Thus, be careful if using the number of

Re: [PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

2017-06-13 Thread Daniel Borkmann
On 06/13/2017 03:17 PM, Jesper Dangaard Brouer wrote: The selftests depend on using the shell exit code as a mean of detecting the success or failure of test-binary executed. The appropiate output "[PASS]" or "[FAIL]" in generated by tools/testing/selftests/lib.mk. Notice that the exit code is

[PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread Michael Dilmore
The packets per slave parameter used by round robin mode does not have a printk debug message in its set function in bond_options.c. Adding such a function would aid debugging of round-robin mode and allow the user to more easily verify that the parameter has been set correctly. I should add tha

Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

2017-06-13 Thread Lorenzo Colitti
On Sat, Jun 10, 2017 at 10:31 PM, Jamal Hadi Salim wrote: > skb->priority = sk->sk_priority; > - skb->mark = sk->sk_mark; > + if (!skb->mark) > + skb->mark = sk->sk_mark; It looks a bit iffy to take sk->sk_mark only if skb->mark is zero instead of relying on the

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-13 Thread David Ahern
On 6/13/17 5:25 AM, Jiri Pirko wrote: > >> Do you or David A. want to take a crack at this? I am a little tied >> up. > No time right now. Maybe in July I could allocate some cycles for this. I'll see what I can do this weekend.

Re: [PATCH net-next] selftests/bpf: make correct use of exit codes in bpf selftests

2017-06-13 Thread Fengguang Wu
On Tue, Jun 13, 2017 at 03:17:19PM +0200, Jesper Dangaard Brouer wrote: The selftests depend on using the shell exit code as a mean of detecting the success or failure of test-binary executed. The appropiate output "[PASS]" or "[FAIL]" in generated by tools/testing/selftests/lib.mk. Notice that

Re: [PATCH][netdev-next] net: hns: make guid hns_dsaf_acpi_dsm_guid static

2017-06-13 Thread Andy Shevchenko
On Tue, 2017-06-13 at 14:03 +0100, Colin King wrote: > From: Colin Ian King > > The guid hns_dsaf_acpi_dsm_guid does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'hns_dsaf_acpi_dsm_guid' was not declared. Should it be > static?" Reviewed-by: Andy

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Mason
On 13/06/2017 11:39, Matthias May wrote: > On 12/06/17 15:22, Mason wrote: >> Hello, >> >> I am using the following drivers for Ethernet connectivity. >> drivers/net/ethernet/aurora/nb8800.c >> drivers/net/phy/at803x.c >> >> Pulling the cable and plugging it back works as expected. >> (I can ping b

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Matthias May
On 13/06/17 16:20, Mason wrote: > On 13/06/2017 11:39, Matthias May wrote: >> On 12/06/17 15:22, Mason wrote: >>> Hello, >>> >>> I am using the following drivers for Ethernet connectivity. >>> drivers/net/ethernet/aurora/nb8800.c >>> drivers/net/phy/at803x.c >>> >>> Pulling the cable and plugging i

[net-next] macvlan: propagate the mac address change status for lowerdev

2017-06-13 Thread Zhang Shengju
The macvlan dev should propagate the return value of mac address change for lower device in the passthru mode, instead of always return 0. Signed-off-by: Zhang Shengju --- drivers/net/macvlan.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/driv

[PATCH net-next] of_mdio: move of_mdio_parse_addr to header file

2017-06-13 Thread Jon Mason
The of_mdio_parse_addr() helper function is useful to other code, but the module dependency chain causes issues. To work around this, we can move of_mdio_parse_addr() to be an inline function in the header file. This gets rid of the dependencies and still allows for the reuse of code. Reported-by

[PATCH net-next 2/2] pktgen: Specify the index of first thread

2017-06-13 Thread Tariq Toukan
Use "-f ", to specify the index of the first sender thread. In default first thread is #0. Signed-off-by: Tariq Toukan Cc: Jesper Dangaard Brouer --- samples/pktgen/README.rst | 1 + samples/pktgen/parameters.sh | 19 ++- ...

[PATCH net-next 1/2] pktgen: Specify num packets per thread

2017-06-13 Thread Tariq Toukan
Use -n , to specify the number of packets every thread sends. Zero means indefinitely. Signed-off-by: Tariq Toukan Cc: Jesper Dangaard Brouer --- samples/pktgen/README.rst | 1 + samples/pktgen/parameters.sh | 7 ++- samples/pktgen/pktg

[PATCH net-next 0/2] pktgen new parameters

2017-06-13 Thread Tariq Toukan
Hi Dave, This patchset adds two parameters to the pktgen scripts. * The first patch adds a parameter to control the number of packets sent by every pktgen thread. * The second patch adds a parameter to control the index of first thread, instead of always starting from cpu 0. Series generated

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Mason
On 12/06/2017 18:38, Florian Fainelli wrote: > On 06/12/2017 06:22 AM, Mason wrote: > >> I am using the following drivers for Ethernet connectivity. >> drivers/net/ethernet/aurora/nb8800.c >> drivers/net/phy/at803x.c >> >> Pulling the cable and plugging it back works as expected. >> (I can ping bo

Re: [PATCH net-next 00/13] net: dsa: mv88e6xxx: port macros cosmetics

2017-06-13 Thread David Miller
From: Vivien Didelot Date: Mon, 12 Jun 2017 12:37:32 -0400 > This patch series brings no functional changes. > > It prefixes all common port registers macros with MV88E6XXX_PORT. > If registers or some bits differs between switch models, a reference > model is chosen (e.g. MV88E6390_PORT_MAC_CTL

Re: [PATCH] net: rps: fix uninitialized symbol warning

2017-06-13 Thread David Miller
From: Ashwanth Goli Date: Tue, 13 Jun 2017 16:54:55 +0530 > This patch fixes uninitialized symbol warning that > got introduced by the following commit > 773fc8f6e8d6 ("net: rps: send out pending IPI's on CPU hotplug") > > Signed-off-by: Ashwanth Goli Applied.

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Mason
On 13/06/2017 17:07, Mason wrote: > I did note something that seems important. > > If I toggle the link state in software, then connectivity breaks. > > If I unplug the ethernet cable, and replug, connectivity remains. > > The difference is that plugging/unplugging doesn't call the > .ndo_stop

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread David Miller
From: Michael Dilmore Date: Tue, 13 Jun 2017 14:42:46 +0100 > The packets per slave parameter used by round robin mode does not have a > printk debug > message in its set function in bond_options.c. Adding such a function would > aid debugging > of round-robin mode and allow the user to more ea

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Florian Fainelli
On 06/13/2017 08:07 AM, Mason wrote:> I did note something that seems important. > > If I toggle the link state in software, then connectivity breaks. > > If I unplug the ethernet cable, and replug, connectivity remains. What does that actually mean? If you disconnect the cable a link state sh

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Daniel Borkmann
On 06/13/2017 03:31 PM, 严海双 wrote: On 13 Jun 2017, at 5:57 PM, Daniel Borkmann wrote: On 06/13/2017 09:55 AM, Haishuang Yan wrote: Same as ip_gre, geneve and vxlan, use key->tos as tos value. Please also add Fixes tag and Cc original authors. Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix se

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Mason
On 13/06/2017 17:36, Florian Fainelli wrote: > On 06/13/2017 08:07 AM, Mason wrote: > >> I did note something that seems important. >> If I toggle the link state in software, then connectivity breaks. >> If I unplug the ethernet cable, and replug, connectivity remains. > > What does that actually

Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies

2017-06-13 Thread Randy Dunlap
On 06/12/17 17:18, Florian Fainelli wrote: > After commit 90eff9096c01 ("net: phy: Allow splitting MDIO > bus/device support from PHYs") we could create a configuration where > MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined > references: > > drivers/built-in.o: In function `thu

Re: Toggling link state breaks network connectivity

2017-06-13 Thread Florian Fainelli
On 06/13/2017 08:47 AM, Mason wrote: > On 13/06/2017 17:36, Florian Fainelli wrote: > >> On 06/13/2017 08:07 AM, Mason wrote: >> >>> I did note something that seems important. >>> If I toggle the link state in software, then connectivity breaks. >>> If I unplug the ethernet cable, and replug, co

Re: [net-next] macvlan: propagate the mac address change status for lowerdev

2017-06-13 Thread Sergei Shtylyov
Hello! On 06/13/2017 05:45 PM, Zhang Shengju wrote: The macvlan dev should propagate the return value of mac address change for lower device in the passthru mode, instead of always return 0. Returning. Perhaps can be fixed while applying... Signed-off-by: Zhang Shengju [...] MBR,Serge

Re: [net-next] fjes: remove duplicate set of flag IFF_BROADCAST

2017-06-13 Thread Sergei Shtylyov
Hello! On 06/13/2017 03:49 PM, Zhang Shengju wrote: Remove unnecessary set of flag IFF_BROADCAST, since ether_setup s/set/setting/. Perhaps can be fixed while applying... already does this. Signed-off-by: Zhang Shengju [...] MBR, Sergei

Re: [PATCH net-next 03/10] bpf: mlx5e: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-13 Thread Saeed Mahameed
On Tue, Jun 13, 2017 at 4:00 AM, Martin KaFai Lau wrote: > Add support to mlx5e to report bpf_prog ID during XDP_QUERY_PROG. > > Signed-off-by: Martin KaFai Lau > Cc: Tariq Toukan > Cc: Saeed Mahameed > Acked-by: Alexei Starovoitov > Acked-by: Daniel Borkmann Acked-by: Saeed Mahameed Thank

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-13 Thread Saeed Mahameed
On Mon, Jun 12, 2017 at 7:17 PM, Jason Gunthorpe wrote: > On Sat, Jun 10, 2017 at 02:11:13PM +, Majd Dibbiny wrote: > >> >> This is especially true for mlx nics as there are many raw packet >> >> bypass mechanisms available to userspace. > >> All of the Raw packet bypass mechanisms are restric

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread Joe Perches
On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: > From: Michael Dilmore > Date: Tue, 13 Jun 2017 14:42:46 +0100 > > > The packets per slave parameter used by round robin mode does not have a > > printk debug > > message in its set function in bond_options.c. Adding such a function would

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-06-13 Thread Cong Wang
On Mon, Jun 12, 2017 at 11:16 PM, Florian Westphal wrote: > Cong Wang wrote: >> On Thu, Jun 1, 2017 at 1:52 AM, Florian Westphal wrote: >> > Joe described it nicely, problem is that after unload we may have >> > conntracks that still have a nf_conn_help extension attached that >> > has a pointer

[PATCH] nfc: nci: remove unnecessary null check

2017-06-13 Thread Gustavo A. R. Silva
Remove unnecessary NULL check for pointer conn_info. conn_info is set in list_for_each_entry() using container_of(), which is never NULL. Addresses-Coverity-ID: 1362349 Cc: Guenter Roeck Signed-off-by: Gustavo A. R. Silva --- net/nfc/nci/core.c | 9 - 1 file changed, 4 insertions(+), 5

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread Jonathan Toppins
On 06/13/2017 12:21 PM, Joe Perches wrote: > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: >> From: Michael Dilmore >> Date: Tue, 13 Jun 2017 14:42:46 +0100 >> >>> The packets per slave parameter used by round robin mode does not have a >>> printk debug >>> message in its set function in

[PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

2017-06-13 Thread Mateusz Jurczyk
Verify that the caller-provided sockaddr structure is large enough to contain the sa_family field, before accessing it in bind() handlers of the AF_NFC socket. Since the syscall doesn't enforce a minimum size of the corresponding memory region, very short sockaddrs (zero or one byte long) result in

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread David Miller
From: Joe Perches Date: Tue, 13 Jun 2017 09:21:03 -0700 > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: >> From: Michael Dilmore >> Date: Tue, 13 Jun 2017 14:42:46 +0100 >> >> > The packets per slave parameter used by round robin mode does not have a >> > printk debug >> > message in

Re: [PATCH net-next] of_mdio: move of_mdio_parse_addr to header file

2017-06-13 Thread Florian Fainelli
On 06/13/2017 07:56 AM, Jon Mason wrote: > The of_mdio_parse_addr() helper function is useful to other code, but > the module dependency chain causes issues. To work around this, we can > move of_mdio_parse_addr() to be an inline function in the header file. > This gets rid of the dependencies and

Re: [PATCH] r8152: give the device version

2017-06-13 Thread David Miller
From: Oliver Neukum Date: Mon, 12 Jun 2017 13:56:51 +0200 > Getting the device version out of the driver really aids debugging. > > Signed-off-by: Oliver Neukum Applied.

Re: [PATCH net-next] net: mvpp2: enable basic 10G support

2017-06-13 Thread David Miller
From: Antoine Tenart Date: Mon, 12 Jun 2017 16:01:39 +0200 > On GOP port 0 two MAC modes are available: GMAC and XLG. The XLG MAC is > used for 10G connectivity. This patch adds a basic 10G support by > allowing to use the XLG MAC on port 0 and by reworking the > port_enable/disable functions so

Re: [PATCH net-next] ibmvnic: Client-initiated failover

2017-06-13 Thread David Miller
From: Thomas Falcon Date: Mon, 12 Jun 2017 12:35:04 -0500 > The IBM vNIC protocol provides support for the user to initiate > a failover from the client LPAR in case the current backing infrastructure > is deemed inadequate or in an error state. > > Support for two H_VIOCTL sub-commands for vNIC

Re: [PATCH net-next] ibmvnic: Remove netdev notify for failover resets

2017-06-13 Thread David Miller
From: Nathan Fontenot Date: Mon, 12 Jun 2017 20:47:45 -0400 > When handling a driver reset due to a failover of the backing > server on the vios, doing the netdev_notify_peers() can cause > network traffic to stall or halt. Remove the netdev notify call > for failover resets. > > Signed-off-by:

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread Joe Perches
On Tue, 2017-06-13 at 12:42 -0400, Jonathan Toppins wrote: > On 06/13/2017 12:21 PM, Joe Perches wrote: > > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: > > > From: Michael Dilmore > > > Date: Tue, 13 Jun 2017 14:42:46 +0100 > > > > > > > The packets per slave parameter used by round ro

Re: [PATCH 0/2] MDIO bus reset GPIO cleanups

2017-06-13 Thread David Miller
From: Sergei Shtylyov Date: Mon, 12 Jun 2017 23:55:37 +0300 > Commit 4c5e7a2c0501 ("dt-bindings: mdio: Clarify binding document") > declared that a MDIO reset GPIO property should have only a single GPIO > reference/specifier, however the supporting code was left intact... > Here's a couple of th

Re: [PATCH net] net: phy: Fix MDIO_THUNDER dependencies

2017-06-13 Thread David Miller
From: Florian Fainelli Date: Mon, 12 Jun 2017 17:18:51 -0700 > After commit 90eff9096c01 ("net: phy: Allow splitting MDIO > bus/device support from PHYs") we could create a configuration where > MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined > references: > > drivers/built-in

Re: [PATCH net-next v2 0/2] r8152: adjust runtime suspend/resume

2017-06-13 Thread David Miller
From: Hayes Wang Date: Tue, 13 Jun 2017 15:14:38 +0800 > v2: > For #1, replace GFP_KERNEL with GFP_NOIO for usb_submit_urb(). > > v1: > Improve the flow about runtime suspend/resume and make the code > easy to read. Series applied.

Re: [PATCH] netconsole: Remove duplicate "netconsole: " logging prefix

2017-06-13 Thread David Miller
From: Joe Perches Date: Mon, 12 Jun 2017 16:39:51 -0700 > It's already added by pr_fmt so remove the explicit use. > > Signed-off-by: Joe Perches Applied.

RE: [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-13 Thread Salil Mehta
Hi Yuval > -Original Message- > From: Mintz, Yuval [mailto:yuval.mi...@cavium.com] > Sent: Saturday, June 10, 2017 1:43 PM > To: Salil Mehta; da...@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.ke

  1   2   3   >