On Tue, 2017-06-13 at 12:42 -0400, Jonathan Toppins wrote: > On 06/13/2017 12:21 PM, Joe Perches wrote: > > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: > > > From: Michael Dilmore <michael.j.dilm...@gmail.com> > > > Date: Tue, 13 Jun 2017 14:42:46 +0100 > > > > > > > The packets per slave parameter used by round robin mode does not have > > > > a printk debug > > > > message in its set function in bond_options.c. Adding such a function > > > > would aid debugging > > > > of round-robin mode and allow the user to more easily verify that the > > > > parameter has been > > > > set correctly. I should add that I'm motivated by my own experience > > > > here - it's not > > > > obvious from output of tools such as wireshark and ifstat that the > > > > parameter is working > > > > correctly, and with the differences in bonding configuration across > > > > different distributions, > > > > it would have been comforting to see this output. [] > > > You can verify things by simplying reading the value back. > > > > > > If every parameter emitted a kernel log message, it would be > > > unreadable. > > > > > > I'm not applying this, sorry. > > > > I agree. Noisy logging output is not good. > > > > Perhaps a general conversion of the dozens > > of existing netdev_info uses in this file to > > netdev_dbg and adding this at netdev_dbg is > > appropriate. > > In general I agree. The few times I have debugged bonds, I always ended > up enabling debug prinks anyway. I don't see a problem moving these to > debug as well. > > Adding nik whom converted a lot of this code to common paths for input.
If Nikolay agrees with the conversion, it's trivial. Please submit it. I did it just for reference. Stylistic nits about the existing file: There are some inconsistencies in pr_info/pr_err uses with invalid inputs. It would also be nicer if the forward static declarations were removed and the static definitions reordered.
