Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 00:48:28 +0200 Linus Walleij wrote: > -static void rtl8366rb_adjust_link(struct dsa_switch *ds, int port, > - struct phy_device *phydev) > +void rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int > mode, > +

Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-06 Thread Russell King - ARM Linux admin
On Sat, Sep 05, 2020 at 06:56:45PM -0700, Florian Fainelli wrote: > +Russell, > > On 9/5/2020 3:48 PM, Linus Walleij wrote: > > This switches the RTL8366RB over to using phylink callbacks > > instead of .adjust_link(). This is a pretty template > > switchover. All we adjust is the CPU port so that

Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

2020-09-05 Thread Florian Fainelli
+Russell, On 9/5/2020 3:48 PM, Linus Walleij wrote: This switches the RTL8366RB over to using phylink callbacks instead of .adjust_link(). This is a pretty template switchover. All we adjust is the CPU port so that is why the code only inspects this port. We enhance by adding proper error messa