+Russell,
On 9/5/2020 3:48 PM, Linus Walleij wrote:
This switches the RTL8366RB over to using phylink callbacks
instead of .adjust_link(). This is a pretty template
switchover. All we adjust is the CPU port so that is why
the code only inspects this port.
We enhance by adding proper error messages, also disabling
the CPU port on the way down and moving dev_info() to
dev_dbg().
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
The part of the former adjust_link, especially the part that forces the
link to 1Gbit/sec, full duplex and no-autonegotiation probably belongs
to a phylink_mac_config() implementation.
Assuming that someone connects such a switch to a 10/100 Ethernet MAC
and provides a fixed-link property in Device Tree, we should at least
attempt to configure the CPU port interface based on those link
settings, that is not happening today.
--
Florian
