Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-17 Thread wenxu
在 2020/11/18 6:43, Cong Wang 写道: > On Mon, Nov 16, 2020 at 8:06 PM wenxu wrote: >> >> On 11/17/2020 3:01 AM, Cong Wang wrote: >>> On Sun, Nov 15, 2020 at 5:06 AM wenxu wrote: 在 2020/11/15 2:05, Cong Wang 写道: > On Wed, Nov 11, 2020 at 9:44 PM wrote: >> diff --git a/net/sched/act_fr

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-17 Thread Cong Wang
On Mon, Nov 16, 2020 at 8:06 PM wenxu wrote: > > > On 11/17/2020 3:01 AM, Cong Wang wrote: > > On Sun, Nov 15, 2020 at 5:06 AM wenxu wrote: > >> > >> 在 2020/11/15 2:05, Cong Wang 写道: > >>> On Wed, Nov 11, 2020 at 9:44 PM wrote: > diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c > >>

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-16 Thread wenxu
On 11/17/2020 3:01 AM, Cong Wang wrote: > On Sun, Nov 15, 2020 at 5:06 AM wenxu wrote: >> >> 在 2020/11/15 2:05, Cong Wang 写道: >>> On Wed, Nov 11, 2020 at 9:44 PM wrote: diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c new file mode 100644 index 000..3a7ab92 --- /

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-16 Thread Cong Wang
On Sun, Nov 15, 2020 at 5:06 AM wenxu wrote: > > > 在 2020/11/15 2:05, Cong Wang 写道: > > On Wed, Nov 11, 2020 at 9:44 PM wrote: > >> diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c > >> new file mode 100644 > >> index 000..3a7ab92 > >> --- /dev/null > >> +++ b/net/sched/act_frag.c > >

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-16 Thread Cong Wang
On Sat, Nov 14, 2020 at 2:46 PM Marcelo Ricardo Leitner wrote: > Davide had shared similar concerns with regards of the new module too. > The main idea behind the new module was to keep it as > isolated/contained as possible, and only so. So thumbs up from my > side. > > To be clear, you're only t

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-15 Thread wenxu
On 11/16/2020 12:26 AM, Jamal Hadi Salim wrote: > This nagged me: > What happens if all the frags dont make it out? > Should you at least return an error code(from tcf_fragment?) > and get the action err counters incremented? Thanks, Will do. > > cheers, > jamal > > On 2020-11-15 8:05 a.m., wenxu

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-15 Thread Jamal Hadi Salim
This nagged me: What happens if all the frags dont make it out? Should you at least return an error code(from tcf_fragment?) and get the action err counters incremented? cheers, jamal On 2020-11-15 8:05 a.m., wenxu wrote: 在 2020/11/15 2:05, Cong Wang 写道: On Wed, Nov 11, 2020 at 9:44 PM wrote

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-15 Thread wenxu
在 2020/11/15 2:05, Cong Wang 写道: > On Wed, Nov 11, 2020 at 9:44 PM wrote: >> diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c >> new file mode 100644 >> index 000..3a7ab92 >> --- /dev/null >> +++ b/net/sched/act_frag.c > It is kinda confusing to see this is a module. It provides some

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-14 Thread Marcelo Ricardo Leitner
On Sat, Nov 14, 2020 at 10:05:39AM -0800, Cong Wang wrote: > On Wed, Nov 11, 2020 at 9:44 PM wrote: > > diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c > > index 9c79fb9..dff3c40 100644 > > --- a/net/sched/act_ct.c > > +++ b/net/sched/act_ct.c > > @@ -1541,8 +1541,14 @@ static int __init ct_i

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-14 Thread Cong Wang
On Wed, Nov 11, 2020 at 9:44 PM wrote: > diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c > index 9c79fb9..dff3c40 100644 > --- a/net/sched/act_ct.c > +++ b/net/sched/act_ct.c > @@ -1541,8 +1541,14 @@ static int __init ct_init_module(void) > if (err) > goto err_register

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-13 Thread Jakub Kicinski
On Thu, 12 Nov 2020 23:25:22 -0300 Marcelo Ricardo Leitner wrote: > On Thu, Nov 12, 2020 at 02:20:58PM -0800, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 11:24:57 +0800 we...@ucloud.cn wrote: > > > v7-v10: fix __rcu warning > > > > Are you reposting stuff just to get it build tested? > > >

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-12 Thread Marcelo Ricardo Leitner
On Thu, Nov 12, 2020 at 02:20:58PM -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 11:24:57 +0800 we...@ucloud.cn wrote: > > v7-v10: fix __rcu warning > > Are you reposting stuff just to get it build tested? > > This is absolutely unacceptable. I don't know if that's the case, but maybe we c

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 11:24:57 +0800 we...@ucloud.cn wrote: > v7-v10: fix __rcu warning Are you reposting stuff just to get it build tested? This is absolutely unacceptable.

[PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-11 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in cat_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove