This nagged me:
What happens if all the frags dont make it out?
Should you at least return an error code(from tcf_fragment?)
and get the action err counters incremented?
cheers,
jamal
On 2020-11-15 8:05 a.m., wenxu wrote:
在 2020/11/15 2:05, Cong Wang 写道:
On Wed, Nov 11, 2020 at 9:44 PM <we...@ucloud.cn> wrote:
diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c
new file mode 100644
index 0000000..3a7ab92
--- /dev/null
+++ b/net/sched/act_frag.c
It is kinda confusing to see this is a module. It provides some
wrappers and hooks the dev_xmit_queue(), it belongs more to
the core tc code than any modularized code. How about putting
this into net/sched/sch_generic.c?
Thanks.
All the operations in the act_frag are single L3 action.
So we put in a single module. to keep it as isolated/contained as possible
Maybe put this in a single file is better than a module? Buildin in the tc core
code or not.
Enable this feature in Kconifg with NET_ACT_FRAG?
+config NET_ACT_FRAG
+ bool "Packet fragmentation"
+ depends on NET_CLS_ACT
+ help
+ Say Y here to allow fragmenting big packets when outputting
+ with the mirred action.
+
+ If unsure, say N.
