Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-26 Thread Andy Shevchenko
On Tue, Aug 25, 2020 at 07:40:15AM -0700, David Miller wrote: > From: Andy Shevchenko > Date: Mon, 24 Aug 2020 20:09:04 +0300 > > > Refactor phy_led_trigger_register() and deduplicate its functionality > > when registering LED trigger for link. > > > > Signed-off-by: Andy Shevchenko My bad...

Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-26 Thread Andy Shevchenko
On Mon, Aug 24, 2020 at 07:45:58PM +0200, Andrew Lunn wrote: > On Mon, Aug 24, 2020 at 08:09:04PM +0300, Andy Shevchenko wrote: > > Refactor phy_led_trigger_register() and deduplicate its functionality > > when registering LED trigger for link. > > > > Signed-off-by: Andy Shevchenko > > Reviewed

Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-25 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.9-rc2 next-20200825] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://gi

Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-25 Thread David Miller
From: Andy Shevchenko Date: Mon, 24 Aug 2020 20:09:04 +0300 > Refactor phy_led_trigger_register() and deduplicate its functionality > when registering LED trigger for link. > > Signed-off-by: Andy Shevchenko This doesn't compile: CC [M] drivers/net/phy/phy_led_triggers.o drivers/net/phy/ph

Re: [PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-24 Thread Andrew Lunn
On Mon, Aug 24, 2020 at 08:09:04PM +0300, Andy Shevchenko wrote: > Refactor phy_led_trigger_register() and deduplicate its functionality > when registering LED trigger for link. > > Signed-off-by: Andy Shevchenko Reviewed-by: Andrew Lunn Hi Andy Please take a look at https://www.kernel.org/d

[PATCH v1] net: phy: leds: Deduplicate link LED trigger registration

2020-08-24 Thread Andy Shevchenko
Refactor phy_led_trigger_register() and deduplicate its functionality when registering LED trigger for link. Signed-off-by: Andy Shevchenko --- drivers/net/phy/phy_led_triggers.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/phy/phy_led_triggers