On Tue, Aug 25, 2020 at 07:40:15AM -0700, David Miller wrote: > From: Andy Shevchenko <andriy.shevche...@linux.intel.com> > Date: Mon, 24 Aug 2020 20:09:04 +0300 > > > Refactor phy_led_trigger_register() and deduplicate its functionality > > when registering LED trigger for link. > > > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
My bad... Missed LED_CLASS and saw even something has been built in drivers/net/ but apparently wasn't enough to get this one compiled. v2 will fix that. Thanks! > This doesn't compile: > > CC [M] drivers/net/phy/phy_led_triggers.o > drivers/net/phy/phy_led_triggers.c: In function ‘phy_led_triggers_register’: > drivers/net/phy/phy_led_triggers.c:102:38: error: passing argument 2 of > ‘phy_led_trigger_register’ from incompatible pointer type > [-Werror=incompatible-pointer-types] > 102 | err = phy_led_trigger_register(phy, &phy->led_link_trigger, 0, > "link"); > | ^~~~~~~~~~~~~~~~~~~~~~ > | | > | struct phy_led_trigger ** > drivers/net/phy/phy_led_triggers.c:68:33: note: expected ‘struct > phy_led_trigger *’ but argument is of type ‘struct phy_led_trigger **’ > 68 | struct phy_led_trigger *plt, > | ~~~~~~~~~~~~~~~~~~~~~~~~^~~ > -- With Best Regards, Andy Shevchenko
