From: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Date: Mon, 24 Aug 2020 20:09:04 +0300

> Refactor phy_led_trigger_register() and deduplicate its functionality
> when registering LED trigger for link.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>

This doesn't compile:

  CC [M]  drivers/net/phy/phy_led_triggers.o
drivers/net/phy/phy_led_triggers.c: In function ‘phy_led_triggers_register’:
drivers/net/phy/phy_led_triggers.c:102:38: error: passing argument 2 of 
‘phy_led_trigger_register’ from incompatible pointer type 
[-Werror=incompatible-pointer-types]
  102 |  err = phy_led_trigger_register(phy, &phy->led_link_trigger, 0, "link");
      |                                      ^~~~~~~~~~~~~~~~~~~~~~
      |                                      |
      |                                      struct phy_led_trigger **
drivers/net/phy/phy_led_triggers.c:68:33: note: expected ‘struct 
phy_led_trigger *’ but argument is of type ‘struct phy_led_trigger **’
   68 |         struct phy_led_trigger *plt,
      |         ~~~~~~~~~~~~~~~~~~~~~~~~^~~

Reply via email to