Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 08:20:43 +0200 Vincent Bernat wrote: > ❦ 19 octobre 2020 17:53 -07, Jakub Kicinski: > > I'm not hearing any objections, but I have two questions: > > - do you intend to merge it for 5.10 or 5.11? Because it has a fixes > >tag, yet it's marked for net-next. If we put it in

Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-19 Thread Vincent Bernat
❦ 19 octobre 2020 17:53 -07, Jakub Kicinski: > I'm not hearing any objections, but I have two questions: > - do you intend to merge it for 5.10 or 5.11? Because it has a fixes >tag, yet it's marked for net-next. If we put it in 5.10 it may get >pulled into stable immediately, knowing how

Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-19 Thread Jakub Kicinski
On Mon, 19 Oct 2020 20:56:36 -0600 David Ahern wrote: > On 10/19/20 6:53 PM, Jakub Kicinski wrote: > > On Sat, 17 Oct 2020 14:50:11 +0200 Vincent Bernat wrote: > >> Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl > >> ignores a route whose interface is down. It is provided as

Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-19 Thread David Ahern
[ fix Andy's address ] On 10/17/20 6:50 AM, Vincent Bernat wrote: > Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl > ignores a route whose interface is down. It is provided as a > per-interface sysctl. However, while a "all" variant is exposed, it > was a noop since it was ne

Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-19 Thread David Ahern
On 10/19/20 6:53 PM, Jakub Kicinski wrote: > On Sat, 17 Oct 2020 14:50:11 +0200 Vincent Bernat wrote: >> Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl >> ignores a route whose interface is down. It is provided as a >> per-interface sysctl. However, while a "all" variant is ex

Re: [PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-19 Thread Jakub Kicinski
On Sat, 17 Oct 2020 14:50:11 +0200 Vincent Bernat wrote: > Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl > ignores a route whose interface is down. It is provided as a > per-interface sysctl. However, while a "all" variant is exposed, it > was a noop since it was never evalua

[PATCH net-next v1] net: evaluate net.conf.ipvX.all.ignore_routes_with_linkdown

2020-10-17 Thread Vincent Bernat
Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl ignores a route whose interface is down. It is provided as a per-interface sysctl. However, while a "all" variant is exposed, it was a noop since it was never evaluated. We use the usual "or" logic for this kind of sysctls. Teste