On 9/20/19 7:30 PM, Jakub Kicinski wrote:
> I'm assuming the mix of u8 and __u8 is intentional, since this is a partial
> revert :)
original patch for rt_uses_gateway used __u8 so yes put that back.
not sure why I used u8 for the new field, but left it on the move.
On Tue, 17 Sep 2019 10:39:49 -0700, David Ahern wrote:
> From: David Ahern
>
> Julian noted that rt_uses_gateway has a more subtle use than 'is gateway
> set':
>
> https://lore.kernel.org/netdev/alpine.lfd.2.21.1909151104060.2...@ja.home.ssi.bg/
>
> Revert that part of the commit referenced
Hello,
On Tue, 17 Sep 2019, David Ahern wrote:
> On 9/17/19 12:50 PM, Julian Anastasov wrote:
> >
> > Looks good to me, thanks!
> >
> > Reviewed-by: Julian Anastasov
> >
>
> BTW, do you have any tests for the rt_uses_gateway paths - showing why
> it is needed?
No speci
On 9/17/19 12:50 PM, Julian Anastasov wrote:
>
> Looks good to me, thanks!
>
> Reviewed-by: Julian Anastasov
>
BTW, do you have any tests for the rt_uses_gateway paths - showing why
it is needed?
All of the pmtu, redirect, fib tests, etc worked fine without the
special flag. Sure, the '
Hello,
On Tue, 17 Sep 2019, David Ahern wrote:
> From: David Ahern
>
> Julian noted that rt_uses_gateway has a more subtle use than 'is gateway
> set':
>
> https://lore.kernel.org/netdev/alpine.lfd.2.21.1909151104060.2...@ja.home.ssi.bg/
>
> Revert that part of the commit refere
From: David Ahern
Julian noted that rt_uses_gateway has a more subtle use than 'is gateway
set':
https://lore.kernel.org/netdev/alpine.lfd.2.21.1909151104060.2...@ja.home.ssi.bg/
Revert that part of the commit referenced in the Fixes tag.
Currently, there are no u8 holes in 'struct rtable'
