On Tue, 17 Sep 2019 10:39:49 -0700, David Ahern wrote: > From: David Ahern <dsah...@gmail.com> > > Julian noted that rt_uses_gateway has a more subtle use than 'is gateway > set': > > https://lore.kernel.org/netdev/alpine.lfd.2.21.1909151104060.2...@ja.home.ssi.bg/ > > Revert that part of the commit referenced in the Fixes tag. > > Currently, there are no u8 holes in 'struct rtable'. There is a 4-byte hole > in the second cacheline which contains the gateway declaration. So move > rt_gw_family down to the gateway declarations since they are always used > together, and then re-use that u8 for rt_uses_gateway. End result is that > rtable size is unchanged. > > Fixes: 1550c171935d ("ipv4: Prepare rtable for IPv6 gateway") > Reported-by: Julian Anastasov <j...@ssi.bg> > Signed-off-by: David Ahern <dsah...@gmail.com>
I'm assuming the mix of u8 and __u8 is intentional, since this is a partial revert :) Applied, queued, thanks!
