On 4/6/2021 2:53 PM, Jason Gunthorpe wrote:
On Tue, Apr 06, 2021 at 08:09:43AM +0300, Leon Romanovsky wrote:
On Tue, Apr 06, 2021 at 10:37:38AM +0800, Honggang LI wrote:
On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote:
From: Leon Romanovsky
From Avihai,
Relaxed Ordering i
, 46 insertions(+), 23 deletions(-)
v2:
- Remove extra code from nvme (Chao)
- Fix long lines (CH)
I've applied this version to rdma-rc - expecting to get these ULPs unbroken for
rc2
release
Thanks,
Jason
iser and nvme/rdma looks good to me,
Reviewed-by: Max Gurtovoy
On Fri, Sep 11, 2020 at 12:38 PM Kees Cook wrote:
> On Sat, Jul 18, 2020 at 07:16:51PM -0700, Max Filippov wrote:
> > Hello,
> >
> > this series adds support for seccomp filter on xtensa and updates
> > selftests/seccomp.
>
> Hi!
>
> Firstly, thanks for addi
Hello,
this series adds support for seccomp filter on xtensa and updates
selftests/seccomp.
Max Filippov (3):
xtensa: expose syscall through user_pt_regs
xtensa: add seccomp support
selftests/seccomp: add xtensa support
.../seccomp/seccomp-filter/arch-support.txt | 2 +-
arch
Xtensa returns syscall number can be obtained and changed through the
struct user_pt_regs. Syscall return value register is fixed relatively
to the current register window in the user_pt_regs, so it needs a bit of
special treatment.
Signed-off-by: Max Filippov
---
tools/testing/selftests
Add SECCOMP to xtensa Kconfig, select HAVE_ARCH_SECCOMP_FILTER, add
TIF_SECCOMP and call secure_computing from do_syscall_trace_enter.
Signed-off-by: Max Filippov
---
.../seccomp/seccomp-filter/arch-support.txt | 2 +-
arch/xtensa/Kconfig | 15
Use one of the reserved slots in struct user_pt_regs to return syscall
number in the GPR regset. Update syscall number from the GPR regset only
when it's non-zero.
Signed-off-by: Max Filippov
---
arch/xtensa/include/uapi/asm/ptrace.h | 3 ++-
arch/xtensa/kernel/ptrace.c | 4 ++
FMR is not supported on most recent RDMA devices (that use fast memory
registration mechanism). Also, FMR was recently removed from NFS/RDMA
ULP.
Signed-off-by: Max Gurtovoy
Reviewed-by: Israel Rukshin
Reviewed-by: Bart Van Assche
---
drivers/infiniband/ulp/srp/ib_srp.c | 222
HCA's that are driven by mlx4 driver support FRWR method to register
memory. Remove the ancient and unsafe FMR method.
Signed-off-by: Max Gurtovoy
---
drivers/infiniband/hw/mlx4/main.c | 10 --
drivers/infiniband/hw/mlx4/mlx4_ib.h| 16 ---
drivers/infiniband/hw/mlx4
This ancient and unsafe method for memory registration is no longer used
by any RDMA based ULP. Remove the FMR pool API from the core driver.
Signed-off-by: Max Gurtovoy
---
Documentation/driver-api/infiniband.rst | 3 -
drivers/infiniband/core/Makefile| 2 +-
drivers/infiniband
Remove the ancient and unsafe FMR method.
Signed-off-by: Max Gurtovoy
---
drivers/infiniband/hw/mthca/mthca_dev.h | 10 -
drivers/infiniband/hw/mthca/mthca_mr.c | 262 +--
drivers/infiniband/hw/mthca/mthca_provider.c | 86 -
3 files changed, 1
"Linux 5.7-rc7"
- added "Reviewed-by" Bart signature for SRP
Gal Pressman (1):
RDMA/mlx5: Remove FMR leftovers
Israel Rukshin (1):
RDMA/iser: Remove support for FMR memory registration
Max Gurtovoy (7):
RDMA/mlx4: remove FMR support for memory registration
RDMA
Use FRWR method for memory registration by default and remove the ancient
and unsafe FMR method.
Signed-off-by: Max Gurtovoy
---
net/rds/Makefile | 2 +-
net/rds/ib.c | 14 +--
net/rds/ib.h | 1 -
net/rds/ib_cm.c | 4 +-
net/rds/ib_fmr.c | 269
After removing FMR support from all the RDMA ULPs and providers, there
is no need to keep FMR operation for IB devices.
Signed-off-by: Max Gurtovoy
---
Documentation/infiniband/core_locking.rst | 2 --
drivers/infiniband/core/device.c | 4 ---
drivers/infiniband/core/verbs.c
From: Gal Pressman
Remove a few leftovers from FMR functionality which are no longer used.
Signed-off-by: Gal Pressman
Signed-off-by: Max Gurtovoy
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h
b
Use FRWR method to register memory by default and remove the ancient and
unsafe FMR method.
Signed-off-by: Max Gurtovoy
---
drivers/infiniband/sw/rdmavt/mr.c | 154 --
drivers/infiniband/sw/rdmavt/mr.h | 15
drivers/infiniband/sw/rdmavt/vt.c | 4 -
3
From: Israel Rukshin
FMR is not supported on most recent RDMA devices (that use fast memory
registration mechanism). Also, FMR was recently removed from NFS/RDMA
ULP.
Signed-off-by: Israel Rukshin
Signed-off-by: Max Gurtovoy
Reviewed-by: Sagi Grimberg
---
drivers/infiniband/ulp/iser
On 10/7/2019 10:54 AM, Leon Romanovsky wrote:
On Sun, Oct 06, 2019 at 11:58:25PM -0700, Christoph Hellwig wrote:
/*
- * Check if the device might use memory registration. This is currently only
- * true for iWarp devices. In the future we can hopefully fine tune this based
- * on HCA driver
On 6/6/2019 10:14 AM, Leon Romanovsky wrote:
On Wed, Jun 05, 2019 at 11:24:31PM +, Saeed Mahameed wrote:
Hi Dave, Doug & Jason
This series improves DIM - Dynamically-tuned Interrupt
Moderation- to be generic for netdev and RDMA use-cases.
From Tal and Yamin:
The first 7 patches provide
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.
Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov
Cc: Florian Fainelli
---
drivers/net/phy/dp83867.c | 4 +---
1 file changed, 1 insertion(+), 3 deletion
After reset SGMII Autoneg timer is set to 2us (bits 6 and 5 are 01).
That is not enough to finalize autonegatiation on some devices.
Increase this timer duration to maximum supported 16ms.
Signed-off-by: Max Uvarov
Cc: Heiner Kallweit
Reviewed-by: Florian Fainelli
---
drivers/net/phy/dp83867
Phy state machine calls _config_init just after
reset.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 14e9e8a94639..1ec48ecf4133 100644
--- a/drivers/net/phy
v3: use phy_modify_mmd()
v2: fix minor comments by Heiner Kallweit and Florian Fainelli
Max Uvarov (4):
net: phy: dp83867: fix speed 10 in sgmii mode
net: phy: dp83867: increase SGMII autoneg timer duration
net: phy: dp83867: do not call config_init twice
net: phy: dp83867: Set up RGMII
For supporting 10Mps speed in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit
of DP83867_10M_SGMII_CFG register has to be cleared by software.
That does not affect speeds 100 and 1000 so can be done on init.
Signed-off-by: Max Uvarov
Cc: Heiner Kallweit
Reviewed-by: Florian Fainelli
---
drivers
v2: fix minor comments by Heiner Kallweit and Florian Fainelli.
Max Uvarov (4):
net: phy: dp83867: fix speed 10 in sgmii mode
net: phy: dp83867: increase SGMII autoneg timer duration
net: phy: dp83867: do not call config_init twice
net: phy: dp83867: Set up RGMII TX delay
drivers/net
Phy state machine calls _config_init just after
reset.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 5fafcc091525..a1c0b2128de2 100644
--- a/drivers/net/phy
For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit
of DP83867_10M_SGMII_CFG register has to be cleared by software.
That does not affect speeds 100 and 1000 so can be done on init.
Signed-off-by: Max Uvarov
Cc: Heiner Kallweit
---
drivers/net/phy/dp83867.c | 20
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.
Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy")
Signed-off-by: Max Uvarov
Cc: Florian Fainelli
---
drivers/net/phy/dp83867.c | 4 +---
1 file changed, 1 insertion(+), 3 deletion
After reset SGMII Autoneg timer is set to 2us (bits 6 and 5 are 01).
That us not enough to finalize autonegatiation on some devices.
Increase this timer duration to maximum supported 16ms.
Signed-off-by: Max Uvarov
Cc: Heiner Kallweit
---
drivers/net/phy/dp83867.c | 10 ++
1 file
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
so code to set tx delay is never called.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 2984fd5ae495
Phy state machine calls _config_init just after
reset.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 66b0a09ad094..2984fd5ae495 100644
--- a/drivers/net/phy
Patch "fix speed 10 in sgmii mode" I already sent before
and the was no mutch objections. Just resending it.
Patch "increase SGMII autoneg timer duration" fixes autoneg
between mac and the phy.
And the latest "do not call config_init twice" is the logical
code c
After reset SGMII Autoneg timer is set to 2us (bits 6 and 5 are 01).
That us not enough to finalize autonegatiation on some devices.
Increase this timer duration to maximum supported 16ms.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 13 +
1 file changed, 13 insertions
For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit
of DP83867_10M_SGMII_CFG register has to be cleared by software.
That does not affect speeds 100 and 1000 so can be done on init.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 22 ++
1 file
Similar to dp83640 delay after soft reset
is needed to set up registers correctly.
Signed-off-by: Max Uvarov
---
drivers/net/phy/dp83867.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index ac8ba642d616..e1ec36c51511 100644
--- a
delete mode 100644 arch/s390/include/uapi/asm/socket.h
> delete mode 100644 arch/x86/include/uapi/asm/socket.h
> delete mode 100644 arch/xtensa/include/uapi/asm/socket.h
For xtensa:
Acked-by: Max Filippov
--
Thanks.
-- Max
hi Sagi,
+static inline void nvmet_tcp_put_cmd(struct nvmet_tcp_cmd *cmd)
+{
+ if (unlikely(cmd == &cmd->queue->connect))
+ return;
if you don't return connect cmd to the list please don't add it to it in
the first place (during alloc_cmd). and if you use it once, we migh
On 11/27/2018 9:48 AM, Sagi Grimberg wrote:
This looks odd. It's not really the timeout handlers job to
call nvme_end_request here.
Well.. if we are not yet LIVE, we will not trigger error
recovery, which means nothing will complete this command so
something needs to do it...
I think that
+static enum blk_eh_timer_return
+nvme_tcp_timeout(struct request *rq, bool reserved)
+{
+ struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq);
+ struct nvme_tcp_ctrl *ctrl = req->queue->ctrl;
+ struct nvme_tcp_cmd_pdu *pdu = req->pdu;
+
+ dev_dbg(ctrl->ctrl.device,
+ "queue %d
On 8/1/2018 8:12 AM, Sagi Grimberg wrote:
Hi Max,
Hi,
Yes, since nvmf is the only user of this function.
Still waiting for comments on the suggested patch :)
Sorry for the late response (but I'm on vacation so I have
an excuse ;))
NP :) currently the code works..
I'
On 7/30/2018 6:47 PM, Steve Wise wrote:
On 7/23/2018 11:53 AM, Max Gurtovoy wrote:
On 7/23/2018 7:49 PM, Jason Gunthorpe wrote:
On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote:
[ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18
queue 9 is not mapped (overlap
On 7/23/2018 7:49 PM, Jason Gunthorpe wrote:
On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote:
[ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18
queue 9 is not mapped (overlap).
please try the bellow:
This seems to work. Here are three mapping cases: each
Regards,
Max,
From 6f7b98f1c43252f459772390c178fc3ad043fc82 Mon Sep 17 00:00:00 2001
From: Max Gurtovoy
Date: Thu, 19 Jul 2018 12:42:00 +
Subject: [PATCH 1/1] blk-mq: fix RDMA queue/cpu mappings assignments for mq
In order to fulfil the block layer cpu <-> queue mapping, all the
allocate
On 7/18/2018 10:29 PM, Steve Wise wrote:
On 7/18/2018 2:38 PM, Sagi Grimberg wrote:
IMO we must fulfil the user wish to connect to N queues and not reduce
it because of affinity overlaps. So in order to push Leon's patch we
must also fix the blk_mq_rdma_map_queues to do a best effort
ma
On 7/18/2018 2:38 PM, Sagi Grimberg wrote:
IMO we must fulfil the user wish to connect to N queues and not reduce
it because of affinity overlaps. So in order to push Leon's patch we
must also fix the blk_mq_rdma_map_queues to do a best effort mapping
according the affinity and map the rest
On 7/17/2018 11:58 AM, Leon Romanovsky wrote:
On Tue, Jul 17, 2018 at 11:46:40AM +0300, Max Gurtovoy wrote:
On 7/16/2018 8:08 PM, Steve Wise wrote:
Hey Max:
Hey,
On 7/16/2018 11:46 AM, Max Gurtovoy wrote:
On 7/16/2018 5:59 PM, Sagi Grimberg wrote:
Hi,
I've tested this
On 7/16/2018 8:08 PM, Steve Wise wrote:
Hey Max:
Hey,
On 7/16/2018 11:46 AM, Max Gurtovoy wrote:
On 7/16/2018 5:59 PM, Sagi Grimberg wrote:
Hi,
I've tested this patch and seems problematic at this moment.
Problematic how? what are you seeing?
Connection failures and same
kernel, HCA, affinity map, connect
command, lscpu) ?
I want to repro it in my lab.
-Max.
s it works for every irq affinity.
On 7/16/2018 1:30 PM, Leon Romanovsky wrote:
On Mon, Jul 16, 2018 at 01:23:24PM +0300, Sagi Grimberg wrote:
Leon, I'd like to see a tested-by tag for this (at least
until I get some time to test it).
Of course.
Thanks
The patch itself looks fine to me.
-Max.
On 2/1/2018 10:21 AM, Greg KH wrote:
On Tue, Jan 30, 2018 at 10:12:51AM +0100, Marta Rybczynska wrote:
Hello Mellanox maintainers,
I'd like to ask you to OK backporting two patches in mlx5 driver to 4.9 stable
tree (they're in master for some time already).
We have multiple deployment in 4.9
Fix obvious typo that first return value is set but not checked.
Signed-off-by: Max Uvarov
---
drivers/net/phy/micrel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index fdb43dd..ab46141 100644
--- a/drivers/net
Polling 14 mdio devices on single mdio bus eats 30% of 1Ghz cpu time
due to busy loop in wait(). Add small delay to relax cpu.
Signed-off-by: Max Uvarov
Reviewed-by: Andrew Lunn
Reviewed-by: Grygorii Strashko
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +++-
1 file changed, 3 insertions
Frequency can be adjusted in DT it make sense to
print current used value on driver init.
Signed-off-by: Max Uvarov
Reviewed-by: Grygorii Strashko
---
drivers/net/ethernet/ti/davinci_mdio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti
v3: no code change, just added cover letter
First patch fixes cpu load on polling busy mdio line.
Second patch just prints which mdio frequency was configured.
Max Uvarov (2):
drivers: net: davinci_mdio: remove busy loop on wait user access
drivers: net: davinci_mdio: print bus frequency
Polling 14 mdio devices on single mdio bus eats 30% of 1Ghz cpu time
due to busy loop in wait(). Add small delay to relax cpu.
Signed-off-by: Max Uvarov
---
v2: fix spelling in commit description.
drivers/net/ethernet/ti/davinci_mdio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
Frequency can be adjusted in DT it make sense to
print current used value on driver init.
Signed-off-by: Max Uvarov
---
drivers/net/ethernet/ti/davinci_mdio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b/drivers/net/ethernet
Polling 14 mdio devices on single mdio bus eats 30% of 1Ghz cpu time
due to busy loop in waiti(). Aadd small delay to relax cpu.
Signed-off-by: Max Uvarov
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti
Frequency can be audjusted in DT it make sense to
print current used value on driver init.
Signed-off-by: Max Uvarov
---
drivers/net/ethernet/ti/davinci_mdio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b/drivers/net
cover at all.
Move napi_enable above ethoc_reset in the ethoc_open to fix that.
Cc: sta...@vger.kernel.org
Signed-off-by: Max Filippov
---
drivers/net/ethernet/ethoc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
Any feedback is welcome.
Hi Sagi,
the patchset looks good and of course we can add support for more
drivers in the future.
have you run some performance testing with the nvmf initiator ?
Sagi Grimberg (6):
mlx5: convert to generic pci_alloc_irq_vectors
mlx5: move affinity hints assig
_GPL(blk_mq_rdma_map_queues);
Otherwise, Looks good.
Reviewed-by: Max Gurtovoy
ct net_device *dev)
if (skb_put_padto(skb, ETHOC_ZLEN)) {
dev->stats.tx_errors++;
- goto out;
+ return NETDEV_TX_OK;
}
if (unlikely(skb->len > ETHOC_BUFSIZ)) {
Without it the interface becomes non-functional after the firs
+ goto out;
> + }
skb_put_padto says that skb is freed on error, so this shoudn't go to
label 'out' on error where skb is freed again?
--
Thanks.
-- Max
ed in struct net_device.
>
> Signed-off-by: Philippe Reynes
> ---
Series:
Tested-by: Max Filippov
--
Thanks.
-- Max
rnet/ethoc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Max Filippov
--
Thanks.
-- Max
description is a bit inaccurate. Indeed all 'goto free' above the
'priv = netdev_priv(netdev);' need to skip 'if (priv->clk)' check, but
there are two more 'goto free' below that line, and they look correct
now, but after this patch they'll leave the clock enabled.
--
Thanks.
-- Max
Hello,
I have interest of investing in your country as well as seek your
services in a private and confidential issue. My name is Max Edward,
an auditor with Scouts Bank London, On my routine inspection I
discovered a dormant domiciliary account with the deposit of £4.6M
(Four Million Six
This allows using OpenCores ethernet controller attached to its host in
native-endian mode with bi-endian CPUs. Example of such system is Xtensa
XTFPGA platform.
Signed-off-by: Max Filippov
---
Changes v1->v2:
- expand changelog with motivation for the change.
drivers/net/ethernet/ethoc.c |
Signed-off-by: Max Filippov
---
drivers/net/ethernet/ethoc.c | 14 --
include/net/ethoc.h | 1 +
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 442410c..17ff9a4 100644
--- a/drivers/net
interested in speeding
up tunning
and general network apps. We have wireless basestation apps here that need to
handle packets
in user-space. Those kind things have nothing to with virtualization.
Max
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ubmitChecklist
> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
>
> to
>
> Maxim Krasnyansky <[EMAIL PROTECTED]>
> "David S. Miller" <[EMAIL PROTECTED]>
> Andrew Morton <[EMAIL PROTECTED]>
> netdev@vger.kernel.org
btw I'd be ok with this fix. But I guess the questions is why not use
struct tun_pi in the apps instead ?
Max
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
27;T', 207, unsigned int)
>
> /* TUNSETIFF ifr flags */
> #define IFF_TUN 0x0001
> @@ -91,6 +92,8 @@ struct tun_struct {
> #define IFF_VIRTIO_HDR 0x4000
> #define IFF_RECV_CSUM0x8000
> #define IFF_RECV_GSO 0x0800
> +#define IFF_ALL_FLAGS
> ftp://[EMAIL PROTECTED]/0001-bnx2x-h-file-rewrite.txt
>
> gzipped:
> ftp://[EMAIL PROTECTED]/0001-bnx2x-h-file-rewrite.txt.gz
>
> (will also attache patch inline as reply to this email for review)
>
I built the newest bnx2x code against the net-2.6 kernel and ran a
number
...
do_softirq
...
Kernel panic - not syncing
Fatal exception in interrupt.
Please let me what additional information is useful.
Max
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.
128 byte in size (end - head) even though
we're clearly allocating and trying to write more than that.
So, my conclusion at this point is that for whatever reason alloc_skb()
returned
busted SKB. Probably because something in the slab got corrupted.
Any other thoughts ?
Thanx
Max
-
To unsubs
Hi Jon,
Acknowledged. We'll deliver it along with
some other patches ASAP.
Thanx
Did you get a chance to look at my other patch for the header packing ?
Max
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More
Max Krasnyansky wrote:
Fixes an oops in the non-blocking mode.
Signed-off-by: Max Krasnyansky <[EMAIL PROTECTED]>
---
net/tipc/socket.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 2a6a5a6..767f791 100644
--- a/ne
Dave, Alan, Jon,
Max Krasnyansky wrote:
TIPC code is a bit inconsistent in masking out upper bits of various
message fields when packing them into the headers. For the most part
things seem to be ok but we happened to hit a corner case in our labs
when broadcast counter reached certain value
d was messing up status bits in the header. At which point
the link was busted and required a reset to bring it back up.
It's much safer to apply proper mask in the function that does the
actual packing rather than doing it all over the place, and missing a
few ;-).
Signed-off-by: Max Krasnyans
Fixes an oops in the non-blocking mode.
Signed-off-by: Max Krasnyansky <[EMAIL PROTECTED]>
---
net/tipc/socket.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 2a6a5a6..767f791 100644
--- a/net/tipc/socket.c
+++ b/ne
wider audience.
Max
--
kernel BUG at kernel/workqueue.c:149!
invalid opcode: [#1]
Modules linked in: michael_mic arc4 zd1211rw ieee80211_crypt_wep
ieee80211_crypt_tkip ieee80211_crypt_ccmp firmware_class ieee80211softmac
ieee80211 ieee80211_crypt snd_mixer_oss rfcomm l2cap bluetooth 8250
something like
zap_reserved_page_range()
that assumes that pages are reserved.
Max
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
to _unmap_ the thing once user-space app is done with it.
With ring buffer it's "memcpy()/kfree_skb()" where with mmap it's
"remap()/unmap()/kfree_skb()".
Max
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMA
that
show up on tunX interface to the user-space as fast as we can.
Max
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
page.
Such schema is very suitable for applications that
do not require the whole data flow, but only select some data
from the flow, based on packet content.
I'm quite sure it will be slower than copying for small packets,
I would say not just slower much slower :).
Max
-
To unsubscri
85 matches
Mail list logo
