Hi Florian,
On Mon, Jul 11, 2016 at 04:35:55PM -0700, Florian Fainelli wrote:
> Even though the hardware can be doing zero padding, we want the SKB to
> be going out on the wire with the appropriate size. This fixes packet
> truncations observed with e.g: ARP packets.
>
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
> ---
> drivers/net/ethernet/ethoc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
> index 06ae14a8e946..ca678d46c322 100644
> --- a/drivers/net/ethernet/ethoc.c
> +++ b/drivers/net/ethernet/ethoc.c
> @@ -860,6 +860,11 @@ static netdev_tx_t ethoc_start_xmit(struct sk_buff *skb,
> struct net_device *dev)
> unsigned int entry;
> void *dest;
>
> + if (skb_put_padto(skb, ETHOC_ZLEN)) {
> + dev->stats.tx_errors++;
> + goto out;
> + }
skb_put_padto says that skb is freed on error, so this shoudn't go to
label 'out' on error where skb is freed again?
--
Thanks.
-- Max
