On 5/9/24 12:36 PM, Daniel Jurgens wrote:
> The pointer delcaration was missing the __free(kfree).
Works for me:
Tested-by: Jens Axboe
--
Jens Axboe
ication stacking
commit: 6fe4220912d19152a26ce19713ab232f4263018d
Best regards,
--
Jens Axboe
On 3/21/21 4:20 AM, Stefan Metzmacher wrote:
>
> Am 20.03.21 um 23:57 schrieb Jens Axboe:
>> On 3/20/21 1:33 PM, Stefan Metzmacher wrote:
>>> Without that it's not safe to use them in a linked combination with
>>> others.
>>>
>>>
all just ignores
> MSG_WAITALL, as MSG_ZEROCOPY is also ignored without explicitly set
> SO_ZEROCOPY.
>
> We also expect the caller to know about the implicit truncation to
> MAX_RW_COUNT, which we don't detect.
Thanks, I do think this is much better and I feel comfortable getting
htis applied for 5.12 (and stable).
--
Jens Axboe
On 3/2/21 8:49 PM, Jens Axboe wrote:
> On 3/2/21 11:34 AM, Coelho, Luciano wrote:
>> On Tue, 2021-03-02 at 11:20 -0700, Jens Axboe wrote:
>>> My laptop crashes at boot, and I ran the same kernel with KASAN enabled.
>>> Turns out the DMI addition for iwlwifi is broken (a
On 3/2/21 11:34 AM, Coelho, Luciano wrote:
> On Tue, 2021-03-02 at 11:20 -0700, Jens Axboe wrote:
>> My laptop crashes at boot, and I ran the same kernel with KASAN enabled.
>> Turns out the DMI addition for iwlwifi is broken (and untested?), since
>> it doesn't properl
===
Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG
feature")
Signed-off-by: Jens Axboe
---
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 15e2773ce7e7..71e5306bd695 100644
--- a/drivers/net/wi
===
Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG
feature")
Signed-off-by: Jens Axboe
---
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 15e2773ce7e7..71e5306bd695 100644
--- a/drivers/net/wi
uld be sufficient?
>>>
>> Actually I mean the deadlock described in commit f0b493e ("io_uring:
>> prevent potential eventfd recursion on poll"). It can break this bug
>> fix if we just increase EVENTFD_WAKEUP_DEPTH.
>
>
> Ok, so can wait do something similar in that commit? (using async stuffs
> like wq).
io_uring should be fine in current kernels, but aio would still be
affected by this. But just in terms of recursion, bumping it one more
should probably still be fine.
--
Jens Axboe
table pushing this to 5.12.
--
Jens Axboe
On 12/16/20 4:29 PM, Victor Stewart wrote:
> what's to be done about this kernel test robot output, if anything?
Nothing I think, doesn't look related to your change at all.
--
Jens Axboe
~82%.
>
> this patch closes that loophole.
LGTM
Acked-by: Jens Axboe
--
Jens Axboe
On 12/12/20 2:42 PM, Victor Stewart wrote:
> On Sat, Dec 12, 2020 at 6:02 PM Jens Axboe wrote:
>>
>> On 12/12/20 10:58 AM, Victor Stewart wrote:
>>> On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote:
>>>>
>>>> On 12/12/20 10:25 AM, Victor Stewart w
On 12/12/20 10:58 AM, Victor Stewart wrote:
> On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote:
>>
>> On 12/12/20 10:25 AM, Victor Stewart wrote:
>>> On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote:
>>>>
>>>> On 12/12/20 8:31 AM, Victor Stewart w
On 12/12/20 10:25 AM, Victor Stewart wrote:
> On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote:
>>
>> On 12/12/20 8:31 AM, Victor Stewart wrote:
>>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO
>>> cmsgs" thread.
n
general.
I'd also CC Jann Horn on the series, he's the one that found an issue there
in the past and also acked the previous change on doing PROTO_CMSG_DATA_ONLY.
--
Jens Axboe
p;data->lock);
+ spin_lock_bh(&data->lock);
list_add_tail(&ref_node->node, &data->ref_list);
data->node = ref_node;
- spin_unlock(&data->lock);
+ spin_unlock_bh(&data->lock);
percpu_ref_get(&ctx->file_data->refs);
} else
destroy_fixed_file_ref_node(ref_node);
--
Jens Axboe
, tfile, to, noblock, NULL);
ret = min_t(ssize_t, ret, len);
if (ret > 0)
iocb->ki_pos = ret;
--
Jens Axboe
, tfile, to, noblock, NULL);
ret = min_t(ssize_t, ret, len);
if (ret > 0)
iocb->ki_pos = ret;
--
Jens Axboe
On 10/26/20 6:05 PM, Al Viro wrote:
> On Mon, Oct 26, 2020 at 05:56:11PM -0600, Jens Axboe wrote:
>> On 10/26/20 4:55 PM, Kyle Huey wrote:
>>> A test program from the rr[0] test suite, vm_readv_writev[1], no
>>> longer works on 5.10-rc1 when compiled as a 32 bit binary a
ack_r, false);
+ iov_r = iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r,
+ in_compat_syscall());
if (IS_ERR(iov_r)) {
rc = PTR_ERR(iov_r);
goto free_iov_l;
--
Jens Axboe
tead of doing the function call
and then aborting if it's empty. So I'd suggest just leaving it alone.
Right now this is the only caller, but it's nicer to assume we can
be called in any state vs not having the check.
--
Jens Axboe
On 9/7/20 11:00 AM, Christoph Hellwig wrote:
> On Mon, Sep 07, 2020 at 09:58:13AM -0700, Jakub Kicinski wrote:
>> On Mon, 7 Sep 2020 10:45:00 -0600 Jens Axboe wrote:
>>> On 9/6/20 11:48 PM, Christoph Hellwig wrote:
>>>> On Sat, Sep 05, 2020 at 04:05:48PM -0600, Jens
On 9/6/20 11:48 PM, Christoph Hellwig wrote:
> On Sat, Sep 05, 2020 at 04:05:48PM -0600, Jens Axboe wrote:
>> There's a trivial io_uring patch that depends on this one. If this one
>> is acceptable to you, I'd like to queue it up in the io_uring branch for
>> 5.10
On 9/5/20 4:39 PM, Jakub Kicinski wrote:
> On Sat, 5 Sep 2020 16:05:48 -0600 Jens Axboe wrote:
>> No functional changes in this patch, needed to provide io_uring support
>> for shutdown(2).
>>
>> Cc: netdev@vger.kernel.org
>> Cc: David S. Mil
No functional changes in this patch, needed to provide io_uring support
for shutdown(2).
Cc: netdev@vger.kernel.org
Cc: David S. Miller
Signed-off-by: Jens Axboe
---
There's a trivial io_uring patch that depends on this one. If this one
is acceptable to you, I'd like to queue it
ses.
>
> This patch was tested by using a simple sending program to call recvmsg
> using io_uring with MSG_ERRQUEUE set and verifying with printks that the
> POLLIN is correctly unset when the msg flags are MSG_ERRQUEUE.
Perfect, and ends up being much simpler too and straight forward.
--
Jens Axboe
On 8/21/20 8:13 PM, Luke Hsiao wrote:
> Hi Jens,
>
> On Fri, Aug 21, 2020 at 7:09 PM Jens Axboe wrote:
>>
>> On 8/21/20 8:04 PM, Luke Hsiao wrote:
>>>
>> Sorry, one more minor thing to fix up:
>>
>>> @@ -4932,6 +4934,11 @@ s
flags & REQ_F_NOWAIT)) {
> - if (!io_arm_poll_handler(req)) {
> + if (!io_arm_poll_handler(req, sqe)) {
Also means you can drop this part.
--
Jens Axboe
On 8/21/20 6:08 PM, Luke Hsiao wrote:
> Hi Jakub and Jens,
>
> Thank you for both of your reviews. Some responses inline below.
>
> On Fri, Aug 21, 2020 at 2:11 PM Jens Axboe wrote:
>>
>> On 8/21/20 2:41 PM, Jakub Kicinski wrote:
>>> On Thu, 20 Aug
or 9 of them don't really matter... This is something that should
be cleaned up separately at some point.
> And obviously the brackets around POLLIN are not necessary.
Agree, would be cleaner without!
Luke, with that:
Reviewed-by: Jens Axboe
--
Jens Axboe
eived -EINVALID from
> this specific code path. After this patch, we could read tcp tx
> zero-copy completion notifications from the MSG_ERRQUEUE.
>
> Signed-off-by: Soheil Hassas Yeganeh
> Signed-off-by: Arjun Roy
> Acked-by: Eric Dumazet
> Reviewed-by: Jann Horn
> Signed-off-by: Luke Hsiao
Reviewed-by: Jens Axboe
--
Jens Axboe
let()
>
> - out_cast() or outer_cast()
> - from_member().
> - container_from() or from_container()
>
> from_container() sounds fine, would trimming it a bit work? like from_cont().
I like container_from() the most, since it's the closest to contain_of()
which is a well known idiom for years. The lines will already be shorter
without the need to specify the struct, so don't like the idea of
squeezing container into cont for any of them. For most people, cont is
usually short for continue, not container.
--
Jens Axboe
On 8/19/20 6:11 AM, Greg KH wrote:
> On Wed, Aug 19, 2020 at 07:00:53AM -0600, Jens Axboe wrote:
>> On 8/18/20 1:00 PM, James Bottomley wrote:
>>> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
>>>> On 8/17/20 12:48 PM, Kees Cook wrote:
>>>>> O
On 8/18/20 1:00 PM, James Bottomley wrote:
> On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
>> On 8/17/20 12:48 PM, Kees Cook wrote:
>>> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
>>>> On 8/17/20 12:29 PM, Kees Cook wrote:
>>>>> O
On 8/17/20 12:48 PM, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
>> On 8/17/20 12:29 PM, Kees Cook wrote:
>>> On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
>>>> On 8/17/20 2:15 AM, Allen Pais wrote:
>>>>>
On 8/17/20 12:29 PM, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
>> On 8/17/20 2:15 AM, Allen Pais wrote:
>>> From: Allen Pais
>>>
>>> In preparation for unconditionally passing the
>>> struct tasklet_struct pointer
e up with the idea to add a macro 'from_tasklet' that is just
container_of? container_of in the code would be _much_ more readable,
and not leave anyone guessing wtf from_tasklet is doing.
I'd fix that up now before everything else goes in...
--
Jens Axboe
On 7/30/19 3:22 PM, David Miller wrote:
> From: Jens Axboe
> Date: Tue, 30 Jul 2019 20:49:09 +
>
>> Pretty appalled to see this abomination:
>>
>> net: Convert skb_frag_t to bio_vec
>>
>> There are a lot of users of frag->page_offset, so use a unio
On 7/30/19 8:40 AM, Jonathan Lemon wrote:
> The recent conversion of skb_frag_t to bio_vec did not include
> skb_frag's page_offset. Add accessor functions for this field,
> utilize them, and remove the union, restoring the original structure.
You can add:
Reviewed-by: Jens
On 2/8/19 12:49 PM, David Miller wrote:
> From: Jens Axboe
> Date: Fri, 8 Feb 2019 10:34:17 -0700
>
>> We need this functionality for the io_uring file registration, but
>> we cannot rely on it since CONFIG_UNIX can be modular. Move the helpers
>> to a separate fil
etdev@vger.kernel.org
Cc: David S. Miller
Signed-off-by: Jens Axboe
---
include/net/af_unix.h | 1 +
net/unix/Kconfig | 5 ++
net/unix/Makefile | 2 +
net/unix/af_unix.c| 63 +-
net/unix/garbage.c| 71 +---
net/unix/scm.c
.
And with that, can we please put an end to this thread (and patchset)?
--
Jens Axboe
. How would anyone get offended by reading
> technical comments? This is all beyond me...
Agree, this is insanity.
--
Jens Axboe
gt; Signed-off-by: Anshuman Khandual
>
> For the 'ixgbe' driver changes.
>
> Acked-by: Jeff Kirsher
Lost the original, but for mtip32xx:
Acked-by: Jens Axboe
--
Jens Axboe
On 5/15/18 10:11 AM, Jens Axboe wrote:
> On 5/15/18 10:00 AM, Matthew Wilcox wrote:
>> From: Matthew Wilcox
>>
>> The sbitmap and the percpu_ida perform essentially the same task,
>> allocating tags for commands. Since the sbitmap is more used than
>> the percpu_
g = iscsit_wait_for_tag(se_sess, state, &cpu);
> if (tag < 0)
> return NULL;
Might make sense to just roll the whole thing into iscsi_get_tag(), that
would be cleaner.
sbitmap should provide a helper for that, but we can do that cleanup
later. That would encapsulate things like the per-cpu caching hint too,
for instance.
Rest looks fine to me.
--
Jens Axboe
On 4/26/18 1:20 AM, Christoph Hellwig wrote:
> On Tue, Apr 24, 2018 at 08:02:56PM -0600, Jens Axboe wrote:
>> On 4/24/18 12:16 PM, Christoph Hellwig wrote:
>>> ide_toggle_bounce did select various strange block bounce limits, including
>>> not bouncing at all as soon as
the issue was that the PIO code could not handle
highmem. That's not the case anymore, so this should be fine.
Reviewed-by: Jens Axboe
--
Jens Axboe
On 11/09/2017 02:23 PM, Thomas Gleixner wrote:
> On Thu, 9 Nov 2017, Jens Axboe wrote:
>> On 11/09/2017 10:03 AM, Thomas Gleixner wrote:
>>> On Thu, 9 Nov 2017, Jens Axboe wrote:
>>>> On 11/09/2017 07:19 AM, Thomas Gleixner wrote:
>>>> If that's the
On 11/09/2017 10:07 AM, Thomas Gleixner wrote:
> On Thu, 9 Nov 2017, Jens Axboe wrote:
>
>> On 11/09/2017 09:01 AM, Sagi Grimberg wrote:
>>>> Now you try to blame the people who implemented the managed affinity stuff
>>>> for the wreckage, which was created
On 11/09/2017 10:03 AM, Thomas Gleixner wrote:
> On Thu, 9 Nov 2017, Jens Axboe wrote:
>> On 11/09/2017 07:19 AM, Thomas Gleixner wrote:
>> If that's the attitude at your end, then I do suggest we just revert the
>> driver changes. Clearly this isn't going to be prod
st trying to understand
> how to move forward with making users happy and still enjoy subsystem
> services instead of doing lots of similar things inside mlx5 driver.
Exactly. The key here is how we make it work for both cases. But there
has to be a willingness to make the infrastructure work for that.
--
Jens Axboe
> limitations after the changes hit the tree. This could have been figured
> out before even a single patch was posted.
>
> Now you try to blame the people who implemented the managed affinity stuff
> for the wreckage, which was created by people who changed drivers to use
> it. Nice try.
If that's the attitude at your end, then I do suggest we just revert the
driver changes. Clearly this isn't going to be productive going forward.
The better solution was to make the managed setup more flexible, but
it doesn't sound like that is going to be viable at all.
--
Jens Axboe
nswer is "NO, user-space can't handle all the stuff the kernel can"
> then we should document it. This is really device independent.
Completely agree, and honestly I'm pretty baffled we're even having
to argue this point.
--
Jens Axboe
On 11/09/2017 03:09 AM, Christoph Hellwig wrote:
> On Wed, Nov 08, 2017 at 09:13:59AM -0700, Jens Axboe wrote:
>> There are numerous valid reasons to be able to set the affinity, for
>> both nics and block drivers. It's great that the kernel has a predefined
>> layout tha
rivate and frequently changed, setting it at bootup to a
known good configuration helped eliminate problems when upgrading
kernels. I also remember some cases of removing CPU0 from the mask.
But that particular case is completely orthogonal to whether or not we
should allow the user to reconfigure.
On 08/31/2017 05:29 PM, Kees Cook wrote:
> Several timer users needlessly reset their .function/.data fields during
> their timer callback, but nothing else changes them. Some users do not
> use their .data field at all. Each instance is removed here.
For amiflop:
Acked-by: Jens Axboe
On 08/21/2017 05:43 AM, Bhumika Goyal wrote:
> Make this const as is is only passed as an argument to the
> function device_create_file and device_remove_file and the corresponding
> arguments are of type const.
> Done using Coccinelle
Added for 4.14, thanks.
--
Jens Axboe
>
> Both of these seem appropriately sized, and using snprintf()
> instead of sprintf() improves this by ensuring that even
> incorrect data won't cause undefined behavior here.
Thanks Arnd, added for 4.14.
--
Jens Axboe
On 05/04/2017 09:27 AM, Jens Axboe wrote:
> On 05/04/2017 09:25 AM, David Miller wrote:
>> From: Jens Axboe
>> Date: Thu, 4 May 2017 09:23:36 -0600
>>
>>> Running current -git on my laptop, and I see this spew every once
>>> in a while. This is new, haven&
On 05/04/2017 09:25 AM, David Miller wrote:
> From: Jens Axboe
> Date: Thu, 4 May 2017 09:23:36 -0600
>
>> Running current -git on my laptop, and I see this spew every once
>> in a while. This is new, haven't seen it in 4.11 or previously. Driver
>> is iwl
c R15: 01ffc570
[ 3285.978664] Code: d0 f7 e1 d1 ea 8d 14 92 01 d2 81 c2 50 c3 00 00 b9 c5 5a
7c 0a 5d c1 ea 05 89 d0 f7 e1 89 d0 c1 e8 07 c3 31 c0 40 80 fe 02 74 b6 <0f> ff
31 c0 eb b0 8d 14 52 01 d2 e9 41 ff ff ff 0f ff 31 c0 5d
[ 3285.978693] ---[ end trace ae08dfa326cc120a ]---
--
Jens Axboe
On May 1, 2017, at 7:37 PM, Stephen Rothwell wrote:
>
> Hi Jens,
>
>> On Mon, 1 May 2017 19:09:34 -0600 Jens Axboe wrote:
>>
>> Indeed, I have warned Linus about it. Thanks Stephen.
>
> Thanks.
>
> BTW, (unusually) I did not see your pull request(s) .
> On May 1, 2017, at 7:07 PM, Stephen Rothwell wrote:
>
> Hi all,
>
>> On Tue, 18 Apr 2017 13:02:29 +1000 Stephen Rothwell
>> wrote:
>>
>> After merging the block tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> drivers/block/nbd.c: In function 'nbd_genl_c
On 04/13/2017 01:42 PM, Dan Carpenter wrote:
> If "scope_len" is sizeof(scope_id) then we would put the NUL terminator
> one space beyond the end of the buffer.
Added, thanks Dan.
--
Jens Axboe
On 04/02/2017 07:41 AM, Sagi Grimberg wrote:
> Like pci and virtio, we add a rdma helper for affinity
> spreading. This achieves optimal mq affinity assignments
> according to the underlying rdma device affinity maps.
Reviewed-by: Jens Axboe
--
Jens Axboe
icient amount of differences between
networking and storage that I don't think a fully generic version is
really feasible. My favorite thing to bring up is the fact that we don't
have the luxury of dropping packets on the storage side...
--
Jens Axboe
On 12/10/2015 08:23 AM, Josh Poimboeuf wrote:
On Thu, Dec 10, 2015 at 08:10:34AM -0700, Jens Axboe wrote:
On 12/10/2015 07:17 AM, Geliang Tang wrote:
We already have list_is_last(), it makes sense to also add
list_is_first() for consistency. This list utility function
to check for first
x27;t really help, they hurt readability. You should know how
the list works anyway, and if you do, then it's a no-brainer what's
first and last. If you don't, then you are bound to screw up in other ways.
Just my 2 cents.
--
Jens Axboe
--
To unsubscribe from this list: send t
following
crash dump (partial) on my netconsole box.
[ 1434.266524] [ cut here ]
[ 1434.266643] WARNING: CPU: 2 PID: 179 at block/blk-merge.c:435
blk_rq_map_sg+0x2d9/0x2eb()
This is fixed in current -git, as of a few days ago.
--
Jens Axboe
--
To unsubscribe from this list
On 11/13/2015 02:44 PM, Nikolay Aleksandrov wrote:
On 11/13/2015 10:37 PM, Jens Axboe wrote:
Hi,
Tried to connect to sw vpn today, and it isn't working. Running git as-of
yesterday. In dmesg:
[23703.921542] vpn0: set_features() failed (-1); wanted 0x008048c1,
left 0x0080001
again. How do we get this fixed so that
4.4-rc1 doesn't break basic VPN support?
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d(&conn->dev) < 0) {
> BT_ERR("Failed to register connection device");
> return;
> @@ -313,6 +316,7 @@ void hci_conn_add_sysfs(struct hci_conn
>
> INIT_WORK(&conn->work, add_conn);
>
> + queue_work(btaddconn, &
It's fixed and merged, I just forgot to close the bugzilla. Did so now.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
I don't blame you, that function was definitely non-intuitive!
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 31 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 31 Oct 2007 09:14:28 +0100
>
> > Subject: [PATCH] [SG] Get rid of __sg_mark_end()
> >
> > sg_mark_end() overwrites the page_link information, but all users want
>
On Wed, Oct 31 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 31 Oct 2007 08:46:21 +0100
>
> > On Tue, Oct 30 2007, David Miller wrote:
> > > @@ -293,7 +293,7 @@ decryptor(struct scatterlist *sg, void *data)
> > > if
On Wed, Oct 31 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 31 Oct 2007 09:01:43 +0100
>
> > On Wed, Oct 31 2007, David Miller wrote:
> > > From: Jens Axboe <[EMAIL PROTECTED]>
> > > Date: Wed, 31 Oct 2007 08:46:21 +0
On Wed, Oct 31 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 31 Oct 2007 08:46:21 +0100
>
> > On Tue, Oct 30 2007, David Miller wrote:
> > > @@ -293,7 +293,7 @@ decryptor(struct scatterlist *sg, void *data)
> > > if
On Wed, Oct 31 2007, David Miller wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
> Date: Wed, 31 Oct 2007 08:32:07 +0100
>
> > [SG] Remove __sg_mark_end()
> >
> > Make sg_mark_end() NOT overwrite the page link. Then it can be used
> > after filling the s
, desc->outfrags,
desc->infrags, thislen);
if (ret)
return ret;
sg_init_table(desc->infrags, 4);
sg_init_table(desc->outfrags, 4);
...
Did something go wrong there?
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ld want. I've added such a
patch to the sg repo.
>From 5a0347663f51850eb52b89c4dcf6a714ea8d3965 Mon Sep 17 00:00:00 2001
From: Jens Axboe <[EMAIL PROTECTED]>
Date: Wed, 31 Oct 2007 08:31:23 +0100
Subject: [PATCH] [SG] Remove __sg_mark_end()
Make sg_mark_end() NOT overwrite the page l
On Tue, Oct 30 2007, Herbert Xu wrote:
> On Tue, Oct 30, 2007 at 06:50:58AM +0100, Jens Axboe wrote:
> >
> > How so? The reason you changed it to sg_init_table() + sg_set_buf() is
> > exactly because sg_init_one() didn't properly init the entry (as they
> > nam
On Tue, Oct 30 2007, Boaz Harrosh wrote:
> On Mon, Oct 29 2007 at 22:16 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> > On Fri, Oct 26 2007, Herbert Xu wrote:
> >> [CRYPTO] tcrypt: Move sg_init_table out of timing loops
> >>
> >> This patch moves the sg_i
On Tue, Oct 30 2007, Herbert Xu wrote:
> On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote:
> > On Fri, Oct 26 2007, Herbert Xu wrote:
> > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops
> > >
> > > This patch moves the sg_init_ta
unsigned int buflen)
+{
+ sg_init_table(sg, 1);
+ sg_set_buf(sg, buf, buflen);
+}
+
+/**
* sg_phys - Return physical address of an sg entry
* @sg: SG entry
*
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe netdev"
> > > git-block.patch
> > >...
> > > git trees
> > >...
> >
> > tcp_splice_data_recv() can become static.
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> I'll let Jens or similar pick this one up since it
On Mon, Aug 13 2007, Daniel Phillips wrote:
> On Monday 13 August 2007 03:06, Jens Axboe wrote:
> > On Mon, Aug 13 2007, Daniel Phillips wrote:
> > > Of course not. Nothing I said stops endio from being called in the
> > > usual way as well. For this to work, en
On Mon, Aug 13 2007, Daniel Phillips wrote:
> On Monday 13 August 2007 02:13, Jens Axboe wrote:
> > On Mon, Aug 13 2007, Daniel Phillips wrote:
> > > On Monday 13 August 2007 00:45, Jens Axboe wrote:
> > > > On Mon, Aug 13 2007, Jens Axboe wrote:
> > > >
On Mon, Aug 13 2007, Daniel Phillips wrote:
> On Monday 13 August 2007 00:45, Jens Axboe wrote:
> > On Mon, Aug 13 2007, Jens Axboe wrote:
> > > > You did not comment on the one about putting the bio destructor
> > > > in the ->endio handler, which looks dead si
On Mon, Aug 13 2007, Daniel Phillips wrote:
> On Monday 13 August 2007 00:28, Jens Axboe wrote:
> > On Sun, Aug 12 2007, Daniel Phillips wrote:
> > > Right, that is done by bi_vcnt. I meant bi_max_vecs, which you can
> > > derive efficiently from BIO_POOL
On Mon, Aug 13 2007, Jens Axboe wrote:
> > You did not comment on the one about putting the bio destructor in
> > the ->endio handler, which looks dead simple. The majority of cases
> > just use the default endio handler and the default destructor. Of the
> &g
On Sun, Aug 12 2007, Daniel Phillips wrote:
> On Tuesday 07 August 2007 13:55, Jens Axboe wrote:
> > I don't like structure bloat, but I do like nice design. Overloading
> > is a necessary evil sometimes, though. Even today, there isn't enough
> > room to hold
On Tue, Aug 07 2007, Daniel Phillips wrote:
> On Tuesday 07 August 2007 05:05, Jens Axboe wrote:
> > On Sun, Aug 05 2007, Daniel Phillips wrote:
> > > A simple way to solve the stable accounting field issue is to add a
> > > new pointer to struct bio that is owned
ious fields
struct bio has?
And we don't add temporary fields out of laziness, hoping that "someone"
will later kill it again and rewrite it in a nicer fashion. Hint: that
never happens, bloat sticks.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscr
On Tue, Jul 24 2007, Jens Axboe wrote:
> On Mon, Jul 23 2007, Andrew Morton wrote:
> > I worked out that the crash I saw was in
> >
> > BUG_ON(!pte_none(*(kmap_pte-idx)));
> >
> > in the read of kmap_pte[idx]. Which would be weird as the caller
ic() takes the virtual address, not the mapped page as
argument.
Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 5727cd1..c4034f6 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2153,7 +2153,7 @@ static int ocfs2_splice_write_actor(s
On Thu, Jul 19 2007, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> Hello.
>
> In article <[EMAIL PROTECTED]> (at Wed, 11 Jul 2007 11:19:27 +0200), Jens
> Axboe <[EMAIL PROTECTED]> says:
>
> > @@ -835,6 +835,7 @@ const struct proto_ops ine
On Wed, Jul 18 2007, Johannes Berg wrote:
> On Mon, 2007-07-16 at 14:02 +0200, Jens Axboe wrote:
>
> > Yep, it's a sender thing, so upgrading the receiver will not change
> > anything.
>
> Ok, I upgraded, but that didn't help. And in fact, I don't see ho
1 - 100 of 167 matches
Mail list logo
