On 8/21/20 2:41 PM, Jakub Kicinski wrote: > On Thu, 20 Aug 2020 16:49:54 -0700 Luke Hsiao wrote: >> + /* If reading from MSG_ERRQUEUE using recvmsg, ignore POLLIN */ >> + if (req->opcode == IORING_OP_RECVMSG && (sqe->msg_flags & MSG_ERRQUEUE)) >> + mask &= ~(POLLIN); > > FWIW this adds another W=1 C=1 warnings to this code: > > fs/io_uring.c:4940:22: warning: invalid assignment: &= > fs/io_uring.c:4940:22: left side has type restricted __poll_t > fs/io_uring.c:4940:22: right side has type int
Well, 8 or 9 of them don't really matter... This is something that should be cleaned up separately at some point. > And obviously the brackets around POLLIN are not necessary. Agree, would be cleaner without! Luke, with that: Reviewed-by: Jens Axboe <ax...@kernel.dk> -- Jens Axboe
