On Fri, Apr 2, 2021 at 10:12 PM Cong Wang wrote:
>
> On Wed, Mar 31, 2021 at 11:01 PM John Fastabend
> wrote:
> > This 'else if' is always true if above is false right? Would be
> > impler and clearer IMO as,
> >
> >if (used <= 0) {
> > if (!copied)
> >
In iwl_txq_dyn_alloc_dma, txq->tfds is freed at first time by:
iwl_txq_alloc()->goto err_free_tfds->dma_free_coherent(). But
it forgot to set txq->tfds to NULL.
Then the txq->tfds is freed again in iwl_txq_dyn_alloc_dma by:
goto error->iwl_txq_gen2_free_memory()->dma_free_coherent().
My patch set
From: Cong Wang
These comments in udp_bpf_update_proto() are copied from the
original TCP code and apparently do not apply to UDP. Just
remove them.
Reported-by: Jakub Sitnicki
Cc: John Fastabend
Cc: Daniel Borkmann
Cc: Lorenz Bauer
Signed-off-by: Cong Wang
---
net/ipv4/udp_bpf.c | 2 --
1
On Fri, Apr 2, 2021 at 3:16 AM Jakub Sitnicki wrote:
> > -struct proto *udp_bpf_get_proto(struct sock *sk, struct sk_psock *psock)
> > +int udp_bpf_update_proto(struct sock *sk, bool restore)
> > {
> > int family = sk->sk_family == AF_INET ? UDP_BPF_IPV4 : UDP_BPF_IPV6;
> > + struct sk_
On Wed, Mar 31, 2021 at 11:01 PM John Fastabend
wrote:
> This 'else if' is always true if above is false right? Would be
> impler and clearer IMO as,
>
>if (used <= 0) {
> if (!copied)
> copied = used;
>
Hello,
syzbot found the following issue on:
HEAD commit:1e43c377 Merge tag 'xtensa-20210329' of git://github.com/j..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=114cdd4ad0
kernel config: https://syzkaller.appspot.com/x/.config?x=78ef1d159159890
dash
Code to defer the reset(which caps the frequency of the reset) schedules the
timer and returns. Hence, following 'else-if' looks un-necessary.
Fixes: 9de0b86f6444 ("net: hns3: Prevent to request reset frequently")
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ma
This removes the left over check and assignment which is no longer used
anywhere in the function and should have been removed as part of the
below mentioned patch.
Fixes: 012fcb52f67c ("net: hns3: activate reset timer when calling reset_event")
Signed-off-by: Salil Mehta
---
drivers/net/ethernet
Fixes for the miscellaneous problems found during the review of the code.
Salil Mehta (2):
net: hns3: Remove the left over redundant check & assignment
net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +++---
1 fi
On 3/31/21 10:03 PM, Chunmei Xu wrote:
> since id is unique for nexthop, it is heavy to dump all nexthops.
> use existing delete_nexthop to support flush by id
>
> Signed-off-by: Chunmei Xu
> ---
> ip/ipnexthop.c | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
th
On 3/31/21 8:34 PM, Hoang Le wrote:
> To avoid code duplication, tipc should be converted to use the helper
> functions for working with libmnl in lib/mnl_utils.c
>
> Acked-by: Jon Maloy
> Signed-off-by: Hoang Le
> ---
> tipc/bearer.c| 38 ++
> tipc/cmdl.c | 2 -
> tipc/
The tracing test and the recent kfunc call test require
CONFIG_DYNAMIC_FTRACE. This patch adds it to the config file.
Signed-off-by: Martin KaFai Lau
---
tools/testing/selftests/bpf/config | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/config
b/tools/testing/se
On Sun, Mar 14, 2021 at 02:42:52PM +0200, Leon Romanovsky wrote:
> -
> Changelog
> v8:
> * Added "physical/virtual function" words near PF and VF acronyms.
> v7: https://lore.kernel.org/linux-pci/20210301075524.441609-
Possible subject, since this adds *two* files, not just "a file":
PCI/IOV: Add sysfs MSI-X vector assignment interface
On Sun, Mar 14, 2021 at 02:42:53PM +0200, Leon Romanovsky wrote:
> A typical cloud provider SR-IOV use case is to create many VFs for use by
> guest VMs. The VFs may not be ass
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Fri, 2 Apr 2021 09:26:34 +0800 you wrote:
> Remove redundant semi-colon in infinalize_btf_ext().
>
> Signed-off-by: Yang Yingliang
> ---
> v2:
> add commit log
>
> [...]
Here is the summary with links:
- [-next,v2]
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Thu, 1 Apr 2021 14:46:37 +0800 you wrote:
> struct bpf_prog is declared twice. There is one declaration
> which is independent on the MACRO at 18th line.
> So the below one is not needed though. Remove the duplicate.
>
>
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 31 Mar 2021 07:51:35 + you wrote:
> 'stack' parameter is not used in ___bpf_prog_run,
> the base address have been set to FP reg. So consequently remove it.
>
> Signed-off-by: He Fengqing
> ---
> kernel/bpf/core
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Thu, 1 Apr 2021 15:20:37 +0800 you wrote:
> struct btf_type is declared twice. One is declared at 35th line.
> The blew one is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
> ---
> include/linux/bpf.h
On Fri, Apr 02, 2021 at 02:24:51PM -0700, Cong Wang wrote:
> > > where the key is the timer ID and the value is the timer expire
> > > timer.
> >
> > The timer ID is unnecessary. We cannot introduce new IDR for every new
> > bpf object. It doesn't scale.
>
> The IDR is per map, not per timer.
Per
> On Apr 2, 2021, at 1:57 PM, Cong Wang wrote:
>
> On Fri, Apr 2, 2021 at 12:45 PM Song Liu wrote:
>>
>>
>>
>>> On Apr 2, 2021, at 12:08 PM, Cong Wang wrote:
>>>
>>> On Fri, Apr 2, 2021 at 10:57 AM Song Liu wrote:
> On Apr 2, 2021, at 10:34 AM, Cong Wang wrote:
>>
On Wed, Mar 31, 2021 at 9:41 AM Vlad Buslov wrote:
>
> With recent changes that separated action module load from action
> initialization tcf_action_init() function error handling code was modified
> to manually release the loaded modules if loading/initialization of any
> further action in same b
> > The code is relying on the identical layout of the beginning
> > of the v0 and v1 structs, but this can easily lead to code bugs
> > if one were to try to extend this further...
>
> What is the concern? These structs are part of ABI, they
> cannot be changed.
That is a reasonable point, but t
On Wed, Mar 31, 2021 at 9:41 AM Vlad Buslov wrote:
>
> Action init code increments reference counter when it changes an action.
> This is the desired behavior for cls API which needs to obtain action
> reference for every classifier that points to action. However, act API just
> needs to change th
On 02/04/2021 23:31, Christophe JAILLET wrote:
'get_tid_h()' is the same as 'ieee80211_get_tid()'.
So this function can be removed to save a few lines of code.
Signed-off-by: Christophe JAILLET
Acked-by: Christian Lamparter
---
drivers/net/wireless/ath/carl9170/carl9170.h | 7 +--
dr
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 2 Apr 2021 11:10:37 -0700 you wrote:
> From: Eric Dumazet
>
> Group all the often used fields in the first cache line,
> to reduce cache line misses.
>
> Signed-off-by: Eric Dumazet
>
> [...]
Here is the summ
Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> The code is relying on the identical layout of the beginning
> of the v0 and v1 structs, but this can easily lead to code bugs
> if one were to try to extend this further...
What is the concern? These structs are part of ABI, they
cann
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 2 Apr 2021 15:42:53 +0300 you wrote:
> Restore CMP screener registers on resume path.
>
> Fixes: c1e85c6ce57ef ("net: macb: save/restore the remaining registers and
> features")
> Signed-off-by: Claudiu Beznea
> ---
>
'get_tid_h()' is the same as 'ieee80211_get_tid()'.
So this function can be removed to save a few lines of code.
Signed-off-by: Christophe JAILLET
---
drivers/net/wireless/ath/carl9170/carl9170.h | 7 +--
drivers/net/wireless/ath/carl9170/tx.c | 2 +-
2 files changed, 2 insertions(+),
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 2 Apr 2021 14:44:42 +0300 you wrote:
> If the "type_a->nfcid_len" is too large then it would lead to memory
> corruption in pn533_target_found_type_a() when we do:
>
> memcpy(nfc_tgt->nfcid1, tgt_type_a->nfci
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 1 Apr 2021 10:55:58 -0700 you wrote:
> This patchset adds support for accessing the DSC hardware clock and
> for offloading PTP timestamping.
>
> Tx packet timestamping happens through a separate Tx queue set up
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 1 Apr 2021 16:19:40 -0700 you wrote:
> Here is a collection of patches from the MPTCP tree:
>
>
> Patches 1 and 2 add some helpful MIB counters for connection
> information.
>
> Patch 3 cleans up some unnecessa
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 2 Apr 2021 12:55:29 +0300 you wrote:
> From: Ioana Ciornei
>
> DMA unmapping, allocating a new buffer and DMA mapping it back on the
> refill path is really not that efficient. Proper buffer recycling (page
> po
On Fri, Apr 2, 2021 at 12:28 PM Alexei Starovoitov
wrote:
>
> On Wed, Mar 31, 2021 at 09:26:35PM -0700, Cong Wang wrote:
>
> > This patch introduces a bpf timer map and a syscall to create bpf timer
> > from user-space.
>
> That will severely limit timer api usability.
> I agree with Song here. If
On 4/2/21 10:53 PM, Eric Dumazet wrote:
>
>
> On 4/2/21 8:10 PM, Phillip Potter wrote:
>> On Fri, Apr 02, 2021 at 07:49:44PM +0200, Eric Dumazet wrote:
>>>
>>>
>>> On 4/2/21 7:36 PM, Phillip Potter wrote:
Use memset to initialize two local buffers in net/ipv6/mcast.c,
and another in
On Fri, Apr 2, 2021 at 12:45 PM Song Liu wrote:
>
>
>
> > On Apr 2, 2021, at 12:08 PM, Cong Wang wrote:
> >
> > On Fri, Apr 2, 2021 at 10:57 AM Song Liu wrote:
> >>
> >>
> >>
> >>> On Apr 2, 2021, at 10:34 AM, Cong Wang wrote:
> >>>
> >>> On Thu, Apr 1, 2021 at 1:17 PM Song Liu wrote:
>
>
On 4/2/21 8:10 PM, Phillip Potter wrote:
> On Fri, Apr 02, 2021 at 07:49:44PM +0200, Eric Dumazet wrote:
>>
>>
>> On 4/2/21 7:36 PM, Phillip Potter wrote:
>>> Use memset to initialize two local buffers in net/ipv6/mcast.c,
>>> and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value
>>>
From: Maciej Żenczykowski
(this is needed at least with bionic)
Signed-off-by: Maciej Żenczykowski
---
libxtables/xtables.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libxtables/xtables.c b/libxtables/xtables.c
index bc42ba82..77bc18f6 100644
--- a/libxtables/xtables.c
+++ b/libxtable
On Fri, 2 Apr 2021 11:10:37 -0700
Eric Dumazet wrote:
> From: Eric Dumazet
>
> Group all the often used fields in the first cache line,
> to reduce cache line misses.
>
> Signed-off-by: Eric Dumazet
Makes sense.
Acked-by: Stephen Hemminger
From: Maciej Żenczykowski
The code is relying on the identical layout of the beginning
of the v0 and v1 structs, but this can easily lead to code bugs
if one were to try to extend this further...
I use:
char (*plabel)[MAX_IDLETIMER_LABEL_SIZE]
instead of:
char label[MAX_IDLETIMER_LABEL_SIZE]
Tx queue cleanup happens in interrupt handler on same core as rx queue
processing.
Both can take considerable amount of processing in high
packet-per-second scenarios.
Sending big amounts of packets can stall the rx processing which is
unfair
and also can lead to to out-of-memory condition sin
> On Apr 2, 2021, at 12:08 PM, Cong Wang wrote:
>
> On Fri, Apr 2, 2021 at 10:57 AM Song Liu wrote:
>>
>>
>>
>>> On Apr 2, 2021, at 10:34 AM, Cong Wang wrote:
>>>
>>> On Thu, Apr 1, 2021 at 1:17 PM Song Liu wrote:
> On Apr 1, 2021, at 10:28 AM, Cong Wang wrote:
>>
On 4/2/21 12:25 PM, Jiri Kosina wrote:
On Thu, 3 Sep 2020, John Fastabend wrote:
At this point I fear we could consider reverting the NOLOCK stuff.
I personally would hate doing so, but it looks like NOLOCK benefits are
outweighed by its issues.
I agree, NOLOCK brings more pains than gains. T
On Wed, Mar 31, 2021 at 09:26:35PM -0700, Cong Wang wrote:
> This patch introduces a bpf timer map and a syscall to create bpf timer
> from user-space.
That will severely limit timer api usability.
I agree with Song here. If user space has to create it there is no reason
to introduce new sys_bpf
On Thu, 3 Sep 2020, John Fastabend wrote:
> > > At this point I fear we could consider reverting the NOLOCK stuff.
> > > I personally would hate doing so, but it looks like NOLOCK benefits are
> > > outweighed by its issues.
> >
> > I agree, NOLOCK brings more pains than gains. There are many rac
On Fri, Apr 2, 2021 at 10:57 AM Song Liu wrote:
>
>
>
> > On Apr 2, 2021, at 10:34 AM, Cong Wang wrote:
> >
> > On Thu, Apr 1, 2021 at 1:17 PM Song Liu wrote:
> >>
> >>
> >>
> >>> On Apr 1, 2021, at 10:28 AM, Cong Wang wrote:
> >>>
> >>> On Wed, Mar 31, 2021 at 11:38 PM Song Liu wrote:
>
On Sat, Apr 03, 2021 at 12:02:14AM IST, Alexei Starovoitov wrote:
> On Fri, Apr 2, 2021 at 8:27 AM Kumar Kartikeya Dwivedi
> wrote:
> > [...]
>
> All of these things are messy because of tc legacy. bpf tried to follow tc
> style
> with cls and act distinction and it didn't quite work. cls with
>
On Fri, Apr 2, 2021 at 8:27 AM Kumar Kartikeya Dwivedi wrote:
>
> This would be fine, because it's not a fast path or anything, but right now we
> return the id using the netlink response, otherwise for query we have to open
> the socket, prepare the msg, send and recv again. So it's a minor
> op
In mwl8k_probe_hw, hw->priv->txq is freed at the first time by
dma_free_coherent() in the call chain:
if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i).
Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed
at the second time by mwl8k_txq_deinit(hw, i)->dma_free_coherent().
From: Matteo Croce
Use the new recycling API for page_pool.
In a drop rate test, the packet rate increased di 10%,
from 269 Kpps to 296 Kpps.
perf top on a stock system shows:
Overhead Shared Object Symbol
21.78% [kernel] [k] __pi___inval_dcache_area
21.66% [mvneta]
On 4/2/21 7:20 PM, Gatis Peisenieks wrote:
> Tx queue cleanup happens in interrupt handler on same core as rx queue
> processing.
> Both can take considerable amount of processing in high packet-per-second
> scenarios.
>
...
> @@ -2504,6 +2537,7 @@ static int atl1c_init_netdev(struct net_de
From: Matteo Croce
Use the new recycling API for page_pool.
In a drop rate test, the packet rate is more than doubled,
from 962 Kpps to 2047 Kpps.
perf top on a stock system shows:
Overhead Shared Object Symbol
30.67% [kernel] [k] page_pool_release_page
8.37% [kernel]
From: Ilias Apalodimas
Up to now several high speed NICs have custom mechanisms of recycling
the allocated memory they use for their payloads.
Our page_pool API already has recycling capabilities that are always
used when we are running in 'XDP mode'. So let's tweak the API and the
kernel networ
On Fri, 2 Apr 2021 at 17:43, Greg KH wrote:
>
> On Fri, Apr 02, 2021 at 05:41:01PM +0200, Loic Poulain wrote:
> > On Fri, 2 Apr 2021 at 16:05, Greg KH wrote:
> > >
> > > On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote:
> > > > The MHI WWWAN control driver allows MHI QCOM-based modems
From: Matteo Croce
This is needed by the page_pool to avoid recycling a page not allocated
via page_pool.
Signed-off-by: Matteo Croce
---
include/linux/mm_types.h | 1 +
include/net/page_pool.h | 2 ++
net/core/page_pool.c | 4
3 files changed, 7 insertions(+)
diff --git a/include/l
From: Jesper Dangaard Brouer
It is possible to compress/reduce the size of struct xdp_mem_info.
This change reduce struct xdp_mem_info from 8 bytes to 4 bytes.
The member xdp_mem_info.id can be reduced to u16, as the mem_id_ht
rhashtable in net/core/xdp.c is already limited by MEM_ID_MAX=0xFFFE
From: Matteo Croce
This is a respin of [1]
This patchset shows the plans for allowing page_pool to handle and
maintain DMA map/unmap of the pages it serves to the driver. For this
to work a return hook in the network core is introduced.
The overall purpose is to simplify drivers, by providing
From: Eric Dumazet
Group all the often used fields in the first cache line,
to reduce cache line misses.
Signed-off-by: Eric Dumazet
---
include/net/tcp.h | 42 +++---
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/include/net/tcp.h b/includ
On Fri, Apr 02, 2021 at 07:49:44PM +0200, Eric Dumazet wrote:
>
>
> On 4/2/21 7:36 PM, Phillip Potter wrote:
> > Use memset to initialize two local buffers in net/ipv6/mcast.c,
> > and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value
> > bug reported by syzbot at:
> > https://syzkalle
From: Eric Dumazet
Order fields to increase locality for most used protocols.
udplite and icmp are moved at the end.
Same for proc_net_devsnmp6 which is not used in fast path.
This potentially saves one cache line miss for typical TCP/UDP over IPv4/IPv6.
Signed-off-by: Eric Dumazet
---
incl
On 4/2/21 7:20 PM, Gatis Peisenieks wrote:
> Tx queue cleanup happens in interrupt handler on same core as rx queue
> processing.
> Both can take considerable amount of processing in high packet-per-second
> scenarios.
>
> Sending big amounts of packets can stall the rx processing which is un
Hi Loic,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
: kernel test robot
---
url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
bd78980be1a68d14524c51c4b4170782fada622b
wwan_core.c |2 +-
1 file changed, 1 insertion(+), 1
> On Apr 2, 2021, at 10:34 AM, Cong Wang wrote:
>
> On Thu, Apr 1, 2021 at 1:17 PM Song Liu wrote:
>>
>>
>>
>>> On Apr 1, 2021, at 10:28 AM, Cong Wang wrote:
>>>
>>> On Wed, Mar 31, 2021 at 11:38 PM Song Liu wrote:
> On Mar 31, 2021, at 9:26 PM, Cong Wang wrote:
>
On 4/2/21 7:36 PM, Phillip Potter wrote:
> Use memset to initialize two local buffers in net/ipv6/mcast.c,
> and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value
> bug reported by syzbot at:
> https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51
According t
In bcm4908_enet_dma_alloc, if callee bcm4908_dma_alloc_buf_descs() failed,
it will free the ring->cpu_addr by dma_free_coherent() and return error.
Then bcm4908_enet_dma_free() will be called, and free the same cpu_addr
by dma_free_coherent() again.
My patch set ring->cpu_addr to NULL after it is
On 02/04/2021 at 14:42, Claudiu Beznea wrote:
Restore CMP screener registers on resume path.
Fixes: c1e85c6ce57ef ("net: macb: save/restore the remaining registers and
features")
Signed-off-by: Claudiu Beznea
Acked-by: Nicolas Ferre
Thanks for this fix Claudiu. Best regards,
Nicolas
--
Use memset to initialize two local buffers in net/ipv6/mcast.c,
and another in net/ipv4/igmp.c. Fixes a KMSAN found uninit-value
bug reported by syzbot at:
https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51
Reported-by: syzbot+001516d86dbe88862...@syzkaller.appspotmail.c
On Thu, Apr 1, 2021 at 1:17 PM Song Liu wrote:
>
>
>
> > On Apr 1, 2021, at 10:28 AM, Cong Wang wrote:
> >
> > On Wed, Mar 31, 2021 at 11:38 PM Song Liu wrote:
> >>
> >>
> >>
> >>> On Mar 31, 2021, at 9:26 PM, Cong Wang wrote:
> >>>
> >>> From: Cong Wang
> >>>
> >>> (This patch is still in ear
On Mon 15 Mar 11:16 CDT 2021, Alex Elder wrote:
> On 3/15/21 10:46 AM, Bjorn Andersson wrote:
> > Parse and pass IFLA_RMNET_FLAGS to the kernel, to allow changing the
> > flags from the default of ingress-aggregate only.
>
> To be clear, this default is implemented in the kernel RMNet
> driver, n
Tx queue cleanup happens in interrupt handler on same core as rx queue
processing.
Both can take considerable amount of processing in high
packet-per-second scenarios.
Sending big amounts of packets can stall the rx processing which is
unfair
and also can lead to to out-of-memory condition sin
'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'.
So this function can be removed to save a line of code.
Signed-off-by: Christophe JAILLET
---
drivers/net/wireless/realtek/rtlwifi/wifi.h | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/realtek
On Fri, Apr 02, 2021 at 10:20:14AM +0200, Christian Brauner wrote:
> > @@ -11043,6 +11046,11 @@ int dev_change_net_namespace(struct net_device
> > *dev, struct net *net, const char
> > goto out;
> > }
> >
> > + /* Check that new_ifindex isn't used yet. */
> > + err =
Restore CMP screener registers on resume path.
Fixes: c1e85c6ce57ef ("net: macb: save/restore the remaining registers and
features")
Signed-off-by: Claudiu Beznea
---
drivers/net/ethernet/cadence/macb_main.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/cadence
On Thu, Apr 1, 2021 at 5:33 PM Russell King - ARM Linux admin
wrote:
>
> Hi,
>
> I hadn't responded earlier because I wanted to think about it more,
> but then forgot about this email.
>
> On Thu, Mar 25, 2021 at 11:36:26AM -0500, George McCollister wrote:
> > When I set port 9 on an mv88e6390, a
Hi Loic,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/net-Add-a-WWAN-subsystem/20210402-220002
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
On 02/04/2021 14:15, samirweng1979 wrote:
> From: wengjianfeng
>
> In function s3fwrn5_nci_post_setup, The variable ret is assigned to 0,
> then goto out label, but just return ret in out label, so we use
> return 0 to replace it. and other goto sentences are similar, we use
> return sentences to
On Fri, Apr 02, 2021 at 05:41:01PM +0200, Loic Poulain wrote:
> On Fri, 2 Apr 2021 at 16:05, Greg KH wrote:
> >
> > On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote:
> > > The MHI WWWAN control driver allows MHI QCOM-based modems to expose
> > > different modem control protocols/ports
On Fri, 2 Apr 2021 at 16:05, Greg KH wrote:
>
> On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote:
> > The MHI WWWAN control driver allows MHI QCOM-based modems to expose
> > different modem control protocols/ports via the WWAN framework, so that
> > userspace modem tools or daemon (e.g
On Fri, Apr 02, 2021 at 05:49:29AM IST, Daniel Borkmann wrote:
> On 3/31/21 11:44 AM, Kumar Kartikeya Dwivedi wrote:
> > On Wed, Mar 31, 2021 at 02:55:47AM IST, Daniel Borkmann wrote:
> > > Do we even need the _block variant? I would rather prefer to take the
> > > chance
> > > and make it as simp
On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote:
> The MHI WWWAN control driver allows MHI QCOM-based modems to expose
> different modem control protocols/ports via the WWAN framework, so that
> userspace modem tools or daemon (e.g. ModemManager) can control WWAN
> config and state (AP
On Fri, Apr 02, 2021 at 04:06:36PM +0200, Loic Poulain wrote:
> This change introduces initial support for a WWAN framework. Given the
> complexity and heterogeneity of existing WWAN hardwares and interfaces,
> there is no strict definition of what a WWAN device is and how it should
> be represente
The MHI WWWAN control driver allows MHI QCOM-based modems to expose
different modem control protocols/ports via the WWAN framework, so that
userspace modem tools or daemon (e.g. ModemManager) can control WWAN
config and state (APN config, SMS, provider selection...). A QCOM-based
modem can expose o
This change introduces initial support for a WWAN framework. Given the
complexity and heterogeneity of existing WWAN hardwares and interfaces,
there is no strict definition of what a WWAN device is and how it should
be represented. It's often a collection of multiple devices that perform
the global
From: Eric Dumazet
Xuan Zhuo reported that commit 3226b158e67c ("net: avoid 32 x truesize
under-estimation for tiny skbs") brought a ~10% performance drop.
The reason for the performance drop was that GRO was forced
to chain sk_buff (using skb_shinfo(skb)->frag_list), which
uses more memory but
On Fri, Apr 02, 2021 at 03:10:49AM +0200, Danilo Krummrich wrote:
> On Thu, Apr 01, 2021 at 09:48:58AM +0100, Russell King - ARM Linux admin
> wrote:
> > Do you actually have a requirement for this?
> >
> Yes, the Marvell 88Q2112 1000Base-T1 PHY. But actually, I just recognize that
> it
> should
On Wed, Mar 31, 2021 at 05:30:50PM +0200, Loic Poulain wrote:
> > As it is, the code you have here just implements the misc device layer,
> > but with a new major number? why???
>
> Right, Instead of creating yet another specific character driver for
> WWAN (like usb wdm_class), the goal would be
On Fri, Apr 02, 2021 at 12:55:31PM +0300, Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> DMA unmapping, allocating a new buffer and DMA mapping it back on the
> refill path is really not that efficient. Proper buffer recycling (page
> pool, flipping the page and using the other half) cannot be do
On Fri, Apr 02, 2021 at 07:45:04AM +, Voon, Weifeng wrote:
> > > + /* 2.5G mode only support 2500baseT full duplex only */
> > > + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) {
> > > + phylink_set(mac_supported, 2500baseT_Full);
> > > + phylink_set(mask, 10baseT_Half
> > Do you actually have a requirement for this?
> >
> Yes, the Marvell 88Q2112 1000Base-T1 PHY. But actually, I just recognize that
> it
> should be possible to just register it with the compatible string
> "ethernet-phy-ieee802.3-c22" instead of "ethernet-phy-ieee802.3-c45", this
> should result
Function ath9k_hw_reset() is dereferencing chan structure pointer, so it
needs to be non-NULL pointer.
Function ath9k_stop() already contains code which sets ah->curchan to valid
non-NULL pointer prior calling ath9k_hw_reset() function.
Add same code pattern also into ath_reset_internal() functio
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this
test there are 3 forward groups and 1 exclude group. The test will
redirect each interface's packets to all the interfaces in the forward
group, and exclude the interface in exclude map.
Two maps (DEVMAP, DEVMAP_HASH) and two xdp
This is a sample for xdp redirect broadcast. In the sample we could forward
all packets between given interfaces. There is also an option -X that could
enable 2nd xdp_prog on egress interface.
Signed-off-by: Hangbin Liu
---
samples/bpf/Makefile | 3 +
samples/bpf/xdp_redir
This patch add two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend
xdp_redirect_map for broadcast support.
Keep the general data path in net/core/filter.c and the native data
path in kernel/bpf/devmap.c so we can use direct calls to get better
performace.
Here is the performance result
From: Jesper Dangaard Brouer
This changes the devmap XDP program support to run the program when the
bulk queue is flushed instead of before the frame is enqueued. This has
a couple of benefits:
- It "sorts" the packets by destination devmap entry, and then runs the
same BPF program on all the
Hi,
This patchset is a new implementation for XDP multicast support based
on my previous 2 maps implementation[1]. The reason is that Daniel think
the exclude map implementation is missing proper bond support in XDP context.
And there is a plan to add native XDP bonding support. Adding a exclude m
From: wengjianfeng
In function s3fwrn5_nci_post_setup, The variable ret is assigned to 0,
then goto out label, but just return ret in out label, so we use
return 0 to replace it. and other goto sentences are similar, we use
return sentences to replace it and delete out label.
Signed-off-by: weng
If the "type_a->nfcid_len" is too large then it would lead to memory
corruption in pn533_target_found_type_a() when we do:
memcpy(nfc_tgt->nfcid1, tgt_type_a->nfcid_data, nfc_tgt->nfcid1_len);
Fixes: c3b1e1e8a76f ("NFC: Export NFCID1 from pn533")
Signed-off-by: Dan Carpenter
---
drivers
On Thu, Apr 01, 2021 at 10:38:21PM +0300, Vladimir Oltean wrote:
> On Thu, Apr 01, 2021 at 08:01:42PM +0200, Toke Høiland-Jørgensen wrote:
> > Vladimir Oltean writes:
> >
> > > On Thu, Apr 01, 2021 at 01:39:05PM +0200, Toke Høiland-Jørgensen wrote:
> > >> Vladimir Oltean writes:
> > >>
> > >> >
Delete unneeded variable initialization.
Signed-off-by: Kai Ye
---
net/bluetooth/6lowpan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index cff4944..ee4b0ec 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan
The issue happens only at appropriate circumstances, in my case I
faced it only while running crash kernel, when basic kernel worked
fine. The code inspection has shown tx_current_fill counter overflow,
after one packet or couple packets were sent. That's because tx
cleanup tasklet dequeued bunch o
1 - 100 of 112 matches
Mail list logo
