From: Cong Wang <[email protected]> These comments in udp_bpf_update_proto() are copied from the original TCP code and apparently do not apply to UDP. Just remove them.
Reported-by: Jakub Sitnicki <[email protected]> Cc: John Fastabend <[email protected]> Cc: Daniel Borkmann <[email protected]> Cc: Lorenz Bauer <[email protected]> Signed-off-by: Cong Wang <[email protected]> --- net/ipv4/udp_bpf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv4/udp_bpf.c b/net/ipv4/udp_bpf.c index 7d5c4ebf42fe..4a7e38c5d842 100644 --- a/net/ipv4/udp_bpf.c +++ b/net/ipv4/udp_bpf.c @@ -110,7 +110,6 @@ int udp_bpf_update_proto(struct sock *sk, bool restore) if (restore) { sk->sk_write_space = psock->saved_write_space; - /* Pairs with lockless read in sk_clone_lock() */ WRITE_ONCE(sk->sk_prot, psock->sk_proto); return 0; } @@ -118,7 +117,6 @@ int udp_bpf_update_proto(struct sock *sk, bool restore) if (sk->sk_family == AF_INET6) udp_bpf_check_v6_needs_rebuild(psock->sk_proto); - /* Pairs with lockless read in sk_clone_lock() */ WRITE_ONCE(sk->sk_prot, &udp_bpf_prots[family]); return 0; } -- 2.25.1
