Re: [PATCH] docs: networking: bonding.rst Fix a typo in bonding.rst

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 1 Mar 2021 21:28:23 +0900 you wrote: > This patch fixes a spelling typo in bonding.rst. > > Signed-off-by: Masanari Iida > --- > Documentation/networking/bonding.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

[regression] Kernel panic on resume from sleep

2021-03-01 Thread Zbynek Michl
Hello, Can anybody help me with the following kernel issue? https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983595 Do I understand it correctly that the kernel crashes due to the bug in the alx driver? Thank you Zbynek

Re: [PATCH] inetpeer: use div64_ul() and clamp_val() calculate inet_peer_threshold

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 1 Mar 2021 14:05:48 +0800 you wrote: > In inet_initpeers(), struct inet_peer on IA32 uses 128 bytes in nowdays. > Get rid of the cascade and use div64_ul() and clamp_val() calculate that > will not need to be adjusted i

Re: [PATCH v3 net 0/8] Fixes for NXP ENETC driver

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 1 Mar 2021 13:18:10 +0200 you wrote: > From: Vladimir Oltean > > This contains an assorted set of fixes collected over the past 2 weeks > on the enetc driver. Some are related to VLAN processing, some to > physical l

Re: [PATCH v4] net/qrtr: fix __netdev_alloc_skb call

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 1 Mar 2021 02:22:40 +0300 you wrote: > syzbot found WARNING in __alloc_pages_nodemask()[1] when order >= MAX_ORDER. > It was caused by a huge length value passed from userspace to > qrtr_tun_write_iter(), > which tries

Re: [PATCH net 0/3] Fix TRSCER masks in the Ether driver

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Sun, 28 Feb 2021 23:24:16 +0300 you wrote: > Here are 3 patches against DaveM's 'net' repo. I'm fixing the TRSCER masks in > the driver to match the manuals... > > [1/3] sh_eth: fix TRSCER mask for SH771x > [2/3] sh_eth: fi

Re: [PATCH] atm: lanai: dont run lanai_dev_close if not open

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 27 Feb 2021 22:55:50 -0500 you wrote: > lanai_dev_open() can fail. When it fail, lanai->base is unmapped and the > pci device is disabled. The caller, lanai_init_one(), then tries to run > atm_dev_deregister(). This will

Re: [PATCH] atm: eni: dont release is never initialized

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 27 Feb 2021 16:15:06 -0500 you wrote: > label err_eni_release is reachable when eni_start() fail. > In eni_start() it calls dev->phy->start() in the last step, if start() > fail we don't need to call phy->stop(), if star

Re: [PATCH V2 net] net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 27 Feb 2021 11:05:58 +0800 you wrote: > From: Guangbin Huang > > If phy uses generic driver and autoneg is on, enter command > "ethtool -s eth0 speed 50" will not change phy speed actually, but > command "ethtool eth0"

Re: [PATCH v3] net: usb: qmi_wwan: support ZTE P685M modem

2021-03-01 Thread Lech Perczak
On 2021-02-24 at 19:10, patchwork-bot+netdev...@kernel.org wrote: Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 23 Feb 2021 19:34:56 +0100 you wrote: Now that interface 3 in "option" driver is no longer mapped, add device ID matching it to qmi_wwan. The modem is

Re: [PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating

2021-03-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 16:39:01 +0100 you wrote: > shinfo already holds the result of skb_shinfo(skb) at this point - no > need to re-invoke the construct even twice. > > Signed-off-by: Jan Beulich Here is the summary with links

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Jakub Kicinski
On Mon, 1 Mar 2021 19:02:51 +0200 Vladimir Oltean wrote: > On Mon, Mar 01, 2021 at 05:26:53PM +0100, Markus Blöchl wrote: > > The main problem here could also just be that almost everybody _thinks_ > > that promiscuity means receiving all frames and no one is aware of the > > standards definition.

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-01 Thread Andrew Lunn
> To be more specific, optoe is only replacing the functionality of > drivers/net/phy/sfp.c, the functions of sfp_i2c_read() and sfp_i2c_write(). > These are the routines at the very bottom of the ethtool stack that actually > execute the i2c calls to get the data. The existing routines are very >

Re: memory leak in bpf

2021-03-01 Thread Rustam Kovhaev
On Mon, Mar 01, 2021 at 08:05:42PM +0100, Dmitry Vyukov wrote: > On Mon, Mar 1, 2021 at 5:21 PM Rustam Kovhaev wrote: > > > > On Wed, Dec 09, 2020 at 10:58:10PM -0800, syzbot wrote: > > > syzbot has found a reproducer for the following issue on: > > > > > > HEAD commit:a68a0262 mm/madvise: rem

Re: [PATCH net] net: phy: ti: take into account all possible interrupt sources

2021-03-01 Thread Jakub Kicinski
On Mon, 1 Mar 2021 10:21:14 +0200 Ioana Ciornei wrote: > On Sun, Feb 28, 2021 at 12:00:27PM -0800, Jakub Kicinski wrote: > > On Fri, 26 Feb 2021 17:30:20 +0200 Ioana Ciornei wrote: > > > diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c > > > index be1224b4447b..f7a2ec150e54 1006

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Jesper Dangaard Brouer
On Mon, 1 Mar 2021 13:23:06 +0200 Shay Agroskin wrote: > Jesper Dangaard Brouer writes: > > > On Sun, 28 Feb 2021 23:27:25 +0100 > > Lorenzo Bianconi wrote: > > > >> > >drops = bq->count - sent; > >> > > -out: > >> > > - bq->count = 0; > >> > > + if (unlikely(drops > 0)) {

RE: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-01 Thread Don Bollinger
On Fri, Feb 26, 2021 at 6:46 PM -0800, Don Bollinger wrote: > On Fri, Feb 26, 2021 at 2:35 PM -0800, Andrew Lunn wrote: > > On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > > > optoe is an i2c based driver that supports read/write access to all > > > the pages (tables) of MSA standa

[PATCH 1/2] Bluetooth: Notify suspend on le conn failed

2021-03-01 Thread Abhishek Pandit-Subedi
When suspending, Bluetooth disconnects all connected peers devices. If an LE connection is started but isn't completed, we will see an LE Create Connection Cancel instead of an HCI disconnect. This just adds a check to see if an LE cancel was the last disconnected device and wake the suspend thread

[PATCH 2/2] Bluetooth: Remove unneeded commands for suspend

2021-03-01 Thread Abhishek Pandit-Subedi
During suspend, there are a few scan enable and set event filter commands that don't need to be sent unless there are actual BR/EDR devices capable of waking the system. Check the HCI_PSCAN bit before writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED to control whether to clea

[PATCH 0/2] Bluetooth: Suspend improvements

2021-03-01 Thread Abhishek Pandit-Subedi
Hi Marcel (and linux bluetooth), Here are a few suspend improvements based on user reports we saw on ChromeOS and feedback from Hans de Goede on the mailing list. I have tested this using our ChromeOS suspend/resume automated tests (full SRHealth test coverage and some suspend resume stress tes

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Marc Kleine-Budde
On 01.03.2021 14:08:45, Marc Kleine-Budde wrote: > On 01.03.2021 12:38:05, Marc Kleine-Budde wrote: > > On 28.02.2021 11:38:54, Dario Binacchi wrote: > > [...] > > > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > > > while ((idx = ffs(pend))) { > > > idx--; >

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Marc Kleine-Budde
On 01.03.2021 18:21:42, Dario Binacchi wrote: > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > > > while ((idx = ffs(pend))) { > > > idx--; > > > pend &= ~(1 << idx); > > > - obj = idx + C_CAN_MSG_OBJ_TX_FIRST; > > > + obj = idx + pri

Re: [PATCH] can: c_can: move runtime PM enable/disable to c_can_platform

2021-03-01 Thread Marc Kleine-Budde
On 28.02.2021 23:15:48, Tong Zhang wrote: > Currently doing modprobe c_can_pci will make kernel complain > "Unbalanced pm_runtime_enable!", this is caused by pm_runtime_enable() > called before pm is initialized in register_candev() and doing so will I don't see where register_candev() is doing an

[PATCH 5.11 409/775] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Marc Kleine-Budde
On 01.03.2021 18:24:31, Dario Binacchi wrote: > Hi Marc, > > > Il 01/03/2021 14:08 Marc Kleine-Budde ha scritto: > > > > > > On 01.03.2021 12:38:05, Marc Kleine-Budde wrote: > > > On 28.02.2021 11:38:54, Dario Binacchi wrote: > > > [...] > > > > > > > @@ -730,7 +728,7 @@ static void c_can_do_

Re: [PATCH] can: c_can_pci: fix use-after-free

2021-03-01 Thread Marc Kleine-Budde
On 3/1/21 3:45 AM, Tong Zhang wrote: > There is a UAF in c_can_pci_remove(). > dev is released by free_c_can_dev() and is used by > pci_iounmap(pdev, priv->base) later. > To fix this issue, save the mmio address before releasing dev. > > [ 1795.746699] > ==

Re: Multicast routing + sch_fq not working since 4.20 (bisected)

2021-03-01 Thread Andre Tomt
On 01.03.2021 18:23, Eric Dumazet wrote: On Mon, Mar 1, 2021 at 6:19 PM Eric Dumazet wrote: On Mon, Mar 1, 2021 at 6:15 PM Andre Tomt wrote: TLDR; Multicast routing (at least IPv4) in combination with sch_fq is not working since kernel 4.20-rc1 and up to and including 5.12-rc1. Other tested

Re: [PATCH 2/5] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page

2021-03-01 Thread Johannes Weiner
Muchun, can you please reduce the CC list to mm/memcg folks only for the next submission? I think probably 80% of the current recipients don't care ;-) On Mon, Mar 01, 2021 at 10:11:45AM -0800, Shakeel Butt wrote: > On Sun, Feb 28, 2021 at 10:25 PM Muchun Song wrote: > > > > We want to reuse the

[PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-01 Thread Jiri Olsa
When testing uprobes we the test gets GEP (Global Entry Point) address from kallsyms, but then the function is called locally so the uprobe is not triggered. Fixing this by adjusting the address to LEP (Local Entry Point) for powerpc arch. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tes

[PATCH v2 1/1] xfrm: Use actual socket sk instead of skb socket for xfrm_output_resume

2021-03-01 Thread Evan Nimmo
A situation can occur where the interface bound to the sk is different to the interface bound to the sk attached to the skb. The interface bound to the sk is the correct one however this information is lost inside xfrm_output2 and instead the sk on the skb is used in xfrm_output_resume instead. Thi

RE: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

2021-03-01 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > This should fix the following warning: > > include/linux/skbuff.h:932: warning: Function parameter or member > '_sk_redir' not described in 'sk_buff' > > Reported-by: Lorenz Bauer > Cc: Daniel Borkmann > Cc: John Fastabend > Cc: Jakub Sitnicki > Signed

Re: Driver i40e have XDP-redirect bug

2021-03-01 Thread Jesper Dangaard Brouer
On Mon, 1 Mar 2021 13:18:32 +0100 Jesper Dangaard Brouer wrote: > Hi i40e-people + XDP-feature-people, > > The driver i40e have a XDP-redirect bug, where is it partly broken. It can > transmit a redirected xdp_frame (from another driver). But broken when > redirecting a xdp_frame that is receiv

[Patch bpf-next] skmsg: add function doc for skb->_sk_redir

2021-03-01 Thread Cong Wang
From: Cong Wang This should fix the following warning: include/linux/skbuff.h:932: warning: Function parameter or member '_sk_redir' not described in 'sk_buff' Reported-by: Lorenz Bauer Cc: Daniel Borkmann Cc: John Fastabend Cc: Jakub Sitnicki Signed-off-by: Cong Wang --- include/linux/sk

[PATCH net] tcp: add sanity tests to TCP_QUEUE_SEQ

2021-03-01 Thread Eric Dumazet
From: Eric Dumazet Qingyu Li reported a syzkaller bug where the repro changes RCV SEQ _after_ restoring data in the receive queue. mprotect(0x4aa000, 12288, PROT_READ)= 0 mmap(0x1000, 4096, PROT_NONE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x1000 mmap(0x2000, 16777216, PR

[PATCH net] hv_netvsc: Fix validation in netvsc_linkstatus_callback()

2021-03-01 Thread Andrea Parri (Microsoft)
Contrary to the RNDIS protocol specification, certain (pre-Fe) implementations of Hyper-V's vSwitch did not account for the status buffer field in the length of an RNDIS packet; the bug was fixed in newer implementations. Validate the status buffer fields using the length of the 'vmtransfer_page'

Re: [Patch bpf-next v7 4/9] skmsg: move sk_redir from TCP_SKB_CB to skb

2021-03-01 Thread Cong Wang
On Mon, Mar 1, 2021 at 7:24 AM Lorenz Bauer wrote: > > On Tue, 23 Feb 2021 at 18:49, Cong Wang wrote: > > > > From: Cong Wang > > > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > > does not work for any other non-TCP protocols. We can move them to > > skb ext, but it introd

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-01 Thread Si-Wei Liu
On 2/28/2021 1:27 PM, Michael S. Tsirkin wrote: On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote: Hi Michael, Are you okay to live without this ioctl for now? I think QEMU is the one that needs to be fixed and will have to be made legacy guest aware. I think the kernel can just hon

[PATCH 5.10 341/663] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

[PATCH 5.4 176/340] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

Re: [PATCH v2 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-03-01 Thread Dario Binacchi
> Il 01/03/2021 12:36 Marc Kleine-Budde ha scritto: > > > On 28.02.2021 11:35:31, Dario Binacchi wrote: > > > On 25.02.2021 22:51:52, Dario Binacchi wrote: > > > > According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let > > > > RX use > > > > IF1 (i.e. IF_RX) and TX use IF2 (i.

Multicast routing + sch_fq not working since 4.20 (bisected)

2021-03-01 Thread Andre Tomt
TLDR; Multicast routing (at least IPv4) in combination with sch_fq is not working since kernel 4.20-rc1 and up to and including 5.12-rc1. Other tested qdisc schedulers work fine (pfifo_fast, fq_codel, cake) Hello all I've been chasing a issue with multicast routing the past few days where not

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Dario Binacchi
Hi Marc, > Il 01/03/2021 14:08 Marc Kleine-Budde ha scritto: > > > On 01.03.2021 12:38:05, Marc Kleine-Budde wrote: > > On 28.02.2021 11:38:54, Dario Binacchi wrote: > > [...] > > > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > > > while ((idx = ffs(pend))) { > >

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Dario Binacchi
Hi Marc, > Il 01/03/2021 12:38 Marc Kleine-Budde ha scritto: > > > On 28.02.2021 11:38:54, Dario Binacchi wrote: > [...] > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > > while ((idx = ffs(pend))) { > > idx--; > > pend &= ~(1 << idx); >

[PATCH 4.19 139/247] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 05:26:53PM +0100, Markus Blöchl wrote: > The main problem here could also just be that almost everybody _thinks_ > that promiscuity means receiving all frames and no one is aware of the > standards definition. > In fact, I can't blame them, as the standard is hard to come by

Re: Fw: [Bug 212005] New: WARNING: CPU: 1 PID: 356 at net/ipv4/tcp.c:2343 tcp_recvmsg_locked+0x90e/0x29a0

2021-03-01 Thread Eric Dumazet
On 3/1/21 5:37 PM, Eric Dumazet wrote: > > > On 3/1/21 4:58 PM, Stephen Hemminger wrote: >> >> >> Begin forwarded message: >> >> Date: Mon, 01 Mar 2021 11:50:22 + >> From: bugzilla-dae...@bugzilla.kernel.org >> To: step...@networkplumber.org >> Subject: [Bug 212005] New: WARNING: CPU: 1 PI

[PATCH 4.14 091/176] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

Re: Fw: [Bug 212005] New: WARNING: CPU: 1 PID: 356 at net/ipv4/tcp.c:2343 tcp_recvmsg_locked+0x90e/0x29a0

2021-03-01 Thread Eric Dumazet
On 3/1/21 4:58 PM, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Mon, 01 Mar 2021 11:50:22 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 212005] New: WARNING: CPU: 1 PID: 356 at net/ipv4/tcp.c:2343 > tcp_recvmsg_locked+

[PATCH 4.9 064/134] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Markus Blöchl
On Mon, Mar 01, 2021 at 05:08:52PM +0200, Vladimir Oltean wrote: > On Mon, Mar 01, 2021 at 03:36:15PM +0100, Michael Walle wrote: > > Ok, I see, so your proposed behavior is backed by the standards. But > > OTOH there was a summary by Markus of the behavior of other drivers: > > https://lore.kernel

Re: memory leak in bpf

2021-03-01 Thread Rustam Kovhaev
On Wed, Dec 09, 2020 at 10:58:10PM -0800, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit:a68a0262 mm/madvise: remove racy mm ownership check > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11facf1750 > kernel

[PATCH 3/5] SUNRPC: Refresh rq_pages using a bulk page allocator

2021-03-01 Thread Mel Gorman
From: Chuck Lever Reduce the rate at which nfsd threads hammer on the page allocator. This improve throughput scalability by enabling the threads to run more independently of each other. Signed-off-by: Chuck Lever Signed-off-by: Mel Gorman --- net/sunrpc/svc_xprt.c | 43 ++

[PATCH 4.4 46/93] tracepoint: Do not fail unregistering a probe due to memory failure

2021-03-01 Thread Greg Kroah-Hartman
From: Steven Rostedt (VMware) [ Upstream commit befe6d946551d65cddbd32b9cb0170b0249fd5ed ] The list of tracepoint callbacks is managed by an array that is protected by RCU. To update this array, a new array is allocated, the updates are copied over to the new array, and then the list of function

[PATCH 1/5] SUNRPC: Set rq_page_end differently

2021-03-01 Thread Mel Gorman
From: Chuck Lever Refactor: I'm about to use the loop variable @i for something else. As far as the "i++" is concerned, that is a post-increment. The value of @i is not used subsequently, so the increment operator is unnecessary and can be removed. Also note that nfsd_read_actor() was renamed

[PATCH 5/5] net: page_pool: use alloc_pages_bulk in refill code path

2021-03-01 Thread Mel Gorman
From: Jesper Dangaard Brouer There are cases where the page_pool need to refill with pages from the page allocator. Some workloads cause the page_pool to release pages instead of recycling these pages. For these workload it can improve performance to bulk alloc pages from the page-allocator to r

[PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-01 Thread Mel Gorman
This patch adds a new page allocator interface via alloc_pages_bulk, and __alloc_pages_bulk_nodemask. A caller requests a number of pages to be allocated and added to a list. They can be freed in bulk using free_pages_bulk(). The API is not guaranteed to return the requested number of pages and ma

[PATCH 4/5] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-03-01 Thread Mel Gorman
From: Jesper Dangaard Brouer In preparation for next patch, move the dma mapping into its own function, as this will make it easier to follow the changes. V2: make page_pool_dma_map return boolean (Ilias) Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Mel Gorman --- net/core/page_pool.

[PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users

2021-03-01 Thread Mel Gorman
This series introduces a bulk order-0 page allocator with sunrpc and the network page pool being the first users. The implementation is not particularly efficient and the intention is to iron out what the semantics of the API should have for users. Once the semantics are ironed out, it can be made

Re: [PATCH bpf-next 2/2] libbpf, xsk: add libbpf_smp_store_release libbpf_smp_load_acquire

2021-03-01 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > From: Björn Töpel > > Now that the AF_XDP rings have load-acquire/store-release semantics, > move libbpf to that as well. > > The library-internal libbpf_smp_{load_acquire,store_release} are only > valid for 32-bit words on ARM64. > > Also, remove the barriers that are no l

Re: [PATCH bpf-next 1/2] xsk: update rings for load-acquire/store-release semantics

2021-03-01 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > From: Björn Töpel > > Currently, the AF_XDP rings uses smp_{r,w,}mb() fences on the > kernel-side. By updating the rings for load-acquire/store-release > semantics, the full barrier on the consumer side can be replaced with > improved performance as a nice side-effect. > >

Re: [PATCH v3 0/3] Add lockdep_assert_not_held()

2021-03-01 Thread Shuah Khan
On 3/1/21 4:02 AM, Kalle Valo wrote: Peter Zijlstra writes: On Mon, Mar 01, 2021 at 10:45:32AM +0200, Kalle Valo wrote: Peter Zijlstra writes: On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote: Shuah Khan (3): lockdep: add lockdep_assert_not_held() lockdep: add lockdep lock

[PATCH net] net: dsa: tag_mtk: fix 802.1ad VLAN egress

2021-03-01 Thread DENG Qingfang
A different TPID bit is used for 802.1ad VLAN frames. Reported-by: Ilario Gelmetti Fixes: f0af34317f4b ("net: dsa: mediatek: combine MediaTek tag with VLAN tag") Signed-off-by: DENG Qingfang --- net/dsa/tag_mtk.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff -

Fw: [Bug 212005] New: WARNING: CPU: 1 PID: 356 at net/ipv4/tcp.c:2343 tcp_recvmsg_locked+0x90e/0x29a0

2021-03-01 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 01 Mar 2021 11:50:22 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 212005] New: WARNING: CPU: 1 PID: 356 at net/ipv4/tcp.c:2343 tcp_recvmsg_locked+0x90e/0x29a0 https://bugzilla.kernel.org/show_bug.cgi?id=21200

Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers

2021-03-01 Thread Michael S. Tsirkin
On Mon, Mar 01, 2021 at 03:52:45PM +0800, Jason Wang wrote: > > On 2021/3/1 2:28 下午, Eli Cohen wrote: > > VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask > > conditionals. > > > > Also, in mlx5_vdpa_is_little_endian() use BIT_ULL for consistency with > > the rest of the code. > > > >

Re: [RFC PATCH v2 net-next 05/17] net: bridge: implement unicast filtering for the bridge device

2021-03-01 Thread Ido Schimmel
On Wed, Feb 24, 2021 at 01:43:38PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > The bridge device currently goes into promiscuous mode when it has an > upper with a different MAC address than itself. But it could do better: > it could sync the MAC addresses of its uppers to the softw

[PATCH net-next 2/2] net: mhi: proto_mbim: Adjust MTU and MRU

2021-03-01 Thread Loic Poulain
MBIM protocol makes the interface asymmetric, ingress data received from MHI is MBIM protocol, that can contain multiple aggregated IP packets, while egress data received from network stack is IP protocol. Set a default MTU to 1500 (usual network MTU for WWAN), and MRU to 32K which is the default

[PATCH net-next 1/2] net: mhi: Allow decoupled MTU/MRU

2021-03-01 Thread Loic Poulain
If a maximum receive unit (MRU) size is specified, use it for RX buffers allocation instead of the MTU. Signed-off-by: Loic Poulain --- drivers/net/mhi/mhi.h | 1 + drivers/net/mhi/net.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mhi/mhi.h b/drivers/net/m

[PATCH 2/2] MIPS: Remove KVM_TE support

2021-03-01 Thread Thomas Bogendoerfer
After removal of the guest part of KVM TE (trap and emulate), also remove the host part. Signed-off-by: Thomas Bogendoerfer --- arch/mips/configs/loongson3_defconfig |1 - arch/mips/include/asm/kvm_host.h | 238 arch/mips/kvm/Kconfig | 34 - arch/mips/kvm/Makefil

Re: [Patch bpf-next v7 4/9] skmsg: move sk_redir from TCP_SKB_CB to skb

2021-03-01 Thread Lorenz Bauer
On Tue, 23 Feb 2021 at 18:49, Cong Wang wrote: > > From: Cong Wang > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > does not work for any other non-TCP protocols. We can move them to > skb ext, but it introduces a memory allocation on fast path. > > Fortunately, we only need

[PATCH net] net: expand textsearch ts_state to fit skb_seq_state

2021-03-01 Thread Willem de Bruijn
From: Willem de Bruijn The referenced commit expands the skb_seq_state used by skb_find_text with a 4B frag_off field, growing it to 48B. This exceeds container ts_state->cb, causing a stack corruption: [ 73.238353] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: sk

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 03:36:15PM +0100, Michael Walle wrote: > Ok, I see, so your proposed behavior is backed by the standards. But > OTOH there was a summary by Markus of the behavior of other drivers: > https://lore.kernel.org/netdev/20201119153751.ix73o5h4n6dgv...@ipetronik.com/ > And a conclu

Re: possible deadlock in ipv6_sock_mc_close

2021-03-01 Thread Paolo Abeni
Hello, On Mon, 2021-03-01 at 14:52 +, Chuck Lever wrote: > > On Mar 1, 2021, at 8:49 AM, syzbot > > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:eee7ede6 Merge branch 'bnxt_en-error-recovery-bug-fixes' > > git tree: net > > console outpu

Re: possible deadlock in ipv6_sock_mc_close

2021-03-01 Thread Matthieu Baerts
Hi Chuck, (+ cc: MPTCP list) On 01/03/2021 15:52, Chuck Lever wrote: On Mar 1, 2021, at 8:49 AM, syzbot wrote: (...) syzbot found the following issue on: (...) Hi, thanks for the report. Initial analysis: c8e88e3aa738 ("NFSD: Replace READ* macros in nfsd4_decode_layoutget()" changes

MACSEC configuration - is CONFIG_MACSEC enough?

2021-03-01 Thread Tom Cook
I'm trying to use MACSEC on an arm64 embedded platform; I'm trying to create an encrypted channel between two of them rather than doing switch port access etc. The vendor's BSP only provides a 4.9 kernel so that's what I'm using. I've added CONFIG_MACSEC=y to the kernel config. This then forces

Re: possible deadlock in ipv6_sock_mc_close

2021-03-01 Thread Chuck Lever
> On Mar 1, 2021, at 8:49 AM, syzbot > wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:eee7ede6 Merge branch 'bnxt_en-error-recovery-bug-fixes' > git tree: net > console output: https://syzkaller.appspot.com/x/log.txt?x=123ad632d0 > kernel config: h

Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

2021-03-01 Thread Leon Romanovsky
On Mon, Mar 01, 2021 at 08:48:34AM -0400, Jason Gunthorpe wrote: > On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote: > > @@ -884,7 +884,7 @@ static void gid_table_reserve_default(struct ib_device > > *ib_dev, u8 port, > > > > static void gid_table_release_one(struct ib_device *ib_d

Re: [PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-03-01 Thread Michael Walle
Am 2021-02-28 23:48, schrieb Vladimir Oltean: On Sat, Feb 27, 2021 at 02:18:20PM +0100, Michael Walle wrote: Am 2021-02-27 01:16, schrieb Vladimir Oltean: > On Fri, Feb 26, 2021 at 03:49:22PM -0800, Jakub Kicinski wrote: > > On Sat, 27 Feb 2021 01:42:44 +0200 Vladimir Oltean wrote: > > > On Fri,

Re: [PATCH net] net: dsa: tag_rtl4_a: fix egress tags

2021-03-01 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 02:58:59PM +0100, Linus Walleij wrote: > On Sun, Feb 28, 2021 at 6:08 PM DENG Qingfang wrote: > > > Commit 86dd9868b878 has several issues, but was accepted too soon > > before anyone could take a look. > > > > - Double free. dsa_slave_xmit() will free the skb if the xmit

Re: [PATCH net] net: dsa: tag_rtl4_a: fix egress tags

2021-03-01 Thread Linus Walleij
On Sun, Feb 28, 2021 at 6:08 PM DENG Qingfang wrote: > Commit 86dd9868b878 has several issues, but was accepted too soon > before anyone could take a look. > > - Double free. dsa_slave_xmit() will free the skb if the xmit function > returns NULL, but the skb is already freed by eth_skb_pad(). U

Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading

2021-03-01 Thread Linus Walleij
On Wed, Feb 24, 2021 at 7:12 AM DENG Qingfang wrote: > +/* Port isolation registers */ > +#define RTL8366RB_PORT_ISO_BASE0x0F08 > +#define RTL8366RB_PORT_ISO(pnum) (RTL8366RB_PORT_ISO_BASE + (pnum)) > +#define RTL8366RB_PORT_ISO_EN BIT(0) > +#define RTL8366RB_PORT_I

possible deadlock in ipv6_sock_mc_close

2021-03-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:eee7ede6 Merge branch 'bnxt_en-error-recovery-bug-fixes' git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=123ad632d0 kernel config: https://syzkaller.appspot.com/x/.config?x=e2d5ba72abae4f14 dashboard li

Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading

2021-03-01 Thread Linus Walleij
On Wed, Feb 24, 2021 at 7:12 AM DENG Qingfang wrote: > Use port isolation registers to configure bridge offloading. > Remove the VLAN init, as we have proper CPU tag and bridge offloading > support now. > > Signed-off-by: DENG Qingfang > --- > This is not tested, as I don't have a RTL8366RB boar

Re: [PATCH] net/core/skbuff.c: __netdev_alloc_skb fix when len is greater than KMALLOC_MAX_SIZE

2021-03-01 Thread Pavel Skripkin
Hi, thanks for your reply! On Mon, 2021-03-01 at 14:09 +0100, Eric Dumazet wrote: > > On 2/26/21 8:11 PM, Pavel Skripkin wrote: > > syzbot found WARNING in __alloc_pages_nodemask()[1] when order >= > > MAX_ORDER. > > It was caused by __netdev_alloc_skb(), which doesn't check len > > value after a

Re: [PATCH v3 net 8/8] net: enetc: keep RX ring consumer index in sync with hardware

2021-03-01 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 01:18:18PM +0200, Vladimir Oltean wrote: > The simpler thing would be to put the write to the consumer index into > enetc_refill_rx_ring directly, but there are issues with the MDIO > locking: in the NAPI poll code we have the enetc_lock_mdio() taken from > top-level and we

RE: [PATCH v3 net 8/8] net: enetc: keep RX ring consumer index in sync with hardware

2021-03-01 Thread Claudiu Manoil
>-Original Message- >From: Vladimir Oltean >Sent: Monday, March 1, 2021 1:18 PM >To: David S . Miller ; Jakub Kicinski >; netdev@vger.kernel.org >Cc: Michael Walle ; Claudiu Manoil >; Alexandru Marginean >; Andrew Lunn ; >Vladimir Oltean >Subject: [PATCH v3 net 8/8] net: enetc: keep RX ri

[PATCH net 3/3] net: dsa: rtl4_a: Syntax fixes

2021-03-01 Thread Linus Walleij
Some errors spotted in the initial patch: use reverse christmas tree for nice code looks and fix a spelling mistake. Reported-by: Andrew Lunn Reported-by: DENG Qingfang Cc: Mauri Sandberg Signed-off-by: Linus Walleij --- net/dsa/tag_rtl4_a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH net 1/3] net: dsa: rtl4_a: Pad using __skb_put_padto()

2021-03-01 Thread Linus Walleij
The eth_skb_pad() function will cause a double free on failure since dsa_slave_xmit() will try to free the frame if we return NULL. Fix this by using __skb_put_padto() instead. Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags") Reported-by: DENG Qingfang Cc: Mauri Sandberg Si

[PATCH net 2/3] net: dsa: rtl4_a: Drop skb_cow_head()

2021-03-01 Thread Linus Walleij
The DSA core already provides the tag headroom, drop this. Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags") Reported-by: Andrew Lunn Reported-by: DENG Qingfang Cc: Mauri Sandberg Signed-off-by: Linus Walleij --- net/dsa/tag_rtl4_a.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH RFC V2 net-next 0/2] Use bulk order-0 page allocator API for page_pool

2021-03-01 Thread Jesper Dangaard Brouer
This is a followup to Mel Gorman's patchset: - Message-Id: <20210224102603.19524-1-mgor...@techsingularity.net> - https://lore.kernel.org/netdev/20210224102603.19524-1-mgor...@techsingularity.net/ Showing page_pool usage of the API for alloc_pages_bulk(). Maybe Mel Gorman will/can carry these

[PATCH RFC V2 net-next 2/2] net: page_pool: use alloc_pages_bulk in refill code path

2021-03-01 Thread Jesper Dangaard Brouer
There are cases where the page_pool need to refill with pages from the page allocator. Some workloads cause the page_pool to release pages instead of recycling these pages. For these workload it can improve performance to bulk alloc pages from the page-allocator to refill the alloc cache. For XDP

[PATCH RFC V2 net-next 1/2] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-03-01 Thread Jesper Dangaard Brouer
In preparation for next patch, move the dma mapping into its own function, as this will make it easier to follow the changes. V2: make page_pool_dma_map return boolean (Ilias) Signed-off-by: Jesper Dangaard Brouer --- net/core/page_pool.c | 45 ++--- 1

Re: [PATCH] net/core/skbuff.c: __netdev_alloc_skb fix when len is greater than KMALLOC_MAX_SIZE

2021-03-01 Thread Eric Dumazet
On 2/26/21 8:11 PM, Pavel Skripkin wrote: > syzbot found WARNING in __alloc_pages_nodemask()[1] when order >= MAX_ORDER. > It was caused by __netdev_alloc_skb(), which doesn't check len value after > adding NET_SKB_PAD. > Order will be >= MAX_ORDER and passed to __alloc_pages_nodemask() if size

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Marc Kleine-Budde
On 01.03.2021 12:38:05, Marc Kleine-Budde wrote: > On 28.02.2021 11:38:54, Dario Binacchi wrote: > [...] > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > > while ((idx = ffs(pend))) { > > idx--; > > pend &= ~(1 << idx); > > - obj = i

Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

2021-03-01 Thread Linus Walleij
On Sun, Feb 28, 2021 at 12:32 PM DENG Qingfang wrote: > On Sun, Feb 28, 2021 at 7:47 AM Linus Walleij > wrote: > > > > I names the previous protocol "RTL4 A" after a 4-byte tag > > with protocol indicted as "A", what about naming this > > "RTL2 9" in the same vein? It will be good if some other

Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

2021-03-01 Thread Jason Gunthorpe
On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote: > @@ -884,7 +884,7 @@ static void gid_table_reserve_default(struct ib_device > *ib_dev, u8 port, > > static void gid_table_release_one(struct ib_device *ib_dev) > { > - unsigned int p; > + u32 p; > > rdma_for_each_p

[PATCH] docs: networking: bonding.rst Fix a typo in bonding.rst

2021-03-01 Thread Masanari Iida
This patch fixes a spelling typo in bonding.rst. Signed-off-by: Masanari Iida --- Documentation/networking/bonding.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst index 5f690f0ad0e4..62f2aab8eaec

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Ilias Apalodimas
Hi Lorenzo for the netsec driver Reviewed-by: Ilias Apalodimas On Sat, Feb 27, 2021 at 12:04:13PM +0100, Lorenzo Bianconi wrote: > We want to change the current ndo_xdp_xmit drop semantics because > it will allow us to implement better queue overflow handling. > This is working towards the larg

Driver i40e have XDP-redirect bug

2021-03-01 Thread Jesper Dangaard Brouer
Hi i40e-people + XDP-feature-people, The driver i40e have a XDP-redirect bug, where is it partly broken. It can transmit a redirected xdp_frame (from another driver). But broken when redirecting a xdp_frame that is received by the driver itself. This reminds me about lacking XDP-features, as thi

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Ioana Ciornei
On Sat, Feb 27, 2021 at 12:04:13PM +0100, Lorenzo Bianconi wrote: > We want to change the current ndo_xdp_xmit drop semantics because > it will allow us to implement better queue overflow handling. > This is working towards the larger goal of a XDP TX queue-hook. > Move XDP_REDIRECT error path hand

Re: [PATCH v2 5/6] can: c_can: prepare to up the message objects number

2021-03-01 Thread Marc Kleine-Budde
On 28.02.2021 11:18:13, Dario Binacchi wrote: > > > + u32 msg_obj_rx_mask; > > > > Is this variable big enough after you've extended the driver to use 64 > > mailboxes? > > Yes. I have kept the message assignment policy unchanged, they are equally > divided between reception and transmission. Th

  1   2   >