Am 2021-02-17 07:17, schrieb Dan Carpenter:
Smatch warns that there is a locking issue in this function:
drivers/net/phy/icplus.c:273 ip101a_g_config_intr_pin()
warn: inconsistent returns '&phydev->mdio.bus->mdio_lock'.
Locked on : 242
Unlocked on: 273
It turns out that the comments in phy
Static checkers complained about an off by one read overflow in
otx2_get_fecparam() and we applied two conflicting fixes for it.
Correct: b0aae0bde26f ("octeontx2: Fix condition.")
Wrong: 93efb0c65683 ("octeontx2-pf: Fix out-of-bounds read in
otx2_get_fecparam()")
Revert the incorrect fix.
Fi
On Wed, Feb 17, 2021 at 8:16 AM Magnus Karlsson
wrote:
>
> On Wed, Feb 17, 2021 at 3:26 AM Dan Siemon wrote:
> >
> > On Mon, 2021-02-15 at 22:38 +0100, Toke Høiland-Jørgensen wrote:
> > > The idea is to keep libbpf focused on bpf, and move the AF_XDP stuff
> > > to
> > > libxdp (so the socket stu
Shuah Khan writes:
> On 2/16/21 12:53 AM, Felix Fietkau wrote:
>>
>> On 2021-02-16 08:03, Kalle Valo wrote:
>>> Shuah Khan wrote:
>>>
ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr()
return pointer (sta) outside null check. Fix it by moving the code
block under th
On Wed, Feb 17, 2021 at 3:26 AM Dan Siemon wrote:
>
> On Mon, 2021-02-15 at 22:38 +0100, Toke Høiland-Jørgensen wrote:
> > The idea is to keep libbpf focused on bpf, and move the AF_XDP stuff
> > to
> > libxdp (so the socket stuff in xsk.h). We're adding the existing code
> > wholesale, and keepin
On 17.02.2021 07:21, DENG Qingfang wrote:
> Add support for Realtek RTL8366S switch tag
>
> Signed-off-by: DENG Qingfang
> ---
> include/net/dsa.h | 2 +
> net/dsa/Kconfig| 6 +++
> net/dsa/Makefile | 1 +
> net/dsa/tag_rtl8366s.c | 98 ++
From: Menglong Dong
The bit mask for MSG_* seems a little confused here. Replace it
with BIT() to make it clear to understand.
Signed-off-by: Menglong Dong
---
v4:
- CC netdev
v3:
- move changelog here
v2:
- use BIT() instead of BIT_MASK()
---
include/linux/socket.h | 71 ++
On Tue, Feb 16, 2021 at 04:25:20PM -0800, Si-Wei Liu wrote:
>
> > > The saved mvq->avail_idx will be used to recreate hardware virtq object
> > > and
> > > the used index in create_virtqueue(), once status DRIVER_OK is set. I
> > > suspect we should pass the index to mvq->used_idx in
> > > mlx5_v
Add support for Realtek RTL8366S switch tag
Signed-off-by: DENG Qingfang
---
include/net/dsa.h | 2 +
net/dsa/Kconfig| 6 +++
net/dsa/Makefile | 1 +
net/dsa/tag_rtl8366s.c | 98 ++
4 files changed, 107 insertions(+)
create mode 1006
Support Realtek RTL8366S/SR switch
Signed-off-by: DENG Qingfang
---
drivers/net/dsa/Kconfig|1 +
drivers/net/dsa/Makefile |2 +-
drivers/net/dsa/realtek-smi-core.c |3 +-
drivers/net/dsa/realtek-smi-core.h |1 +
drivers/net/dsa/rtl8366s.c | 1165
Add DSA driver and tag for Realtek RTL8366S/SR.
Posting this as RFC because Linus Walleij told me that Mauri Sandberg was
working on this driver too, and some of the features are not yet tested.
DENG Qingfang (2):
net: dsa: add Realtek RTL8366S switch tag
net: dsa: add Realtek RTL8366S switch
Smatch warns that there is a locking issue in this function:
drivers/net/phy/icplus.c:273 ip101a_g_config_intr_pin()
warn: inconsistent returns '&phydev->mdio.bus->mdio_lock'.
Locked on : 242
Unlocked on: 273
It turns out that the comments in phy_select_page() say we have to call
phy_restore
These defines are used with set_bit() and test_bit() which take a bit
number. In other words, the code is doing:
if (BIT(BIT(1)) & pf->hw.cap_flag) {
This was done consistently so it did not cause a problem at runtime but
it's still worth fixing.
Fixes: facede8209ef ("octeontx2-pf: cn10
From: Vincent Cheng
This series fixes a race condition that may result in the output clock
not aligned to internal 1 PPS clock.
Part of device initialization is to align the rising edge of output
clocks to the internal rising edge of the 1 PPS clock. If the system
APLL and DPLL are not locked w
From: Vincent Cheng
Code clean-up.
Signed-off-by: Vincent Cheng
---
drivers/ptp/ptp_clockmatrix.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index 241bff0..dc42c36 100644
--- a/drivers/ptp/ptp_clockmatri
From: Vincent Cheng
When enabling output using PTP_CLK_REQ_PEROUT, need to align the output
clock to the internal 1 PPS clock.
Signed-off-by: Vincent Cheng
Acked-by: Richard Cochran
---
drivers/ptp/ptp_clockmatrix.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff
From: Vincent Cheng
Code clean-up.
* Remove unnecessary \n termination from dev_*() messages.
* Remove 'char *fmt' to define strings to stay within 80 column
limit. Not needed since coding guidelines increased to
100 columns limit.
Keeping format in place allows static code checkers to
From: Vincent Cheng
Code clean-up.
* Remove blank line between variable declarations.
* Remove blank line between:
err = blah(...)
if (err)
...
* Remove unnecessary blank line before/after loop constructs.
Signed-off-by: Vincent Cheng
---
drivers/ptp/ptp_clock
From: Vincent Cheng
Part of the device initialization aligns the rising edge of the output
clock to the internal 1 PPS clock. If the system APLL and DPLL is not
locked, then the alignment will fail and there will be a fixed offset
between the internal 1 PPS clock and the output clock.
After load
From: Vincent Cheng
Removed unused header declarations.
Signed-off-by: Vincent Cheng
---
drivers/ptp/ptp_clockmatrix.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ptp/ptp_clockmatrix.h b/drivers/ptp/ptp_clockmatrix.h
index 0233236..fb32327 100644
--- a/drivers/ptp/ptp_clockmat
From: Vincent Cheng
Code clean-up.
Signed-off-by: Vincent Cheng
---
drivers/ptp/ptp_clockmatrix.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index dc42c36..75463c2 100644
--- a/drivers/pt
On Wed, Feb 17, 2021 at 7:55 AM Linus Walleij wrote:
>
> + if (skb_cow_head(skb, RTL4_A_HDR_LEN) < 0)
> + return NULL;
skb_cow_head is unnecessary here. DSA core will do it for you.
> +
> + out = (RTL4_A_PROTOCOL_RTL8366RB << 12) | (2 << 8);
> + /* The lower bits
On Wed, Feb 17, 2021 at 11:29 AM Andrew Lunn wrote:
>
> > + /* Pad out to at least 60 bytes */
> > + if (unlikely(eth_skb_pad(skb)))
> > + return NULL;
>
> The core will do the padding for you. Turn on .tail_tag in
> dsa_device_ops.
>
Please don't. .tail_tag does far more than
On Wed, 17 Feb 2021 at 13:19, Andrew Lunn wrote:
>
> > > The patch does make sense though, Broadcom 53125 switches have a broken
> > > turn around and are mdio_device instances, the broken behavior may not
> > > show up with all MDIO controllers used to interface though. For the
> >
> > Yes the re
From: Nathan Rossi
The documentation for MDIO bindings describes the "broken-turn-around",
property such that any MDIO device can define it. Other MDIO devices may
require this property in order to correctly function on the MDIO bus.
Enable the parsing and configuration associated with this prop
The Ethernet MAC and PHY are usually major consumers of power on boards
which may not be able to fully power off (those with no PMIC). Powering
down the MAC and internal PHY saves power while these boards are "off".
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/etherne
This is a deinitialization function that always returned zero, and that
return value was always ignored. Have it return void instead.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++---
1 file changed, 2 insertions(+), 3 delet
Use the appropriate function instead of reimplementing it,
and update the error message to match the code.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dr
These patches clean up some things I noticed while fixing suspend/resume
behavior. The first four are minor code improvements. The last one adds
a shutdown hook to minimize power consumption on boards without a PMIC.
Changes v1 to v2:
- Note the assumption of exclusive reset controller access in
Adjust the spacing and use an explicit "return 0" in the success path
to make the function easier to parse.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/driver
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered,
so there is no need to do it again here.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a
From: Cong Wang
Pretty much similar to commit 1336c662474e
("bpf: Clear per_cpu pointers during bpf_prog_realloc") we also need to
clear these two percpu pointers in bpf_prog_clone_create(), otherwise
would get a double free:
BUG: kernel NULL pointer dereference, address:
#PF:
On Tue, Feb 16, 2021 at 04:54:53PM -0600, Robert Hancock wrote:
> Add a flag and helper function to indicate that a PHY device is part of
> an SFP module, which is set on attach. This can be used by PHY drivers
> to handle SFP-specific quirks or behavior.
>
> Signed-off-by: Robert Hancock
> ---
>
On Wed, Feb 17, 2021 at 12:55:42AM +0100, Linus Walleij wrote:
> Support also transmitting frames using the custom "8899 A"
> 4 byte tag.
>
> Qingfang came up with the solution: we need to pad the
> ethernet frame to 60 bytes using eth_skb_pad(), then the
> switch will happily accept frames with c
> > The patch does make sense though, Broadcom 53125 switches have a broken
> > turn around and are mdio_device instances, the broken behavior may not
> > show up with all MDIO controllers used to interface though. For the
>
> Yes the reason we needed this change was to enable broken turn around,
On Mon, 2021-02-15 at 22:38 +0100, Toke Høiland-Jørgensen wrote:
> The idea is to keep libbpf focused on bpf, and move the AF_XDP stuff
> to
> libxdp (so the socket stuff in xsk.h). We're adding the existing code
> wholesale, and keeping API compatibility during the move, so all
> that's
> needed i
Implement functions 'port_mrp_add', 'port_mrp_del',
'port_mrp_add_ring_role' and 'port_mrp_del_ring_role' to call the mrp
functions from ocelot.
Also all MRP frames that arrive to CPU on queue number OCELOT_MRP_CPUQ
will be forward by the SW.
Signed-off-by: Horatiu Vultur
---
drivers/net/dsa/oc
Add support for offloading MRP in HW. Currently implement the switchdev
calls 'SWITCHDEV_OBJ_ID_MRP', 'SWITCHDEV_OBJ_ID_RING_ROLE_MRP',
to allow to create MRP instances and to set the role of these instances.
Add DSA_NOTIFIER_MRP_ADD/DEL and DSA_NOTIFIER_MRP_ADD/DEL_RING_ROLE
which calls to .port_
This patch extends the br_mrp_switchdev functions to be able to have a
better understanding what cause the issue and if the SW needs to be used
as a backup.
There are the following cases:
- when the code is compiled without CONFIG_NET_SWITCHDEV. In this case
return success so the SW can continue
Hi all,
Today's linux-next merge of the net-next tree got conflicts in:
drivers/net/ethernet/ibm/ibmvnic.c
drivers/net/ethernet/ibm/ibmvnic.h
between commit:
4a41c421f367 ("ibmvnic: serialize access to work queue on remove")
from the net tree and commits:
bab08bedcdc3 ("ibmvnic: fix b
Remove #IS_ENABLED(CONFIG_BRIDGE_MRP) from switchdev.h. This will
simplify the code implements MRP callbacks and will be similar with the
vlan filtering.
Signed-off-by: Horatiu Vultur
---
include/net/switchdev.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/include/net/switchdev
Add basic support for MRP. The HW will just trap all MRP frames on the
ring ports to CPU and allow the SW to process them. In this way it is
possible to for this node to behave both as MRM and MRC.
Current limitations are:
- it doesn't support Interconnect roles.
- it supports only a single ring.
Check the return values of the br_mrp_switchdev function.
In case of:
- BR_MRP_NONE, return the error to userspace,
- BR_MRP_SW, continue with SW implementation,
- BR_MRP_HW, continue without SW implementation,
Signed-off-by: Horatiu Vultur
---
net/bridge/br_mrp.c | 43 ++
This patch series extends MRP switchdev to allow the SW to have a better
understanding if the HW can implement the MRP functionality or it needs
to help the HW to run it. There are 3 cases:
- when HW can't implement at all the functionality.
- when HW can implement a part of the functionality but n
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev
functions to allow the SW to detect the cases where HW can't implement
the functionality or when SW is used as a backup.
Signed-off-by: Horatiu Vultur
---
net/bridge/br_private_mrp.h | 14 ++
1 file changed, 14 inser
Add the member sw_backup to the structures switchdev_obj_ring_role_mrp
and switchdev_obj_in_role_mrp. In this way the SW can call the driver in
2 ways, once when sw_backup is set to false, meaning that the driver
should implement this completely in HW. And if that is not supported the
SW will call
From: Joe Stringer
Add a new target to bpf_doc.py to support generating the list of syscall
commands directly from the UAPI headers. Assuming that developer
submissions keep the main header up to date, this should allow the man
pages to be automatically generated based on the latest API changes
r
From: Joe Stringer
Synchronize the header after all of the recent changes.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
tools/include/uapi/linux/bpf.h | 707 -
1 file changed, 706 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linu
From: Joe Stringer
This docs target will run the scripts/bpf_doc.py against the BPF UAPI
headers to ensure that the parser used for generating manual pages from
the headers doesn't trip on any newly added API documentation.
While we're at it, remove the bpftool-specific docs check target since
t
From: Joe Stringer
Previously, the Makefile here was only targeting a single manual page so
it just hardcoded a bunch of individual rules to specifically handle
build, clean, install, uninstall for that particular page.
Upcoming commits will generate manual pages for an additional section,
so th
From: Joe Stringer
Rename this file in anticipation of it being used for generating more
than just helper man pages.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
include/uapi/linux/bpf.h | 2 +-
scripts/{bpf_helpers_doc.py => bpf_doc.py} | 4 ++--
tools/bpf/Ma
From: Joe Stringer
Based roughly on the following commits:
* Commit cb4d03ab499d ("bpf: Add generic support for lookup batch op")
* Commit 057996380a42 ("bpf: Add batch ops to all htab bpf map")
* Commit aa2e93b8e58e ("bpf: Add generic support for update and delete
batch ops")
Reviewed-by: Que
From: Joe Stringer
Generate the syscall command reference from the UAPI header file and
include it in the main bpf docs page.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
Documentation/Makefile | 2 ++
Documentation/bpf/Makefile | 28 +++
From: Joe Stringer
In anticipation of including make targets for other manual pages in this
makefile, rename it to something a bit more generic.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
tools/bpf/{Makefile.helpers => Makefile.docs} | 2 +-
tools/bpf/bpftool/Documentation/Ma
From: Joe Stringer
Add building of the bpf(2) syscall commands documentation as part of the
docs building step in the build. This allows us to pick up on potential
parse errors from the docs generator script as part of selftests.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
too
From: Joe Stringer
Abstract out the target parameter so that upcoming commits, more than
just the existing "helpers" target can be called to generate specific
portions of docs from the eBPF UAPI headers.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
scripts/bpf_doc.py | 87 +
From: Joe Stringer
Commit 468e2f64d220 ("bpf: introduce BPF_PROG_QUERY command") originally
introduced this, but there have been several additions since then.
Unlike BPF_PROG_ATTACH, it appears that the sockmap progs are not able
to be queried so far.
Reviewed-by: Quentin Monnet
Signed-off-by:
From: Joe Stringer
Based on a brief read of the corresponding source code.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
include/uapi/linux/bpf.h | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf
From: Joe Stringer
Document the prog attach command in more detail, based on git commits:
* commit f4324551489e ("bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH
commands")
* commit 4f738adba30a ("bpf: create tcp_bpf_ulp allowing BPF to monitor
socket TX/RX data")
* commit f4364dcfc86d ("media:
From: Joe Stringer
Commit b2197755b263 ("bpf: add support for persistent maps/progs")
contains the original implementation and git logs, used as reference for
this documentation.
Also pull in the filename restriction as documented in commit 6d8cb045cde6
("bpf: comment why dots in filenames under
From: Joe Stringer
Document the meaning of the BPF_F_LOCK flag for the map lookup/update
descriptions. Based on commit 96049f3afd50 ("bpf: introduce BPF_F_LOCK
flag").
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
CC: Alexei Starovoitov
---
include/uapi/linux/bpf.h | 10 +++
From: Joe Stringer
These descriptions are present in the man-pages project from the
original submissions around 2015-2016. Import them so that they can be
kept up to date as developers extend the bpf syscall commands.
These descriptions follow the pattern used by scripts/bpf_helpers_doc.py
so th
From: Joe Stringer
Introduce high-level descriptions of the intent and return codes of the
bpf() syscall commands. Subsequent patches may further flesh out the
content to provide a more useful programming reference.
Reviewed-by: Quentin Monnet
Signed-off-by: Joe Stringer
---
include/uapi/linu
From: Joe Stringer
The state of bpf(2) manual pages today is not exactly ideal. For the
most part, it was written several years ago and has not kept up with the
pace of development in the kernel tree. For instance, out of a total of
~35 commands to the BPF syscall available today, when I pull the
On 2/16/2021 5:00 PM, patchwork-bot+netdev...@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net-next.git (refs/heads/master):
>
> On Wed, 17 Feb 2021 00:55:42 +0100 you wrote:
>> Support also transmitting frames using the custom "8899 A"
>> 4 byte tag.
>>
>> Qingfang came up
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 17 Feb 2021 00:55:42 +0100 you wrote:
> Support also transmitting frames using the custom "8899 A"
> 4 byte tag.
>
> Qingfang came up with the solution: we need to pad the
> ethernet frame to 60 bytes using eth_skb
> From: Sven Van Asbroeck
>
> On cpu architectures w/o dma cache snooping, dma_unmap() is a is a very
> expensive operation, because its resulting sync needs to invalidate cpu
> caches.
>
> Increase efficiency/performance by syncing only those sections of the
> lan743x's rx ring buffers that are
On 2/10/2021 7:45 AM, Eli Cohen wrote:
On Wed, Feb 10, 2021 at 12:59:03AM -0800, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14
@@@
> > > clock-names = "apb_pclk";
> > > };
> > >
> > > +&wdt {
> > > +status = "okay";
> > > +clocks = <&wdt_clk>;
> > > +};
> > > +
> > > +&gpio {
> > > +
Support also transmitting frames using the custom "8899 A"
4 byte tag.
Qingfang came up with the solution: we need to pad the
ethernet frame to 60 bytes using eth_skb_pad(), then the
switch will happily accept frames with custom tags.
Cc: Mauri Sandberg
Reported-by: DENG Qingfang
Fixes: efd7fe6
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 16:54:51 -0600 you wrote:
> Updates to the Broadcom PHY driver related to use with copper SFP modules.
>
> Changed since v3:
> -fixed kerneldoc error
>
> Changed since v2:
> -Create flag for PHY on SF
On 2/16/2021 2:57 PM, Nathan Rossi wrote:
> On Wed, 17 Feb 2021 at 03:50, Florian Fainelli wrote:
>>
>>
>>
>> On 2/16/2021 5:06 AM, Andrew Lunn wrote:
>>> On Mon, Feb 15, 2021 at 07:02:18AM +, Nathan Rossi wrote:
From: Nathan Rossi
The documentation for MDIO bindings describ
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 16 Feb 2021 12:16:28 +0200 you wrote:
> From: Vladimir Oltean
>
> The following call path suggests that calling unregister_netdev on an
> interface that is up will first bring it down.
>
> enetc_pf_remove
> -> unregis
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Wed, 17 Feb 2021 00:37:06 +0530 you wrote:
> General fixes on amd-xgbe driver are addressed in this series, mostly
> on the mailbox communication failures and improving the link stability
> of the amd-xgbe device.
>
> Shyam
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 22:33:42 + you wrote:
> The changes made in eccd540 is enough for xilinx_emaclite to run
> without problem on 64-bit systems. I have tested it on a Xilinx
> FPGA with RV64 softcore. The architecture
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 22:41:57 +0100 you wrote:
> This patch series extends MRP switchdev to allow the SW to have a better
> understanding if the HW can implement the MRP functionality or it needs
> to help the HW to run it.
Hello:
This pull request was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 14:24:38 -0800 you wrote:
> Hi Dave, Jakub, Jason
>
> The patches in this pr are already submitted and reviewed through the
> netdev and rdma mailing lists.
>
> The series includes mlx5 HW bits
On Wed, 17 Feb 2021 at 03:50, Florian Fainelli wrote:
>
>
>
> On 2/16/2021 5:06 AM, Andrew Lunn wrote:
> > On Mon, Feb 15, 2021 at 07:02:18AM +, Nathan Rossi wrote:
> >> From: Nathan Rossi
> >>
> >> The documentation for MDIO bindings describes the "broken-turn-around",
> >> "reset-assert-us"
Add a flag and helper function to indicate that a PHY device is part of
an SFP module, which is set on attach. This can be used by PHY drivers
to handle SFP-specific quirks or behavior.
Signed-off-by: Robert Hancock
---
drivers/net/phy/phy_device.c | 2 ++
include/linux/phy.h | 11
bcm54xx_config_init was modifying the PHY LED configuration to enable link
and activity indications. However, some SFP modules (such as Bel-Fuse
SFP-1GBT-06) have no LEDs but use the LED outputs to control the SFP LOS
signal, and modifying the LED settings will cause the LOS output to
malfunction.
The default configuration for the BCM54616S PHY may not match the desired
mode when using 1000BaseX or SGMII interface modes, such as when it is on
an SFP module. Add code to explicitly set the correct mode using
programming sequences provided by Bel-Fuse:
https://www.belfuse.com/resources/datashe
Updates to the Broadcom PHY driver related to use with copper SFP modules.
Changed since v3:
-fixed kerneldoc error
Changed since v2:
-Create flag for PHY on SFP module and use that rather than accessing
attached_dev directly in PHY driver
Changed since v1:
-Reversed conditional to reduce inden
On Tue, Feb 16, 2021 at 11:08:37AM -0800, Florian Fainelli wrote:
> The tg3 driver tried to communicate towards the PHY driver whether it
> wanted RGMII in-band signaling enabled or disabled however there is
> nothing that looks at those flags in drivers/net/phy/broadcom.c so this
> does do not any
The changes made in eccd540 is enough for xilinx_emaclite to run
without problem on 64-bit systems. I have tested it on a Xilinx
FPGA with RV64 softcore. The architecture limitation in Kconfig
seems no longer necessary.
A small change is included to print address with %lx instead of
casting to int
Hi Dave, Jakub, Jason
The patches in this pr are already submitted and reviewed through the
netdev and rdma mailing lists.
The series includes mlx5 HW bits and definitions for mlx5 real time clock
translation and handling in the mlx5 driver clock module to enable and
support such mode [1]
[1]
h
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 11:08:37 -0800 you wrote:
> The tg3 driver tried to communicate towards the PHY driver whether it
> wanted RGMII in-band signaling enabled or disabled however there is
> nothing that looks at those flags
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 20:20:51 +0100 you wrote:
> Hello,
>
> there is still some testing needed for Amethyst patches, so I have
> split the part adding support for 5gbase-r interface mode and am sending
> it alone.
>
> The
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 14:53:30 -0600 you wrote:
> When 88E is operating in SGMII mode, auto-negotiation should be enabled
> on the SGMII side so that the link will come up properly with PCSes which
> normally have auto-ne
>
> I can't help but think you are evading my question I asked. If there is no
> specific action that this pcm4l tool needs to perform, then I'd think we
> should better not provide any interface for it at all.
>
> I also found a reference to only closed source software at
> https://www.renesas.c
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 13:32:13 +0200 you wrote:
> From: Vladimir Oltean
>
> If the driver fails to probe, it would be nice to not leak memory.
>
> Signed-off-by: Vladimir Oltean
> ---
> I've decided to target this patch t
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 13:41:17 +0200 you wrote:
> From: Vladimir Oltean
>
> I am resending this series because the title and the patches were mixed
> up and these patches were lost. This series' cover letter was used as
>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 17:09:36 +0530 you wrote:
> This patch fixes references to uninitialized variables and
> debugfs entry name for CN10K platform and HW_TSO flag check.
>
> Fixes: 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC i
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 13:14:46 +0200 you wrote:
> From: Vladimir Oltean
>
> ocelot_init_port is called only if dsa_is_unused_port == false, however
> ocelot_deinit_port is called unconditionally. This causes a warning in
>
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 16:29:41 +0100 you wrote:
> 3 different fixes applied to VSC8514:
> LCPLL reset, serdes calibration and coma mode disabled.
> Especially the serdes calibration is large and is now placed
> in a new file
On Tue, 2021-02-16 at 16:03 -0400, Jason Gunthorpe wrote:
> On Fri, Feb 12, 2021 at 02:30:37PM -0800, Saeed Mahameed wrote:
> > From: Aharon Landau
> >
> > These fields declare which timestamp mode is supported by the
> > device
> > per RQ/SQ/QP.
> >
> > In addition add the ts_format field to th
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 16 Feb 2021 12:05:30 +0800 you wrote:
> From: Chen Lin
>
> Remove the 'ionic_reset_cb' typedef as it is not used.
>
> Signed-off-by: Chen Lin
> ---
> drivers/net/ethernet/pensando/ionic/ionic_lif.h |2 --
>
On Mon, 2021-02-15 at 11:30 +0300, Dan Carpenter wrote:
> On Mon, Sep 28, 2020 at 06:31:04PM +, Ariel Levkovich wrote:
> > On Sep 28, 2020, at 13:42, Dan Carpenter
> > wrote:
> > >
> > > The mlx5_tc_ct_init() function doesn't return error pointers it
> > > returns
> > > NULL. Also we need t
Hi Bryan,
On Tue, Feb 16, 2021 at 3:50 PM wrote:
>
> Looks Good, Thanks Sven
> Our testing is in progress, We will let you know our results soon.
>
> Reviewed-by: Bryan Whitehead
>
Thank you Bryan, I really appreciate your help and expertise.
On Mon, 2021-02-15 at 11:52 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the net-next tree got conflicts in:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
>
> between commit:
>
> e4484d9df500 ("net/mlx5e
On 2/15/21 8:05 PM, Chen Lin wrote:
From: Chen Lin
Remove the 'ionic_reset_cb' typedef as it is not used.
Signed-off-by: Chen Lin
---
drivers/net/ethernet/pensando/ionic/ionic_lif.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.h
b/d
1 - 100 of 242 matches
Mail list logo
