These defines are used with set_bit() and test_bit() which take a bit
number.  In other words, the code is doing:

        if (BIT(BIT(1)) & pf->hw.cap_flag) {

This was done consistently so it did not cause a problem at runtime but
it's still worth fixing.

Fixes: facede8209ef ("octeontx2-pf: cn10k: Add mbox support for CN10K")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h 
b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
index 4c472646a0ac..19aef37b8ef9 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
@@ -210,9 +210,9 @@ struct otx2_hw {
        u64                     cgx_fec_uncorr_blks;
        u8                      cgx_links;  /* No. of CGX links present in HW */
        u8                      lbk_links;  /* No. of LBK links present in HW */
-#define HW_TSO                 BIT_ULL(0)
-#define CN10K_MBOX             BIT_ULL(1)
-#define CN10K_LMTST            BIT_ULL(2)
+#define HW_TSO                 0
+#define CN10K_MBOX             1
+#define CN10K_LMTST            2
        unsigned long           cap_flag;
 
 #define LMT_LINE_SIZE          128
-- 
2.30.0

Reply via email to