On Wed, Feb 17, 2021 at 7:55 AM Linus Walleij <linus.wall...@linaro.org> wrote: > > + if (skb_cow_head(skb, RTL4_A_HDR_LEN) < 0) > + return NULL;
skb_cow_head is unnecessary here. DSA core will do it for you. > + > + out = (RTL4_A_PROTOCOL_RTL8366RB << 12) | (2 << 8); > + /* The lower bits is the port numer */ Typo? > + out |= (u8)dp->index; > + p = (u16 *)(tag + 2); > + *p = htons(out); > + > return skb; > } > > -- > 2.29.2 >
