RE: [EXT] Re: [PATCH v8 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree

2021-02-06 Thread Stefan Chulski
> -- > On Sat, 6 Feb 2021 18:45:48 +0200 stef...@marvell.com wrote: > > From: Konstantin Porotchkin > > > > CM3 SRAM address space would be used for Flow Control configuration. > > > > Signed-off-by: Stefan Chulski > > Signed-off

[PATCH] bpf/benchs/bench_ringbufs: remove unneeded semicolon

2021-02-06 Thread Yang Li
Eliminate the following coccicheck warning: ./tools/testing/selftests/bpf/benchs/bench_ringbufs.c:322:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

memory leak in __ieee80211_beacon_get

2021-02-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3aaf0a27 Merge tag 'clang-format-for-linux-v5.11-rc7' of g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10f79330d0 kernel config: https://syzkaller.appspot.com/x/.config?x=b7edd79f26f7c0c3 das

Re: pull-request: wireless-drivers-2021-02-05

2021-02-06 Thread Kalle Valo
Lorenzo Bianconi writes: >> On Fri, 5 Feb 2021 16:34:34 + (UTC) Kalle Valo wrote: >> > Hi, >> > >> > here's a pull request to net tree, more info below. Please let me know if >> > there >> > are any problems. >> >> Pulled, thanks! One thing to confirm tho.. >> >> > ath9k >> > >> > * fix

[PATCH net v4] net/sched: cls_flower: Reject invalid ct_state flags rules

2021-02-06 Thread wenxu
From: wenxu Reject the unsupported and invalid ct_state flags of cls flower rules. Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info") Signed-off-by: wenxu --- net/sched/cls_flower.c | 36 +++- 1 file changed, 35 insertions(+), 1 deleti

[PATCH net 1/2] bridge: mrp: Fix the usage of br_mrp_port_switchdev_set_state

2021-02-06 Thread Horatiu Vultur
The function br_mrp_port_switchdev_set_state was called both with MRP port state and STP port state, which is an issue because they don't match exactly. Therefore, update the function to be used only with STP port state and use the id SWITCHDEV_ATTR_ID_PORT_STP_STATE. The choice of using STP over

[PATCH net 2/2] switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT

2021-02-06 Thread Horatiu Vultur
Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere else, therefore we can remove it. Fixes: c284b545900830 ("switchdev: mrp: Extend switchdev API to offload MRP") Signed-off-by: Horatiu Vultur --- include/net/

[PATCH net 0/2] bridge: mrp: Fix br_mrp_port_switchdev_set_state

2021-02-06 Thread Horatiu Vultur
Based on the discussion here[1], there was a problem with the function br_mrp_port_switchdev_set_state. The problem was that it was called both with BR_STATE* and BR_MRP_PORT_STATE* types. This patch series fixes this issue and removes SWITCHDEV_ATTR_ID_MRP_PORT_STAT because is not used anymore. [

Re: [PATCH net-next v2 1/4] net: hsr: generate supervision frame without HSR/PRP tag

2021-02-06 Thread Vladimir Oltean
On Thu, Feb 04, 2021 at 03:59:23PM -0600, George McCollister wrote: > @@ -289,23 +286,12 @@ static void send_hsr_supervision_frame(struct hsr_port > *master, > hsr->announce_count++; > } > > - if (!hsr->prot_version) > - proto = ETH_P_PRP; > - else > -

Re: [PATCH] net/vmw_vsock: fix NULL pointer dereference

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 18:13:35 +0100 Stefano Garzarella wrote: > On Fri, Feb 05, 2021 at 03:25:17PM +0100, Norbert Slusarek wrote: > >From: Norbert Slusarek > >Date: Fri, 5 Feb 2021 13:12:06 +0100 > >Subject: [PATCH] net/vmw_vsock: fix NULL pointer dereference > > > >In vsock_stream_connect(), a thre

Re: [PATCH] net/vmw_vsock: improve locking in vsock_connect_timeout()

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 18:19:51 +0100 Stefano Garzarella wrote: > On Fri, Feb 05, 2021 at 03:32:02PM +0100, Norbert Slusarek wrote: > >From: Norbert Slusarek > >Date: Fri, 5 Feb 2021 13:14:05 +0100 > >Subject: [PATCH] net/vmw_vsock: improve locking in vsock_connect_timeout() > > > >A possible locking

Re: [PATCH net-next] net/packet: Improve the comment about LL header visibility criteria

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 21:51:36 -0500 Willem de Bruijn wrote: > On Fri, Feb 5, 2021 at 5:42 PM Xie He wrote: > > > > The "dev_has_header" function, recently added in > > commit d549699048b4 ("net/packet: fix packet receive on L3 devices > > without visible hard header"), > > is more accurate as criter

[PATCH v3] usb: serial: option: update interface mapping for ZTE P685M

2021-02-06 Thread Lech Perczak
This patch prepares for qmi_wwan driver support for the device. Previously "option" driver mapped itself to interfaces 0 and 3 (matching ff/ff/ff), while interface 3 is in fact a QMI port. Interfaces 1 and 2 (matching ff/00/00) expose AT commands, and weren't supported previously at all. Without th

Re: [PATCH net-next] net: dsa: allow port mirroring towards foreign interfaces

2021-02-06 Thread Jakub Kicinski
On Sun, 7 Feb 2021 02:16:17 +0200 Vladimir Oltean wrote: > On Sat, Feb 06, 2021 at 03:58:57PM -0800, Jakub Kicinski wrote: > > > For ingress mirroring there should be nothing special about the mirror > > > packets, it's just more traffic in the ingress data path where the qdisc > > > hook already e

Re: [PATCH net-next v2 00/11][pull request] 100GbE Intel Wired LAN Driver Updates 2021-02-05

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 20:40:50 -0800 you wrote: > This series contains updates to ice driver only. > > Jake adds adds reporting of timeout length during devlink flash and > implements support to report devlink info regardin

Re: [PATCH net-next] net: dsa: allow port mirroring towards foreign interfaces

2021-02-06 Thread Vladimir Oltean
On Sat, Feb 06, 2021 at 03:58:57PM -0800, Jakub Kicinski wrote: > > For ingress mirroring there should be nothing special about the mirror > > packets, it's just more traffic in the ingress data path where the qdisc > > hook already exists. > > For ingress the only possible corner case seems to be

Re: [PATCH net-next 1/7] netfilter: ctnetlink: remove get_ct indirection

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 6 Feb 2021 02:49:59 +0100 you wrote: > From: Florian Westphal > > Use nf_ct_get() directly, its a small inline helper without dependencies. > > Add CONFIG_NF_CONNTRACK guards to elide the relevant part when con

Re: [PATCH net-next] net: dsa: allow port mirroring towards foreign interfaces

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 01:05:21 +0200 Vladimir Oltean wrote: > On Fri, Feb 05, 2021 at 02:42:55PM -0800, Florian Fainelli wrote: > > How does the mirred action deal with that case? How does it know that > > packets delivered to the DSA master should be sent towards a foreign > > address, do I need to s

Re: [PATCH net-next v2 4/4] net: dsa: xrs700x: add HSR offloading support

2021-02-06 Thread Vladimir Oltean
On Thu, Feb 04, 2021 at 03:59:26PM -0600, George McCollister wrote: > +static int xrs700x_hsr_join(struct dsa_switch *ds, int port, > + struct net_device *hsr) > +{ > + unsigned int val = XRS_HSR_CFG_HSR_PRP; > + struct dsa_port *partner = NULL, *dp; > + struct x

Re: [RESEND PATCH net-next 1/4] net: hsr: generate supervision frame without HSR tag

2021-02-06 Thread Vladimir Oltean
On Tue, Feb 02, 2021 at 08:49:25AM -0600, George McCollister wrote: > > > > Why is it such a big deal if supervision frames have HSR/PRP tag or not? > > > > > > Because if the switch does automatic HSR/PRP tag insertion it will end > > > up in there twice. You simply can't send anything with an HSR

Re: [PATCH v8 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 18:45:48 +0200 stef...@marvell.com wrote: > From: Konstantin Porotchkin > > CM3 SRAM address space would be used for Flow Control configuration. > > Signed-off-by: Stefan Chulski > Signed-off-by: Konstantin Porotchkin Isn't there are requirement to CC the DT mailing list an

Re: [PATCH net-next v2 3/4] net: dsa: add support for offloading HSR

2021-02-06 Thread Vladimir Oltean
On Thu, Feb 04, 2021 at 03:59:25PM -0600, George McCollister wrote: > @@ -1935,6 +1936,19 @@ static int dsa_slave_changeupper(struct net_device > *dev, > dsa_port_lag_leave(dp, info->upper_dev); > err = NOTIFY_OK; > } > + } else if (is_

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: > From: Arjun Roy > > Explicitly define reserved field and require it to be 0-valued. > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index e1a17c6b473c..c8469c579ed8 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -4159,6 +4159,8 @@

Re: [PATCH net-next] r8169: don't try to disable interrupts if NAPI is scheduled already

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 22:48:53 +0100 you wrote: > There's no benefit in trying to disable interrupts if NAPI is > scheduled already. This allows us to save a PCI write in this case. > > Signed-off-by: Heiner Kallweit > --- >

Re: [PATCH net V1 0/1] Fix XDP bug in ENA driver

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 5 Feb 2021 21:51:13 +0200 you wrote: > Hi all, > This single patch fixes a bug spotted in previous XDP Redirect implementation > in > ENA. > > Shay Agroskin (1): > net: ena: Update XDP verdict upon failure > > [...]

Re: [PATCH RESEND v3 net-next 00/12] LAG offload for Ocelot DSA switches

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 6 Feb 2021 00:02:09 +0200 you wrote: > From: Vladimir Oltean > > This patch series reworks the ocelot switchdev driver such that it could > share the same implementation for LAG offload as the felix DSA driver.

Re: [PATCH net-next v2 0/7] net: ipa: a mix of small improvements

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 16:10:53 -0600 Alex Elder wrote: > Version 2 of this series restructures a couple of the changed > functions (in patches 1 and 2) to avoid blocks of indented code > by returning early when possible, as suggested by Jakub. The > description of the first patch was changed as a re

Re: [PATCH v3 net-next 0/4] Automatically manage DSA master interface state

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 15:37:09 +0200 you wrote: > This patch series adds code that makes DSA open the master interface > automatically whenever one user interface gets opened, either by the > user, or by various networking s

Re: [PATCH V2 net-next 0/6] net: hns3: updates for -nex

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 16:32:43 +0800 you wrote: > This series adds some code optimizations and compatibility > handlings for the HNS3 ethernet driver. > > change log: > V2: refactor #2 as Jukub Kicinski reported and remove t

Re: [PATCH net-next 0/2] mptcp: Misc. updates for tests & lock annotation

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 15:23:28 -0800 you wrote: > Here are two fixes we've collected in the mptcp tree. > > Patch 1 refactors a MPTCP selftest script to allow running a subset of > the tests. > > Patch 2 adds some locking

Re: [PATCH net-next v2 0/3] dpaa2: add 1000base-X support

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 10:39:00 + you wrote: > Hi, > > This patch series adds 1000base-X support to pcs-lynx and DPAA2, > allowing runtime switching between SGMII and 1000base-X. This is > a pre-requisit for SFP module su

Re: [PATCH 0/3] Fix some seq_file users that were recently broken

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 14:35:50 -0800 Andrew Morton wrote: > On Fri, 05 Feb 2021 11:36:30 +1100 NeilBrown wrote: > > > A recent change to seq_file broke some users which were using seq_file > > in a non-"standard" way ... though the "standard" isn't documented, so > > they can be excused. The resul

Re: [PATCH] net: core: Clean code style issues in `neighbour.c`

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 14:28:21 +0800 Zheng Yongjun wrote: > Do code format alignment to clean code style issues. > > Signed-off-by: Zheng Yongjun I don't think these changes make the code substantively more readable. At the same time they make the history harder to follow and may cause backporting

Re: [PATCH net v3] net/sched: cls_flower: Reject invalid ct_state flags rules

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 15:07:30 +0800 we...@ucloud.cn wrote: > From: wenxu > > Reject the unsupported and invalid ct_state flags of cls flower rules. > > Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info") > Signed-off-by: wenxu > --- > v3: using NLA_POLICY_MASK and NL_SE

Re: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 19:21:44 +0800 Joakim Zhang wrote: > +err_reinit_rx_buffers: > + while (queue >= 0) { > + while (--i >= 0) > + stmmac_free_rx_buffer(priv, queue, i); > + > + if (queue == 0) > + break; > + > + i = pr

[net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread Arjun Roy
From: Arjun Roy Explicitly define reserved field and require it to be 0-valued. Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive zerocopy.") Signed-off-by: Arjun Roy Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh Suggested-by: David Ahern Suggested-by: L

Re: [PATCH V4 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 19:21:42 +0800 Joakim Zhang wrote: > Driver uses dma_alloc_coherent to allocate dma memory for descriptors, > dma_alloc_coherent will return both the virtual address and physical > address. AFAIK, virt_to_phys could not convert virtual address to > physical address, for which me

Re: [PATCH] net: wan: farsync: use new tasklet API

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 18:39:47 +0100 you wrote: > This converts the driver to use the new tasklet API introduced in > commit 12cc923f1ccc ("tasklet: Introduce new initialization API") > > The new API changes the argument pas

Re: [PATCH net-next v3 0/4] net: Avoid the memory waste in some Ethernet drivers

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 18:56:34 +0800 you wrote: > Hi, > > v3: > - Adjust patch 1 and 2 according to Alexander's suggestion. > - Add Tested-by from Subbaraya. > - Add Reviewed-by from Ioana. > > [...] Here is the sum

Re: [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 15:50:41 +0100 Lech Perczak wrote: > >> Cc: Bjørn Mork > >> Signed-off-by: Lech Perczak > > Patch looks fine to me. But I don't think you can submit a net and usb > > serial patch in a series. These are two different subsystems. > > > > There's no dependency between the patche

Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 16:01:43 -0800 Amy Parker wrote: > This patchset updates atarilance.c and sun3lance.c to follow the kernel > style guide. Each patch tackles a different issue in the style guide. These are very, very old drivers, nobody worked on them for a decade. What's your motivation for ma

Re: [PATCH] net: dwc-xlgmac: Fix spelling mistake in function name

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 09:49:44 + you wrote: > From: Colin Ian King > > There is a spelling mistake in the function name alloc_channles_and_rings. > Fix this by renaming it to alloc_channels_and_rings. > > Signed-off-by

Re: pull-request: wireless-drivers-2021-02-05

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 20:43:25 +0100 Lorenzo Bianconi wrote: > > Lorenzo, I'm just guessing what this code does, but you're dropping a > > frag without invalidating the rest of the SKB, which I presume is now > > truncated? Shouldn't the skb be dropped? > > > > Hi Jakub, > > I agree. We can do so

[PATCH RESEND net-next] cfg80211: remove unused callback

2021-02-06 Thread Matteo Croce
From: Matteo Croce The ieee80211 class registers a callback which actually does nothing. Given that the callback is optional, and all its accesses are protected by a NULL check, remove it entirely. Signed-off-by: Matteo Croce --- net/wireless/sysfs.c | 7 --- 1 file changed, 7 deletions(-)

Re: [PATCH net-next] cfg80211: remove unused callback

2021-02-06 Thread Matteo Croce
On Sat, Feb 6, 2021 at 1:29 PM Matteo Croce wrote: > > From: Matteo Croce > > The ieee80211 class registers a callback which actually does nothing. > Given that the callback is optional, and all its accesses are protected > by a NULL check, remove it entirely. > > Signed-off-by: Matteo Croce > -

Re: pull-request: wireless-drivers-2021-02-05

2021-02-06 Thread Lorenzo Bianconi
> On Fri, 5 Feb 2021 16:34:34 + (UTC) Kalle Valo wrote: > > Hi, > > > > here's a pull request to net tree, more info below. Please let me know if > > there > > are any problems. > > Pulled, thanks! One thing to confirm tho.. > > > ath9k > > > > * fix build regression related to LEDS_CLASS

Re: [PATCH net-next v5 1/2] net: mhi-net: Add re-aggregation of fragmented packets

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 09:40:00 +0100 Loic Poulain wrote: > When device side MTU is larger than host side MTU, the packets > (typically rmnet packets) are split over multiple MHI transfers. > In that case, fragments must be re-aggregated to recover the packet > before forwarding to upper layer. > > A

Re: [PATCH net-next] net/packet: Improve the comment about LL header visibility criteria

2021-02-06 Thread Xie He
On Sat, Feb 6, 2021 at 7:43 AM Eyal Birger wrote: > > As such, may I suggest making this explicit by making > dev_hard_header() use dev_has_header()? That is a good idea. We may submit another patch for that.

Re: [PATCH net-next] net: sched: Return the correct errno code

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 15:39:50 +0800 you wrote: > When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. > > Signed-off-by: Zheng Yongjun > --- > net/sched/em_nbyte.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH net-next] dccp: Return the correct errno code

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 15:28:20 +0800 you wrote: > When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. > > Signed-off-by: Zheng Yongjun > --- > net/dccp/feat.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] net: bridge: mcast: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 07:05:49 + you wrote: > Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). > > net/bridge/br_multicast.c:1246:9-16: WARNING: ERR_CAST can be used with mp > Generated by: scripts/coccine

Re: [PATCH net-next] net: core: Return the correct errno code

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 11:19:23 +0800 Zheng Yongjun wrote: > When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. > > Signed-off-by: Zheng Yongjun > --- > net/core/rtnetlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/rtnetlink.c b/net/core

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

2021-02-06 Thread Julien Grall
Hi Juergen, On 06/02/2021 10:49, Juergen Gross wrote: The first three patches are fixes for XSA-332. The avoid WARN splats and a performance issue with interdomain events. Thanks for helping to figure out the problem. Unfortunately, I still see reliably the WARN splat with the latest Linux ma

Re: [PATCH net-next] net: ipv4: Return the correct errno code

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 15:26:57 +0800 Zheng Yongjun wrote: > When kalloc or kmemdup failed, should return ENOMEM rather than ENOBUF. > > Signed-off-by: Zheng Yongjun > --- > net/ipv4/devinet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/devinet.c b/net/ipv4/dev

Re: [PATCH net-next] net: Return the correct errno code

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 11:14:26 -0800 Jesse Brandeburg wrote: > Zheng Yongjun wrote: > > > When kzalloc failed, should return ENOMEM rather than ENOBUFS. > > All these patches have the same subject and description, couldn't they > just be part of a single series with a good cover letter? Agreed. T

Re: [PATCH net-next] net: ethernet: ti: fix netdevice stats for XDP

2021-02-06 Thread Jakub Kicinski
On Wed, 3 Feb 2021 19:06:17 +0100 Lorenzo Bianconi wrote: > Align netdevice statistics when the device is running in XDP mode > to other upstream drivers. In particular reports to user-space rx report > packets even if they are not forwarded to the networking stack > (XDP_PASS) but if they are r

Re: [PATCH v2 2/2] ibmvnic: fix race with multiple open/close

2021-02-06 Thread Jakub Kicinski
On Wed, 3 Feb 2021 12:56:52 -0800 Sukadev Bhattiprolu wrote: > Willem de Bruijn [willemdebruijn.ker...@gmail.com] wrote: > > On Wed, Feb 3, 2021 at 12:10 AM Sukadev Bhattiprolu > > wrote: > > > > > > If two or more instances of 'ip link set' commands race and first one > > > already brings the i

Re: [PATCH] dpaa2-eth: Simplify the calculation of variables

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 2 Feb 2021 18:02:37 +0800 you wrote: > Fix the following coccicheck warnings: > > ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1651:36-38: WARNING > !A || A && B is equivalent to !A || B. > > Reported-by: A

Re: [PATCH 1/1] ibmvnic: Clear failover_pending if unable to schedule

2021-02-06 Thread Jakub Kicinski
On Tue, 2 Feb 2021 21:08:02 -0800 Sukadev Bhattiprolu wrote: > Normally we clear the failover_pending flag when processing the reset. > But if we are unable to schedule a failover reset we must clear the > flag ourselves. We could fail to schedule the reset if we are in PROBING > state (eg: when b

Re: [PATCH net-next 5/7] netdevsim: Simulate port function state for a PCI port

2021-02-06 Thread kernel test robot
Hi Parav, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [PATCH net-next 1/7] netdevsim: Add support for add and delete of a PCI PF port

2021-02-06 Thread kernel test robot
Hi Parav, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-06 Thread Marcelo Ricardo Leitner
Hi, I didn't receive the cover letter, so I'm replying on this one. :-) This is nice. One thing is not clear to me yet. From the samples on the cover letter: $ tc -s filter show dev enp8s0f0_1 ingress filter protocol ip pref 4 flower chain 0 filter protocol ip pref 4 flower chain 0 handle 0x1

Re: [RFC PATCH 14/16] gtp: add support for flow based tunneling

2021-02-06 Thread Jonas Bonn
Hi Pravin et al; TL;DR: we don't need to introduce an entire collect_md mode to the driver; we just need to tweak what we've got so that metadata is "always" added on RX and respected on TX; make the userspace socket optional and dump GTP packets to netstack if it's not present; and make a d

Re: pull-request: wireless-drivers-next-2021-02-05

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 16:19:01 + (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with

Re: [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes under XDP

2021-02-06 Thread Jakub Kicinski
On Thu, 4 Feb 2021 18:49:25 +0200 Camelia Groza wrote: > This series addresses issue with the current workaround for the A050385 > erratum in XDP scenarios. > > The first patch makes sure the xdp_frame structure stored at the start of > new buffers isn't overwritten. > > The second patch decreas

Re: [PATCH net-next 2/7] netdevsim: Add support for add and delete PCI SF port

2021-02-06 Thread kernel test robot
Hi Parav, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: pull-request: wireless-drivers-2021-02-05

2021-02-06 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Fri, 5 Feb 2021 16:34:34 + (UTC) you wrote: > Hi, > > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. > > Kalle > > [...] Here is the summary with links:

Re: pull-request: wireless-drivers-2021-02-05

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 16:34:34 + (UTC) Kalle Valo wrote: > Hi, > > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. Pulled, thanks! One thing to confirm tho.. > ath9k > > * fix build regression related to LEDS_CLASS > > mt76 > > * fix a

Re: [net v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread Jakub Kicinski
On Sat, 6 Feb 2021 09:19:03 -0800 Jakub Kicinski wrote: > On Fri, 5 Feb 2021 23:02:03 -0800 Arjun Roy wrote: > > From: Arjun Roy > > > > Explicitly define reserved field and require it to be 0-valued. > > > > Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive > > zerocopy.")

Re: [net v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread Jakub Kicinski
On Fri, 5 Feb 2021 23:02:03 -0800 Arjun Roy wrote: > From: Arjun Roy > > Explicitly define reserved field and require it to be 0-valued. > > Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive > zerocopy.") > Signed-off-by: Arjun Roy > Signed-off-by: Eric Dumazet > Signed-of

Re: [net-next PATCH v4 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2021-02-06 Thread Calvin Johnson
On Fri, Feb 05, 2021 at 08:58:06PM +0200, Andy Shevchenko wrote: > On Fri, Feb 5, 2021 at 8:41 PM Andy Shevchenko > wrote: > > On Fri, Feb 5, 2021 at 8:25 PM Andy Shevchenko > > wrote: > > > On Fri, Feb 5, 2021 at 7:25 PM Calvin Johnson > > > wrote: > > > > On Fri, Jan 22, 2021 at 09:12:52PM +05

[PATCH net-next v2] seg6: fool-proof the processing of SRv6 behavior attributes

2021-02-06 Thread Andrea Mayer
The set of required attributes for a given SRv6 behavior is identified using a bitmap stored in an unsigned long, since the initial design of SRv6 networking in Linux. Recently the same approach has been used for identifying the optional attributes. However, the number of attributes supported by S

[PATCH v8 net-next 15/15] net: mvpp2: add TX FC firmware check

2021-02-06 Thread stefanc
From: Stefan Chulski Patch check that TX FC firmware is running in CM3. If not, global TX FC would be disabled. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 42 2 files changed,

[PATCH v8 net-next 14/15] net: mvpp2: set 802.3x GoP Flow Control mode

2021-02-06 Thread stefanc
From: Stefan Chulski This patch fix GMAC TX flow control autoneg. Flow control autoneg wrongly were disabled with enabled TX flow control. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v8 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control

2021-02-06 Thread stefanc
From: Stefan Chulski New FIFO flow control feature was added in PPv23. PPv2 FIFO polled by HW and trigger pause frame if FIFO fill level is below threshold. FIFO HW flow control enabled with CM3 RXQ&BM flow control with ethtool. Current FIFO thresholds is: 9KB for port with maximum speed 10Gb/s

[PATCH v8 net-next 11/15] net: mvpp2: add ethtool flow control configuration support

2021-02-06 Thread stefanc
From: Stefan Chulski This patch add ethtool flow control configuration support. Tx flow control retrieved correctly by ethtool get function. FW per port ethtool configuration capability added. Patch also takes care about mtu change procedure, if PPv2 switch BM pools during mtu change. Signed-o

[PATCH v8 net-next 12/15] net: mvpp2: add BM protection underrun feature support

2021-02-06 Thread stefanc
From: Stefan Chulski The PP2v23 hardware supports a feature allowing to double the size of BPPI by decreasing number of pools from 16 to 8. Increasing of BPPI size protect BM drop from BPPI underrun. Underrun could occurred due to stress on DDR and as result slow buffer transition from BPPE to BP

[PATCH v8 net-next 10/15] net: mvpp2: add RXQ flow control configurations

2021-02-06 Thread stefanc
From: Stefan Chulski This patch adds RXQ flow control configurations. Flow control disabled by default. Minimum ring size limited to 1024 descriptors. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 35 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

[PATCH v8 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-06 Thread stefanc
From: Stefan Chulski The firmware needs to monitor the RX Non-occupied descriptor bits for flow control to move to XOFF mode. These bits need to be unmasked to be functional, but they will not raise interrupts as we leave the RX exception summary bit in MVPP2_ISR_RX_TX_MASK_REG clear. Signed-off

[PATCH v8 net-next 09/15] net: mvpp2: enable global flow control

2021-02-06 Thread stefanc
From: Stefan Chulski This patch enables global flow control in FW and in the phylink validate mask. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 ++--- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 30 +++- 2 files changed, 38 i

[PATCH v8 net-next 07/15] net: mvpp2: add FCA periodic timer configurations

2021-02-06 Thread stefanc
From: Stefan Chulski Flow Control periodic timer would be used if port in XOFF to transmit periodic XOFF frames. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 45 2 files cha

[PATCH v8 net-next 06/15] net: mvpp2: increase BM pool and RXQ size

2021-02-06 Thread stefanc
From: Stefan Chulski BM pool and RXQ size increased to support Firmware Flow Control. Minimum depletion thresholds to support FC are 1024 buffers. BM pool size increased to 2048 to have some 1024 buffers space between depletion thresholds and BM pool size. Jumbo frames require a 9888B buffer, so

[PATCH v8 net-next 05/15] net: mvpp2: add PPv23 version definition

2021-02-06 Thread stefanc
From: Stefan Chulski This patch add PPv23 version definition. PPv23 is new packet processor in CP115. Everything that supported by PPv22, also supported by PPv23. No functional changes in this stage. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 +++

[PATCH v8 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21

2021-02-06 Thread stefanc
From: Stefan Chulski Currently we have PP2v1 and PP2v2 hw-versions, with some different handlers depending upon condition hw_version = MVPP21/MVPP22. In a future there will be also PP2v3. Let's use now the generic "if equal/notEqual MVPP21" for all cases instead of "if MVPP22". This patch does n

[PATCH v8 net-next 03/15] net: mvpp2: add CM3 SRAM memory map

2021-02-06 Thread stefanc
From: Stefan Chulski This patch adds CM3 memory map and CM3 read/write callbacks. No functionality changes. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 +++ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 63 +++- 2 files changed, 67

[PATCH v8 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree

2021-02-06 Thread stefanc
From: Konstantin Porotchkin CM3 SRAM address space would be used for Flow Control configuration. Signed-off-by: Stefan Chulski Signed-off-by: Konstantin Porotchkin --- arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot

[PATCH v8 net-next 01/15] doc: marvell: add cm3-mem and PPv2.3 description

2021-02-06 Thread stefanc
From: Stefan Chulski Patch introduce cm3-mem device tree bindings and add PPv2.3 description. Signed-off-by: Stefan Chulski --- Documentation/devicetree/bindings/net/marvell-pp2.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/mar

[PATCH v8 net-next 00/15] net: mvpp2: Add TX Flow Control support

2021-02-06 Thread stefanc
From: Stefan Chulski Armada hardware has a pause generation mechanism in GOP (MAC). The GOP generate flow control frames based on an indication programmed in Ports Control 0 Register. There is a bit per port. However assertion of the PortX Pause bits in the ports control 0 register only sends a

Re: [PATCH bpf v2] selftests/bpf: remove bash feature in test_xdp_redirect.sh

2021-02-06 Thread Randy Dunlap
On 2/6/21 1:26 AM, Björn Töpel wrote: > From: Björn Töpel > > The test_xdp_redirect.sh script uses a bash redirect feature, > '&>/dev/null'. Use '>/dev/null 2>&1' instead. > > Also remove the 'set -e' since the script actually relies on that the > return value can be used to determine pass/fail

Re: [PATCH net-next 1/7] netdevsim: Add support for add and delete of a PCI PF port

2021-02-06 Thread kernel test robot
Hi Parav, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

Re: [net v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-06 Thread David Ahern
On 2/6/21 12:02 AM, Arjun Roy wrote: > From: Arjun Roy > > Explicitly define reserved field and require it to be 0-valued. > > Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive > zerocopy.") > Signed-off-by: Arjun Roy > Signed-off-by: Eric Dumazet > Signed-off-by: Soheil Ha

Re: [PATCH net-next] net/packet: Improve the comment about LL header visibility criteria

2021-02-06 Thread Eyal Birger
Hi, On Sat, Feb 6, 2021 at 4:52 AM Willem de Bruijn wrote: > > On Fri, Feb 5, 2021 at 5:42 PM Xie He wrote: > > > > The "dev_has_header" function, recently added in > > commit d549699048b4 ("net/packet: fix packet receive on L3 devices > > without visible hard header"), > > is more accurate as c

Re: [RFC v5 net-next] net: core: devlink: add 'dropped' stats field for traps

2021-02-06 Thread Ido Schimmel
On Thu, Feb 04, 2021 at 01:41:22PM +0200, Oleksandr Mazur wrote: > Whenever query statistics is issued for trap, devlink subsystem > would also fill-in statistics 'dropped' field. This field indicates > the number of packets HW dropped and failed to report to the device driver, > and thus - to the

[no subject]

2021-02-06 Thread Barrister Daven Bango
-- Korisnik fonda čestitanja, Vaša sredstva za naknadu od 850.000,00 američkih dolara odobrila je Međunarodna monetarna organizacija (MMF) u suradnji s (FBI) nakon mnogo istraga. Čekamo da se obratimo za dodatne informacije Advokat: Daven Bango Telefon: +22891667276 (URED MMF-a LOME TOGO)

Re: [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem

2021-02-06 Thread Lech Perczak
Hi, W dniu 2021-02-06 o 15:19, Bjørn Mork pisze: Lech Perczak writes: The modem is used inside ZTE MF283+ router and carriers identify it as such. Interface mapping is: 0: QCDM, 1: AT (PCUI), 2: AT (Modem), 3: QMI, 4: ADB T: Bus=02 Lev=02 Prnt=02 Port=05 Cnt=01 Dev#= 3 Spd=480 MxCh= 0 D:

Re: [PATCH net-next 1/7] netdevsim: Add support for add and delete of a PCI PF port

2021-02-06 Thread kernel test robot
Hi Parav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Parav-Pandit/netdevsim-port-add-delete-support/20210206-210153 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Re: [PATCH v2 1/2] net: usb: qmi_wwan: support ZTE P685M modem

2021-02-06 Thread Bjørn Mork
Lech Perczak writes: > The modem is used inside ZTE MF283+ router and carriers identify it as > such. > Interface mapping is: > 0: QCDM, 1: AT (PCUI), 2: AT (Modem), 3: QMI, 4: ADB > > T: Bus=02 Lev=02 Prnt=02 Port=05 Cnt=01 Dev#= 3 Spd=480 MxCh= 0 > D: Ver= 2.01 Cls=00(>ifc ) Sub=00 Prot=00

[PATCH 1/3] mlx5_vdpa: should exclude header length and fcs from mtu

2021-02-06 Thread Si-Wei Liu
When feature VIRTIO_NET_F_MTU is negotiated on mlx5_vdpa, 22 extra bytes worth of MTU length is shown in guest. This is because the mlx5_query_port_max_mtu API returns the "hardware" MTU value, which does not just contain the Ethernet payload, but includes extra lengths starting from the Ethernet h

[PATCH 2/3] mlx5_vdpa: fix feature negotiation across device reset

2021-02-06 Thread Si-Wei Liu
The mlx_features denotes the capability for which set of virtio features is supported by device. In principle, this field needs not be cleared during virtio device reset, as this capability is static and does not change across reset. In fact, the current code may have the assumption that mlx_featu

[PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-06 Thread Si-Wei Liu
While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device. The saved avail_index is used to restate the virtq once device is started. Commit b35ccebe3ef7 introduced the clear_virtqueues() routine to reset the saved av

  1   2   >