On Wed, 3 Feb 2021 12:56:52 -0800 Sukadev Bhattiprolu wrote:
> Willem de Bruijn [willemdebruijn.ker...@gmail.com] wrote:
> > On Wed, Feb 3, 2021 at 12:10 AM Sukadev Bhattiprolu
> > <suka...@linux.ibm.com> wrote:
> > >
> > > If two or more instances of 'ip link set' commands race and first one
> > > already brings the interface up (or down), the subsequent instances
> > > can simply return without redoing the up/down operation.
> > >
> > > Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> > > Reported-by: Abdul Haleem <abdha...@in.ibm.com>
> > > Tested-by: Abdul Haleem <abdha...@in.ibm.com>
> > > Signed-off-by: Sukadev Bhattiprolu <suka...@linux.ibm.com>
> > >
> > > ---
> > > Changelog[v2] For consistency with ibmvnic_open() use "goto out" and
> > > return
> > > from end of function.
> >
> > Did you find the code path that triggers this?
>
> Not yet. I need to find time on the system to repro/debug that
> >
> > In v1 we discussed how the usual ip link path should not call the
> > driver twice based on IFF_UP.
>
> Yes, we can hold this patch for now if necessary. Hopefully Patch 1/2 is
> ok.
Patch 1 does not apply to net as is. Please rebase and fix up the
comments the way I fixed them for
"ibmvnic: Clear failover_pending if unable to schedule"
Thanks!
