Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing

2020-12-08 Thread Marc Kleine-Budde
On 12/8/20 7:07 PM, Jakub Kicinski wrote: > On Tue, 8 Dec 2020 13:54:28 +0100 Oliver Hartkopp wrote: >> On 05.12.20 22:09, Jakub Kicinski wrote: >>> On Sat, 5 Dec 2020 21:56:33 +0100 Marc Kleine-Budde wrote: On 12/5/20 9:33 PM, Jakub Kicinski wrote: >> What about the (incremental?) cha

Re: [PATCH v1 net-next 04/15] net/tls: expose get_netdev_for_sock

2020-12-08 Thread Boris Pismenny
On 09/12/2020 3:06, David Ahern wrote: > On 12/7/20 2:06 PM, Boris Pismenny wrote: >> get_netdev_for_sock is a utility that is used to obtain >> the net_device structure from a connected socket. >> >> Later patches will use this for nvme-tcp DDP and DDP CRC offloads. >> >> Signed-off-by: Boris Pism

[PATCH net-next v2 07/14] net/mlx5: SF, Add auxiliary device driver

2020-12-08 Thread saeed
From: Parav Pandit Add auxiliary device driver for mlx5 subfunction auxiliary device. A mlx5 subfunction is similar to PCI PF and VF. For a subfunction an auxiliary device is created. As a result, when mlx5 SF auxiliary device binds to the driver, its netdev and rdma device are created, they ap

[PATCH net-next v2 08/14] net/mlx5: E-switch, Prepare eswitch to handle SF vport

2020-12-08 Thread saeed
From: Vu Pham Prepare eswitch to handle SF vport during (a) querying eswitch functions (b) egress ACL creation (c) account for SF vports in total vports calculation Assign a dedicated placeholder for SFs vports and their representors. They are placed after VFs vports and before ECPF vports as be

[PATCH net-next v2 12/14] devlink: Add devlink port documentation

2020-12-08 Thread saeed
From: Parav Pandit Added documentation for devlink port and port function related commands. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Jacob Keller Signed-off-by: Saeed Mahameed --- Changelog: v5->v6: - added label for devlink port to refer in other documentation - re

[PATCH net-next v2 05/14] net/mlx5: Introduce vhca state event notifier

2020-12-08 Thread saeed
From: Parav Pandit vhca state events indicates change in the state of the vhca that may occur due to a SF allocation, deallocation or enabling/disabling the SF HCA. Introduce vhca state event handler which will be used by SF devlink port manager and SF hardware id allocator in subsequent patches

[PATCH net-next v2 10/14] net/mlx5: SF, Add port add delete functionality

2020-12-08 Thread saeed
From: Parav Pandit To handle SF port management outside of the eswitch as independent software layer, introduce eswitch notifier APIs so that upper layer who wish to support sf port management in switchdev mode can perform its task whenever eswitch mode is set to switchdev or before eswitch is di

[PATCH net-next v2 09/14] net/mlx5: E-switch, Add eswitch helpers for SF vport

2020-12-08 Thread saeed
From: Parav Pandit Add helpers to enable/disable eswitch port, register its devlink port and load its representor. Signed-off-by: Vu Pham Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- Changelog: v1->v2: - cut down extra api for vport enable/disable ---

[PATCH net-next v2 13/14] devlink: Extend devlink port documentation for subfunctions

2020-12-08 Thread saeed
From: Parav Pandit Add devlink port documentation for subfunction management. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- Changelog: v1->v2: - new patch --- Documentation/driver-api/auxiliary_bus.rst| 2 + .../networking/devlink/devlink-port.rst | 89

[PATCH net-next v2 11/14] net/mlx5: SF, Port function state change support

2020-12-08 Thread saeed
From: Parav Pandit Support changing the state of the SF port's function through devlink. When activating the SF port's function, enable the hca in the device followed by adding its auxiliary device. When deactivating the SF port's function, delete its auxiliary device followed by disabling the vH

[PATCH net-next v2 14/14] net/mlx5: Add devlink subfunction port documentation

2020-12-08 Thread saeed
From: Parav Pandit Add documentation for subfunction management using devlink port. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- Changelog: v1->v2: - new patch --- .../device_drivers/ethernet/mellanox/mlx5.rst | 204 ++ 1 file changed, 204 insertions(+) diff

[PATCH net-next v2 04/14] devlink: Support get and set state of port function

2020-12-08 Thread saeed
From: Parav Pandit devlink port function can be in active or inactive state. Allow users to get and set port function's state. When the port function it activated, its operational state may change after a while when the device is created and driver binds to it. Similarly on deactivation flow. T

[PATCH net-next v2 06/14] net/mlx5: SF, Add auxiliary device support

2020-12-08 Thread saeed
From: Parav Pandit Introduce API to add and delete an auxiliary device for an SF. Each SF has its own dedicated window in the PCI BAR 2. SF device is similar to PCI PF and VF that supports multiple class of devices such as net, rdma and vdpa. SF device will be added or removed in subsequent pat

[PATCH net-next v2 02/14] devlink: Introduce PCI SF port flavour and port attribute

2020-12-08 Thread saeed
From: Parav Pandit A PCI sub-function (SF) represents a portion of the device similar to PCI VF. In an eswitch, PCI SF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with SF, and its representor netdevice, int

[PATCH net-next v2 03/14] devlink: Support add and delete devlink port

2020-12-08 Thread saeed
From: Parav Pandit Extended devlink interface for the user to add and delete port. Extend devlink to connect user requests to driver to add/delete such port in the device. When driver routines are invoked, devlink instance lock is not held. This enables driver to perform several devlink objects

[PATCH net-next v2 00/14] Add mlx5 subfunction support

2020-12-08 Thread saeed
From: Parav Pandit Hi Dave, Jakub, Jason, This series form Parav was the theme of this mlx5 release cycle, we've been waiting anxiously for the auxbus infrastructure to make it into the kernel, and now as the auxbus is in and all the stars are aligned, I can finally submit this V2 of the devlink

[PATCH net-next v2 01/14] devlink: Prepare code to fill multiple port function attributes

2020-12-08 Thread saeed
From: Parav Pandit Prepare code to fill zero or more port function optional attributes. Subsequent patch makes use of this to fill more port function attributes. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- net/core/devlink.c | 6

Re: [PATCH 069/141] ath5k: Fix fall-through warnings for Clang

2020-12-08 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva >

[PATCH -next v2] net/mlx5_core: remove unused including

2020-12-08 Thread Zou Wei
Remove including that don't need it. Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") Signed-off-by: Zou Wei --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/ne

答复: [PATCH -next] net/mlx5_core: remove unused including

2020-12-08 Thread Zouwei (Samuel)
ok, I will add the Fixes line and send the v2 soon. -邮件原件- 发件人: Leon Romanovsky [mailto:l...@kernel.org] 发送时间: 2020年12月9日 14:21 收件人: Jakub Kicinski 抄送: Zouwei (Samuel) ; sae...@nvidia.com; da...@davemloft.net; netdev@vger.kernel.org; linux-r...@vger.kernel.org; linux-ker...@vger.kernel

Re: [PATCH -next] net/mlx5_core: remove unused including

2020-12-08 Thread Leon Romanovsky
On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > Remove including that don't need it. > > > > Signed-off-by: Zou Wei > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > 1 file changed, 1 deletion(-) > > > >

[PATCH net-next 1/3] net: core: introduce __netdev_notify_peers

2020-12-08 Thread Lijun Pan
There are some use cases for netdev_notify_peers in the context when rtnl lock is already held. Introduce lockless version of netdev_notify_peers call to save the extra code to call call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, dev); call_netdevice_notifiers(NETDEV_RESEND_IGMP, dev)

[PATCH net-next 2/3] use __netdev_notify_peers in ibmvnic

2020-12-08 Thread Lijun Pan
Start to use the lockless version of netdev_notify_peers. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index cb701a6c0712..626e

[PATCH net-next 3/3] use __netdev_notify_peers in hyperv

2020-12-08 Thread Lijun Pan
Start to use the lockless version of netdev_notify_peers. Cc: Haiyang Zhang Signed-off-by: Lijun Pan --- drivers/net/hyperv/netvsc_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index d17bbc75f5e7

[PATCH net-next 0/3] lockless version of netdev_notify_peers

2020-12-08 Thread Lijun Pan
This series introduce the lockless version of netdev_notify_peers and then apply it to the relevant drivers. In v1, a more appropriate name __netdev_notify_peers is used; netdev_notify_peers is converted to call the new helper. Lijun Pan (3): net: core: introduce __netdev_notify_peers use __

[PATCH v16 6/9] arm64/kvm: Add hypercall service for kvm ptp.

2020-12-08 Thread Jianyong Wu
ptp_kvm will get this service through SMCC call. The service offers wall time and cycle count of host to guest. The caller must specify whether they want the host cycle count or the difference between host cycle count and cntvoff. Signed-off-by: Jianyong Wu --- arch/arm64/kvm/hypercalls.c | 59 +

[PATCH v16 1/9] arm64: Probe for the presence of KVM hypervisor

2020-12-08 Thread Jianyong Wu
From: Will Deacon Although the SMCCC specification provides some limited functionality for describing the presence of hypervisor and firmware services, this is generally applicable only to functions designated as "Arm Architecture Service Functions" and no portable discovery mechanism is provided

[PATCH v16 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2020-12-08 Thread Jianyong Wu
Currently, there is no mechanism to keep time sync between guest and host in arm/arm64 virtualization environment. Time in guest will drift compared with host after boot up as they may both use third party time sources to correct their time respectively. The time deviation will be in order of milli

[PATCH v16 0/9] Enable ptp_kvm for arm/arm64

2020-12-08 Thread Jianyong Wu
Currently, we offen use ntp (sync time with remote network clock) to sync time in VM. But the precision of ntp is subject to network delay so it's difficult to sync time in a high precision. kvm virtual ptp clock (ptp_kvm) offers another way to sync time in VM, as the remote clock locates in the h

[PATCH v16 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent.

2020-12-08 Thread Jianyong Wu
Currently, ptp_kvm modules implementation is only for x86 which includes large part of arch-specific code. This patch moves all of this code into a new arch related file in the same directory. Signed-off-by: Jianyong Wu --- drivers/ptp/Makefile| 1 + drivers/ptp/{ptp_kv

[PATCH v16 5/9] clocksource: Add clocksource id for arm arch counter

2020-12-08 Thread Jianyong Wu
Add clocksource id for arm arch counter to let it be identified easily and elegantly in ptp_kvm implementation for arm. Signed-off-by: Jianyong Wu --- drivers/clocksource/arm_arch_timer.c | 2 ++ include/linux/clocksource_ids.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/c

[PATCH v16 8/9] doc: add ptp_kvm introduction for arm64 support

2020-12-08 Thread Jianyong Wu
PTP_KVM implementation depends on hypercall using SMCCC. So we introduce a new SMCCC service ID. This doc explains how does the ID define and how does PTP_KVM works on arm/arm64. Signed-off-by: Jianyong Wu --- Documentation/virt/kvm/api.rst | 9 +++ Documentation/virt/kvm/arm/index.

[PATCH v16 9/9] arm64: Add kvm capability check extension for ptp_kvm

2020-12-08 Thread Jianyong Wu
Let userspace check if there is kvm ptp service in host. Before VMs migrate to another host, VMM may check if this cap is available to determine the next behavior. Signed-off-by: Jianyong Wu Suggested-by: Marc Zyngier --- arch/arm64/kvm/arm.c | 1 + include/uapi/linux/kvm.h | 1 + 2 files c

[PATCH v16 4/9] time: Add mechanism to recognize clocksource in time_get_snapshot

2020-12-08 Thread Jianyong Wu
From: Thomas Gleixner System time snapshots are not conveying information about the current clocksource which was used, but callers like the PTP KVM guest implementation have the requirement to evaluate the clocksource type to select the appropriate mechanism. Introduce a clocksource id field in

[PATCH v16 2/9] arm/arm64: KVM: Advertise KVM UID to guests via SMCCC

2020-12-08 Thread Jianyong Wu
From: Will Deacon We can advertise ourselves to guests as KVM and provide a basic features bitmap for discoverability of future hypervisor services. Cc: Marc Zyngier Signed-off-by: Will Deacon Signed-off-by: Jianyong Wu --- arch/arm64/kvm/hypercalls.c | 27 ++- 1 file

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-08 Thread John Fastabend
> On Mon, Dec 07, 2020 at 12:52:22PM -0800, John Fastabend wrote: > > Jesper Dangaard Brouer wrote: > > > On Fri, 4 Dec 2020 16:21:08 +0100 > > > Daniel Borkmann wrote: [...] pruning the thread to answer Jesper. > > > > > > Use-case(2): Disable XDP_TX on a driver to save hardware TX-queue > > >

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-08 Thread John Fastabend
Toke Høiland-Jørgensen wrote: > Jesper Dangaard Brouer writes: > > > On Mon, 7 Dec 2020 18:01:00 -0700 > > David Ahern wrote: > > > >> On 12/7/20 1:52 PM, John Fastabend wrote: > >> >> > >> >> I think we need to keep XDP_TX action separate, because I think that > >> >> there are use-cases where

Re: [PATCH iproute2-net v2 1/3] devlink: Add devlink reload action and limit options

2020-12-08 Thread Moshe Shemesh
On 12/9/2020 4:46 AM, David Ahern wrote: On 12/6/20 10:35 PM, Moshe Shemesh wrote: + print_string(PRINT_ANY, NULL, "%s", reload_action_name(action)); That line should be: print_string(PRINT_ANY, NULL, "%s", re

[PATCH v11 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-12-08 Thread Pavana Sharma
The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Co-developed-by: Ashkan

[PATCH v11 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

2020-12-08 Thread Pavana Sharma
Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 ++-- drivers/net

[PATCH v11 2/4] net: phy: Add 5GBASER interface mode

2020-12-08 Thread Pavana Sharma
Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 56563e5e0dc7..8151e6ecf1b9 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7 @@

[PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-12-08 Thread Pavana Sharma
Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-

[PATCH v11 0/4] Add support for mv88e6393x family of Marvell

2020-12-08 Thread Pavana Sharma
Updated patchset after incorporating feedback. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int net: dsa: mv88e6xxx: Add support for mv88e6393x family of

Re: [PATCH v2 1/1] xdp: avoid calling kfree twice

2020-12-08 Thread Zhu Yanjun
On Wed, Dec 9, 2020 at 1:12 AM Daniel Borkmann wrote: > > On 12/9/20 6:03 AM, Zhu Yanjun wrote: > > In the function xdp_umem_pin_pages, if npgs != umem->npgs and > > npgs >= 0, the function xdp_umem_unpin_pages is called. In this > > function, kfree is called to handle umem->pgs, and then in the >

[PATCH net] tcp: fix cwnd-limited bug for TSO deferral where we send nothing

2020-12-08 Thread Neal Cardwell
From: Neal Cardwell When cwnd is not a multiple of the TSO skb size of N*MSS, we can get into persistent scenarios where we have the following sequence: (1) ACK for full-sized skb of N*MSS arrives -> tcp_write_xmit() transmit full-sized skb with N*MSS -> move pacing release time forward ->

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-08 Thread Sven Van Asbroeck
On Tue, Dec 8, 2020 at 6:36 PM Florian Fainelli wrote: > > dma_sync_single_for_{cpu,device} is what you would need in order to make > a partial cache line invalidation. You would still need to unmap the > same address+length pair that was used for the initial mapping otherwise > the DMA-API debugg

[PATCH net-next V8] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-12-08 Thread Dmytro Shytyi
Variable SLAAC [Can be activated via sysctl]: SLAAC with prefixes of arbitrary length in PIO (randomly generated hostID or stable privacy + privacy extensions). The main problem is that SLAAC RA or PD allocates a /64 by the Wireless carrier 4G, 5G to a mobile hotspot, however segmentation of the /

[PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-08 Thread Xie He
According to the X.25 documentation, there was a plan to implement X.25-over-802.2-LLC. It never finished but left various code stubs in the X.25 code. At this time it is unlikely that it would ever finish so it may be better to remove those code stubs. Also change the documentation to make it cle

Re: [PATCH net-next] bcm63xx_enet: batch process rx path

2020-12-08 Thread Sieng Piaw Liew
On Fri, Dec 04, 2020 at 10:50:45AM +0100, Eric Dumazet wrote: > > > On 12/4/20 6:46 AM, Sieng Piaw Liew wrote: > > Use netif_receive_skb_list to batch process rx skb. > > Tested on BCM6328 320 MHz using iperf3 -M 512, increasing performance > > by 12.5%. > > > > > > Well, the real question is

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-08 Thread Martin KaFai Lau
On Tue, Dec 08, 2020 at 05:17:48PM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Mon, 7 Dec 2020 23:34:41 -0800 > > On Tue, Dec 08, 2020 at 03:31:34PM +0900, Kuniyuki Iwashima wrote: > > > From: Martin KaFai Lau > > > Date: Mon, 7 Dec 2020 12:33:15 -0800 > > > > On Thu,

Re: pull-request: wireless-drivers-next-2020-12-03

2020-12-08 Thread Brian Norris
Hi Jakub, On Mon, Dec 7, 2020 at 12:10 PM Jakub Kicinski wrote: > On Mon, 7 Dec 2020 11:35:53 -0800 Brian Norris wrote: > > On Mon, Dec 7, 2020 at 2:42 AM Kalle Valo wrote: > > > Jakub Kicinski writes: > > > > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: > > > > There's also a pat

Re: [PATCH iproute2-net v2 1/3] devlink: Add devlink reload action and limit options

2020-12-08 Thread David Ahern
On 12/6/20 10:35 PM, Moshe Shemesh wrote: > + print_string(PRINT_ANY, NULL, "%s", > reload_action_name(action)); That line should be: print_string(PRINT_ANY, NULL, "%s", reload_action_name(action)); to fit preferred

Re: [PATCH iproute2-next v2 0/7] Move rate and size parsing and output to lib

2020-12-08 Thread David Ahern
On 12/5/20 2:13 PM, Petr Machata wrote: > The DCB tool will have commands that deal with buffer sizes and traffic > rates. TC is another tool that has a number of such commands, and functions > to support them: get_size(), get_rate/64(), s/print_size() and > s/print_rate(). In this patchset, these

Re: [iproute2-next v2] seg6: add support for vrftable attribute in SRv6 End.DT4/DT6 behaviors

2020-12-08 Thread David Ahern
On 12/2/20 6:15 AM, Paolo Lungaroni wrote: > We introduce the "vrftable" attribute for supporting the SRv6 End.DT4 and > End.DT6 behaviors in iproute2. > The "vrftable" attribute indicates the routing table associated with > the VRF device used by SRv6 End.DT4/DT6 for routing IPv4/IPv6 packets. >

Re: pull-request: wireless-drivers-next-2020-12-03

2020-12-08 Thread Brian Norris
On Tue, Dec 8, 2020 at 7:01 AM Edward Cree wrote: > My understanding is that it's because users can have them in their > modprobe.conf, which causes breakage if an update removes the param. > I think the module insert fails if there are unrecognised parameters > there. That's a nice understand

Re: ❌ FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org)

2020-12-08 Thread Jianlin Shi
Hi , I reported a bug in bugzilla.kernel.org for geneve issue: https://bugzilla.kernel.org/show_bug.cgi?id=210569 Thanks & Best Regards, Jianlin Shi On Tue, Dec 8, 2020 at 9:38 AM Jianlin Shi wrote: > > Hi , > > > On Tue, Dec 8, 2020 at 8:25 AM CKI Project wrote: >> >> >> Hello, >> >> We ran

WARNING in ieee80211_start_next_roc

2020-12-08 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e87297fa Merge tag 'drm-fixes-2020-12-04' of git://anongit.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17d9c9d350 kernel config: https://syzkaller.appspot.com/x/.config?x=e49433cfed49b7d9 das

Re: [PATCH v3 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-08 Thread Vladimir Oltean
On Mon, Dec 07, 2020 at 05:09:37PM -0800, Jakub Kicinski wrote: > > + ocelot->owq = alloc_ordered_workqueue("ocelot-owq", WQ_MEM_RECLAIM); > > Why MEM_RECLAIM ? Ok, fine, I admit, I copied it. After reading the documentation a bit more thoroughly, I am still as clear about the guidelines as bef

[PATCH net-next v3] net: hdlc_x25: Remove unnecessary skb_reset_network_header calls

2020-12-08 Thread Xie He
1. In x25_xmit, skb_reset_network_header is not necessary before we call lapb_data_request. The lapb module doesn't need skb->network_header. So there is no need to set skb->network_header before calling lapb_data_request. 2. In x25_data_indication (called by the lapb module after data have been r

[PATCH net-next v2] net: hdlc_x25: Remove unnecessary skb_reset_network_header calls

2020-12-08 Thread Xie He
1. In x25_xmit, skb_reset_network_header is not necessary before we call lapb_data_request. The lapb module doesn't need skb->network_header. So there is no need to set skb->network_header before calling lapb_data_request. 2. In x25_data_indication (called by the lapb module after some data have b

Re: [RFC PATCH net-next 05/13] net: bonding: hold the netdev lists lock when retrieving device statistics

2020-12-08 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 03:14:04AM +0200, Vladimir Oltean wrote: > net_failover and bonding are the only drivers that are creating this > recursivity requirement in dev_get_stats. Other one-over-many stackable > interfaces, like the bridge, just use dev_get_tstats64. I'm almost > thinking that it w

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-08 Thread Andrew Lunn
> dma_sync_single_for_{cpu,device} is what you would need in order to make > a partial cache line invalidation. You would still need to unmap the > same address+length pair that was used for the initial mapping otherwise > the DMA-API debugging will rightfully complain. But often you don't unmap i

[PATCH v2 net-next] net/mlx4: simplify the return expression of mlx4_init_cq_table()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/mellanox/mlx4/cq.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cq.c b/drivers/net/ethernet/mellanox/mlx4/cq.c index 3b8576b9c2f9..f7053a74e6a

Re: [RFC PATCH net-next 05/13] net: bonding: hold the netdev lists lock when retrieving device statistics

2020-12-08 Thread Vladimir Oltean
On Tue, Dec 08, 2020 at 04:17:37PM -0800, Jakub Kicinski wrote: > On Wed, 9 Dec 2020 00:03:56 + Vladimir Oltean wrote: > > On Tue, Dec 08, 2020 at 03:57:44PM -0800, Jakub Kicinski wrote: > > > On Mon, 7 Dec 2020 01:00:40 + Vladimir Oltean wrote: > > > > - ensuring through convention that us

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-08 Thread Pali Rohár
On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > On Wednesday, September 23, 2020 3:22:15 AM PST Pali Rohár wrote: > > On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > > > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > > > And this part of code which you write is Realtek

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-08 Thread David Ahern
On 12/8/20 5:57 PM, David Ahern wrote: >> diff --git a/include/net/inet_connection_sock.h >> b/include/net/inet_connection_sock.h >> index 7338b3865a2a..a08b85b53aa8 100644 >> --- a/include/net/inet_connection_sock.h >> +++ b/include/net/inet_connection_sock.h >> @@ -66,6 +66,8 @@ struct inet_conn

[PATCH net-next] net: hdlc_x25: Remove unnecessary skb_reset_network_header calls

2020-12-08 Thread Xie He
1. In x25_xmit, skb_reset_network_header is not necessary before we call lapb_data_request. The lapb module doesn't need skb->network_header. So there is no need to set skb->network_header before calling lapb_data_request. 2. In x25_data_indication (called by the lapb module after it has processed

Re: [PATCH v1 net-next 04/15] net/tls: expose get_netdev_for_sock

2020-12-08 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > get_netdev_for_sock is a utility that is used to obtain > the net_device structure from a connected socket. > > Later patches will use this for nvme-tcp DDP and DDP CRC offloads. > > Signed-off-by: Boris Pismenny > Reviewed-by: Sagi Grimberg > --- >

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-08 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h > index 934de56644e7..fb35dcac03d2 100644 > --- a/include/linux/netdev_features.h > +++ b/include/linux/netdev_features.h > @@ -84,6 +84,7 @@ enum { > NETIF_F_GRO_FRAGLIS

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-08 Thread David Ahern
On 12/8/20 7:36 AM, Boris Pismenny wrote: > On 08/12/2020 2:42, David Ahern wrote: >> On 12/7/20 2:06 PM, Boris Pismenny wrote: >>> This commit introduces direct data placement offload for TCP. >>> This capability is accompanied by new net_device operations that >>> configure >>> hardware contexts.

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2020-12-08 Thread Julian Calaby
Hi Xiaohui, On Wed, Dec 9, 2020 at 12:07 AM Xiaohui Zhang wrote: > > From: Zhang Xiaohui > > mwifiex_config_scan() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary cod

Re: [PATCH net] tcp: Retain ECT bits for tos reflection

2020-12-08 Thread David Miller
From: Wei Wang Date: Tue, 8 Dec 2020 09:55:08 -0800 > For DCTCP, we have to retain the ECT bits set by the congestion control > algorithm on the socket when reflecting syn TOS in syn-ack, in order to > make ECN work properly. > > Fixes: ac8f1710c12b ("tcp: reflect tos value received in SYN to t

Re: [PATCH net-next] drivers: net: qlcnic: simplify the return expression of qlcnic_sriov_vf_shutdown()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 21:54:37 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: openvswitch: conntrack: simplify the return expression of ovs_ct_limit_get_default_limit()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 20:13:53 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net] tcp: select sane initial rcvq_space.space for big MSS

2020-12-08 Thread David Miller
From: Eric Dumazet Date: Tue, 8 Dec 2020 08:21:31 -0800 > From: Eric Dumazet > > Before commit a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to > around 64KB") > small tcp_rmem[1] values were overridden by tcp_fixup_rcvbuf() to accommodate > various MSS. > > This is no longer th

Re: [PATCH net-next] net: atheros: simplify the return expression of atl2_phy_setup_autoneg_adv()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 21:57:30 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-08 Thread Florian Fainelli
On 12/7/20 4:15 AM, Claudiu Beznea wrote: > Add function to disable all macb clocks. > > Signed-off-by: Claudiu Beznea > Suggested-by: Andrew Lunn > --- > drivers/net/ethernet/cadence/macb_main.c | 62 > > 1 file changed, 32 insertions(+), 30 deletions(-) > >

Re: [PATCH net-next] net/mlx4: simplify the return expression of mlx4_init_cq_table()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 21:55:43 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: ipv6: rpl_iptunnel: simplify the return expression of rpl_do_srh()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 20:09:49 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

[PATCH RESEND] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Mario Limonciello
From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. This helps both i219V and i219LM configurations. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Fixes: 632f

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 21:56:25 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: core: devlink: simplify the return expression of devlink_nl_cmd_trap_set_doit()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 20:10:46 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 19:48:56 +0100 Andrew Lunn wrote: > > -err_disable_rxclk: > > - clk_disable_unprepare(*rx_clk); > > - > > -err_disable_txclk: > > - clk_disable_unprepare(*tx_clk); > > - > > -err_disable_hclk: > > - clk_disable_unprepare(*hclk); > > - > > -err_disable_pclk: > > - clk_disa

Re: [PATCH net-next] net/sched: cls_u32: simplify the return expression of u32_reoffload_knode()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 20:08:22 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied

Re: [PATCH net-next] net: core: devlink: simplify the return expression of devlink_nl_cmd_trap_set_doit()

2020-12-08 Thread David Miller
From: Zheng Yongjun Date: Tue, 8 Dec 2020 20:10:46 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: dsa: mt7530: support setting ageing time

2020-12-08 Thread David Miller
From: DENG Qingfang Date: Tue, 8 Dec 2020 15:00:28 +0800 > MT7530 has a global address age control register, so use it to set > ageing time. > > The applied timer is (AGE_CNT + 1) * (AGE_UNIT + 1) seconds > > Signed-off-by: DENG Qingfang Applied, thanks

Re: [PATCH net v1 1/2] lan743x: improve performance: fix rx_napi_poll/interrupt ping-pong

2020-12-08 Thread Sven Van Asbroeck
On Tue, Dec 8, 2020 at 6:50 PM Eric Dumazet wrote: > > Driver could be called with an arbitrary budget (of 64), > and if its ring buffer has been depleted, return @budget instead of skb > counts, > and not ream the interrupt > Aha, so the decision to re-arm the interrupts is made by looking at w

Re: [RFC PATCH net-next 05/13] net: bonding: hold the netdev lists lock when retrieving device statistics

2020-12-08 Thread Jakub Kicinski
On Wed, 9 Dec 2020 00:03:56 + Vladimir Oltean wrote: > On Tue, Dec 08, 2020 at 03:57:44PM -0800, Jakub Kicinski wrote: > > On Mon, 7 Dec 2020 01:00:40 + Vladimir Oltean wrote: > > > - ensuring through convention that user space always takes > > > net->netdev_lists_lock when calling dev_

Re: [PATCH net] net: ll_temac: Fix potential NULL dereference in temac_probe()

2020-12-08 Thread David Miller
From: Zhang Changzhong Date: Tue, 8 Dec 2020 09:53:42 +0800 > platform_get_resource() may fail and in this case a NULL dereference > will occur. > > Fix it to use devm_platform_ioremap_resource() instead of calling > platform_get_resource() and devm_ioremap(). > > This is detected by Coccinelle

Re: [PATCH net-next v10 0/4] GVE Raw Addressing

2020-12-08 Thread David Miller
From: David Awogbemila Date: Mon, 7 Dec 2020 14:45:22 -0800 > Patchset description: > This patchset introduces "raw addressing" mode to the GVE driver. > Previously (in "queue_page_list" or "qpl" mode), the driver would > pre-allocate and dma_map buffers to be used on egress and ingress. > On e

Re: Refcount mismatch when unregistering netdevice from kernel

2020-12-08 Thread stranche
Hi Wei and Eric, Thanks for the replies. This was reported to us on the 5.4.61 kernel during a customer regression suite, so we don't have an exact reproducer unfortunately. From the trace logs we've added it seems like this is happening during IPv6 transport mode XFRM data transfer and the d

Re: [RFC PATCH net-next 05/13] net: bonding: hold the netdev lists lock when retrieving device statistics

2020-12-08 Thread Vladimir Oltean
On Tue, Dec 08, 2020 at 03:57:44PM -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 01:00:40 + Vladimir Oltean wrote: > > - ensuring through convention that user space always takes > > net->netdev_lists_lock when calling dev_get_stats, and documenting > > that, and therefore making it unne

Re: Refcount mismatch when unregistering netdevice from kernel

2020-12-08 Thread David Ahern
On 12/8/20 2:51 PM, Wei Wang wrote: > On Tue, Dec 8, 2020 at 11:13 AM wrote: >> >> Hi Wei and Eric, >> >> Thanks for the replies. >> >> This was reported to us on the 5.4.61 kernel during a customer >> regression suite, so we don't have an exact reproducer unfortunately. >> From the trace logs we

Re: [PATCH] net: sched: fix spelling mistake in Kconfig "trys" -> "tries"

2020-12-08 Thread David Miller
From: Colin King Date: Mon, 7 Dec 2020 16:12:31 + > From: Colin Ian King > > There is a spelling mistake in the Kconfig help text. Fix it. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: pull request: bluetooth-next 2020-12-07

2020-12-08 Thread David Miller
From: Johan Hedberg Date: Mon, 7 Dec 2020 17:09:15 +0200 > Hi Dave, Jakub, > > Here's the main bluetooth-next pull request for the 5.11 kernel. > > - Updated Bluetooth entries in MAINTAINERS to include Luiz von Dentz > - Added support for Realtek 8822CE and 8852A devices > - Added support fo

Re: [PATCH net-next] net/af_iucv: use DECLARE_SOCKADDR to cast from sockaddr

2020-12-08 Thread David Miller
From: Julian Wiedmann Date: Mon, 7 Dec 2020 13:53:07 +0100 > This gets us compile-time size checking. > > Signed-off-by: Julian Wiedmann Applied, thanks.

Re: [RFC PATCH net-next 05/13] net: bonding: hold the netdev lists lock when retrieving device statistics

2020-12-08 Thread Jakub Kicinski
On Mon, 7 Dec 2020 01:00:40 + Vladimir Oltean wrote: > - ensuring through convention that user space always takes > net->netdev_lists_lock when calling dev_get_stats, and documenting > that, and therefore making it unnecessary to lock in bonding. This seems like the better option to me. Ma

Re: [PATCH] net: tipc: prevent possible null deref of link

2020-12-08 Thread David Miller
From: Cengiz Can Date: Mon, 7 Dec 2020 11:14:24 +0300 > `tipc_node_apply_property` does a null check on a `tipc_link_entry` > pointer but also accesses the same pointer out of the null check block. > > This triggers a warning on Coverity Static Analyzer because we're > implying that `e->link` c

[PATCH v2 bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-08 Thread Andrii Nakryiko
When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE relocation, put module BTF FD, containing target type, into upper 32 bits of imm64. Because this FD is internal to libbpf, it's very cumbersome to test this in selftests. Manual testing was performed with debug log messages sprinkle

Re: [RFC PATCH net-next 1/3] net: core: introduce netdev_notify_peers_locked

2020-12-08 Thread Jakub Kicinski
On Sat, 5 Dec 2020 23:21:25 -0600 Lijun Pan wrote: > There are some use cases for netdev_notify_peers in the context > when rtnl lock is already held. Introduce lockless version > of netdev_notify_peers call to save the extra code to call > call_netdevice_notifiers(NETDEV_NOTIFY_PEERS, dev);

  1   2   3   4   >